-
Notifications
You must be signed in to change notification settings - Fork 260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: aztec-cli "unbox" command #1825
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
dan-aztec
commented
Aug 26, 2023
// Address 0x2e13f0201905944184fc2c09d29fcf0cac07647be171656a275f63d99b819360 | ||
// const privateKey2 = PrivateKey.fromString('b2803ec899f76f6b2ac011480d24028f1a29587f8a3a92f7ee9d48d8c085c284'); | ||
// Address 0x0d557417a3ce7d7b356a8f15d79a868fd8da2af9c5f4981feb9bcf0b614bd17e | ||
// const privateKey = Buffer.from('6bb46e9a80da2ff7bfff71c2c50eaaa4b15f7ed5ad1ade4261b574ef80b0cdb0', 'hex'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(will clean up before landing)
I've converted this one to draft, until it's ready for review, so potential reviewers don't start reviewing until it's ready :) |
closing in favor of merging the functionality into leila's clean PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP, but almost working - frontend can communicate to sandbox via AztecRpcClient, but the calls don't work.
for some reason, the
Contract.at()
function is returning an object with undefinedmethods
... weird since this class is generated byaztec-cli compile
and they are present in the generated file.frontend needs CSS help.
feedback thus far:
(1) instead of looking up the install directory from npm i -g... for the aztec-cli package, let's download the noir-contracts from github directly (done)
(2) setup a new subpackage starter-kit for the barebones webserver + frontend (done, but it's basically the default next.js project. tried to merge its settings with our other subpackage package.json)
(3) need to fix compiling. does the copied Nargo.toml need to be updated? it's doing a relative path to noir-libs
resolved questions:
does this require a local sandbox running as well? (yes)
why aren't the formik forms working on the frontend? (css issue: z-index was too far behind)
PR is a copy of #1686 which got messed up from a squash, keeping that around just in case temporarily.
Checklist:
Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge.