Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: no unlimited retries by default in aztec.js #1723

Merged
merged 2 commits into from
Aug 22, 2023

Conversation

benesjan
Copy link
Contributor

@benesjan benesjan commented Aug 22, 2023

  1. Fixes Do not have unilimited retries by default in aztec.js #1722
  2. Fixes e2e_aztec_js_browser test inter-dependence (running a test case with it.only failed because it expected a previous it to be executed first)

Checklist:

Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge.

  • If the pull request requires a cryptography review (e.g. cryptographic algorithm implementations) I have added the 'crypto' tag.
  • I have reviewed my diff in github, line by line and removed unexpected formatting changes, testing logs, or commented-out code.
  • Every change is related to the PR description.
  • I have linked this pull request to relevant issues (if any exist).

@benesjan benesjan marked this pull request as draft August 22, 2023 10:20
@benesjan benesjan marked this pull request as ready for review August 22, 2023 11:37
@benesjan benesjan enabled auto-merge (squash) August 22, 2023 11:42
@benesjan benesjan requested a review from spypsy August 22, 2023 13:18
@benesjan benesjan merged commit 95d1350 into master Aug 22, 2023
@benesjan benesjan deleted the janb/no-default-unlimited-retries branch August 22, 2023 16:25
codygunton pushed a commit that referenced this pull request Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Do not have unilimited retries by default in aztec.js
2 participants