Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update bootstrap.sh in Barretenberg to check for clang 16 #1717

Merged
merged 10 commits into from
Aug 22, 2023
Merged

chore: update bootstrap.sh in Barretenberg to check for clang 16 #1717

Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
2d411c2
include check for node version 18 or higher on install
Orloaft Jul 12, 2023
158f937
update each package to check for node 18 or higher
Orloaft Jul 12, 2023
8038128
Merge remote-tracking branch 'upstream/master'
Orloaft Aug 12, 2023
8f0baee
Merge remote-tracking branch 'upstream/master'
Orloaft Aug 22, 2023
d8b72cd
add check for clang 16 in barretenberg
Orloaft Aug 22, 2023
387fa41
Merge branch 'master' into master
ludamad Aug 22, 2023
2bd7946
move clang check to bootstrap in cpp folder
Orloaft Aug 22, 2023
ece5f67
Merge remote-tracking branch 'upstream/master'
Orloaft Aug 22, 2023
305624e
Merge remote-tracking branch 'origin/master'
Orloaft Aug 22, 2023
244036f
Update bootstrap.sh
ludamad Aug 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 22 additions & 1 deletion circuits/cpp/barretenberg/cpp/bootstrap.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,26 @@
#!/bin/bash
set -eu
set -u

# Get the clang version string
clang_version_string=$(clang --version 2>/dev/null)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick: technically, since this script has -e, we would never hit the


# Check if clang is installed
if [ $? -ne 0 ]; then
  echo "Error: clang is not installed."
  exit 1
fi

case

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll add the set -e after this


# Check if clang is installed
if [ $? -ne 0 ]; then
echo "Error: clang is not installed."
exit 1
fi

# Extract the major version number
major_version=$(echo $clang_version_string | awk -F' ' '/clang version/{print $3}' | awk -F'.' '{print $1}')

if [ "$major_version" -ge 16 ]; then
echo "clang version $major_version is good."
else
echo "Error: clang version 16 or greater is required."
exit 1
fi

set -e

# Clean.
rm -rf ./build
Expand Down