fix(rpc): Fix bigint serialisation in API responses #1644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
rahul-kothari
approved these changes
Aug 18, 2023
|
|
||
| test('does not convert a string', () => { | ||
| expect(convertBigintsInObj('hello')).toEqual('hello'); | ||
| expect(convertBigintsInObj({ msg: 'hello' })).toEqual({ msg: 'hello' }); |
There was a problem hiding this comment.
is this expected over a throw Error?
There was a problem hiding this comment.
Yeah, the idea is that convertBigints would just returns the same data structure it received, but replacing any bigints it sees along the way. If there are no bigints, no changes needed.
The reason for this test is that the original implementation looped over strings as if they were collections, so I wanted to make sure there were no errors related to dealing with strings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes error in Sandbox getting started where querying the balance for a user would cause a Koa error.