Replace assert_contains with assert_contains_and_remove. #1636
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous
Set.assert_contains
can be misleading.A note in a Set might have been destroyed. But this could still generate a valid proof:
However, the ability to check if a note hash exists is useful. Because a note might not be shared via log. In which case, the user gets the preimage offline, and should be able to call a contract function with the preimage to claim a note or do something.
Before we add the feature properly, we can use
assert_contains_and_remove
to check that the note hash does exist, and destroy the note right after, to prevent developers making wrong assumption.Checklist:
Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge.