chore: make stdlib bn254 naming match native version #1560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a native and stdlib version of the struct
bn254, which describes the key curve parameters, e.g.ScalarField,Group, etc. (Eventually Grumpkin will have the same). There are other objects (e.g. Gemini, Shplonk) templated onCurvewhich should be agnostic to whether the types they're operating on are native or stdlib types. To facilitate this, I've updated the naming instdlib::bn254to match the corresponding native description incurve::BN254. Contexts for which the explicit "composer type" suffixctis desired can employ appropriate aliases.