Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: dedupe tsconfig, add build manifest management script #151

Merged
merged 75 commits into from
Apr 4, 2023
Merged

chore: dedupe tsconfig, add build manifest management script #151

merged 75 commits into from
Apr 4, 2023

Conversation

ludamad
Copy link
Collaborator

@ludamad ludamad commented Apr 3, 2023 •
edited
Loading

Description

  • Reduces the special test-only tsconfig files to a single one in the root
  • Adds a new script update_build_manifest.mjs that updates build manifest based on package deps

Checklist:

  • I have reviewed my diff in github, line by line.
  • Every change is related to the PR description.
  • I have linked this pull request to the issue(s) that it resolves.
  • There are no unexpected formatting changes, superfluous debug logs, or commented-out code.
  • The branch has been rebased against the head of its merge target.
  • I'm happy for the PR to be merged at the reviewer's next convenience.

ludamad and others added 30 commits March 30, 2023 14:41
@ludamad
chore: refactor tsconfig layout
4a4eb75
@ludamad
chore: refactor tsconfig layout
53f73c0
@ludamad
chore: package.json deriver
62b7f09
@ludamad
Fix jest
be02af8
@ludamad
Post refactor fixes
47fd8e2
@ludamad
Merge remote-tracking branch 'origin/master' into adam/chore/tsconfig…
255345f 
…-refactor
@ludamad
Revert circuits
6ef74f5
@ludamad
chore: refactor after tsconfig changes
dfd43de
@ludamad
Merge remote-tracking branch 'origin/master' into adam/chore/tsconfig…
5eea69c 
…-refactor-2
@ludamad
chore: update tsconfig to tsconfig.dest.json
3aff266
@ludamad
chore: revert circuits
81518b0
@ludamad
chore: prepare script
b4e936f
@ludamad
Intermediate commit
ca26a6f
@ludamad
chore: Fix all package builds
3d7be9b
@ludamad
Merge branch 'master' into adam/chore/tsconfig-refactor-2
f6bd9b0
@ludamad
Run yarn prepare
1f1fdb2
@ludamad
Merge remote-tracking branch 'origin/adam/chore/tsconfig-refactor-2' …
563aa2f 
…into adam/chore/tsconfig-refactor-2
@ludamad
chore: revert circuits
f9edc48
@ludamad
Fix acir
55c3d88
@ludamad
add missing tsconfig.dest.json files
177ad30
@ludamad
Update
176fcae
@ludamad
Fixes
a93d92a
@ludamad
Fixes
2bdf990
@ludamad
Fix merge
fb550cc
@ludamad
Fix merge
4e31b51
@ludamad
Fix merge
7a9c899
@ludamad
Fix merge
f1f0d22
@ludamad
Fix merge
19f3df6
@ludamad
Fix merge
8487a12
@ludamad
Fix merge
fcc7a09
ludamad added 20 commits April 3, 2023 17:22
@ludamad
Debugging...
ceb7404
@ludamad
Merge remote-tracking branch 'origin/master' into adam/chore/tsconfig…
6c92c6e 
…-dedupe
@ludamad
Revert
a6f1713
@ludamad
chore: reduce diff
30b655c
@ludamad
chore: reduce diff
75aae7e
@ludamad
Fix build
39106e4
@ludamad
Merge remote-tracking branch 'origin/master' into adam/chore/tsconfig…
a87b569 
…-dedupe
@ludamad
Post merge fixes
d5105a0
@ludamad
Post merge fixes
9e2d58e
@ludamad
Merge remote-tracking branch 'origin/master' into adam/chore/tsconfig…
ddc20c9 
…-dedupe
@ludamad
Post merge fixes
dbadbcc
@ludamad
Post merge fixes
b041545
@ludamad
Merge remote-tracking branch 'origin/master' into adam/chore/tsconfig…
4ec4270 
…-dedupe
@ludamad
Merge remote-tracking branch 'origin/master' into adam/chore/tsconfig…
d97877e 
…-dedupe
@ludamad
Fix build
65913ae
@ludamad
fix: comment
a00e006
@ludamad
Fix build
62f96f8
@ludamad
Fix build
335cb90
@ludamad
fix: ide experience
0e2b229
@ludamad
fix: ethereum.js test
9b8d9ca
@ludamad
Copy link
Collaborator Author

ludamad commented Apr 4, 2023

@spalladino mind reviewing this PR? It's the same intent the other PR, but without the magic import scanning, and rebased against master

spalladino
spalladino approved these changes Apr 4, 2023
View reviewed changes
Copy link
Collaborator

@spalladino spalladino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Pulling deps from package.json feels a lot cleaner than parsing ts code. And thanks for the much-needed README update!

@ludamad ludamad merged commit c06bb94 into master Apr 4, 2023
@ludamad ludamad deleted the adam/chore/tsconfig-dedupe branch April 4, 2023 12:41
ludamad pushed a commit that referenced this pull request Apr 14, 2023
@suyash67
Fix Contract Deployment Circuit Test (#151)
086b008 
* update bb to point to `sb/fix-push-array-array`.

* (chore)

* improve test.

* (chore)

* minor changes.

* use bb/aztec3.
ludamad pushed a commit that referenced this pull request Apr 17, 2023
@suyash67 @ludamad
Fix Contract Deployment Circuit Test (#151)
8efc2f5 
* update bb to point to `sb/fix-push-array-array`.

* (chore)

* improve test.

* (chore)

* minor changes.

* use bb/aztec3.
ludamad pushed a commit that referenced this pull request Apr 17, 2023
@suyash67 @ludamad
Fix Contract Deployment Circuit Test (#151)
547040f 
* update bb to point to `sb/fix-push-array-array`.

* (chore)

* improve test.

* (chore)

* minor changes.

* use bb/aztec3.
ludamad pushed a commit that referenced this pull request Jul 14, 2023
@phated
feat: Utilize globally installed gtest if available (#151)
13dd8f8
codygunton pushed a commit that referenced this pull request Jan 23, 2024
@phated
feat: Utilize globally installed gtest if available (#151)
efa18a6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spalladino spalladino spalladino approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ludamad @spalladino