chore: disable fft functions for polynomials instantiated on Grumpkin #1471
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #635 bberg and extend testing in
polynomial_arithmetic.test.cpp
. We now test all the functionality not related to FFT on both curves (Grumpkin doesn't have many roots of unity and we can't do FFTs on it). It also disables FFT related methods when thePolynomial
class and methods inpolynomial_arithmetic
are instantiated with Grumpkin.Checklist:
Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge.