Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: disable fft functions for polynomials instantiated on Grumpkin #1471

Merged
merged 2 commits into from
Aug 10, 2023

Conversation

maramihali
Copy link
Contributor

@maramihali maramihali commented Aug 8, 2023

This PR resolves #635 bberg and extend testing in polynomial_arithmetic.test.cpp. We now test all the functionality not related to FFT on both curves (Grumpkin doesn't have many roots of unity and we can't do FFTs on it). It also disables FFT related methods when the Polynomial class and methods in polynomial_arithmetic are instantiated with Grumpkin.

Checklist:

Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge.

  • If the pull request requires a cryptography review (e.g. cryptographic algorithm implementations) I have added the 'crypto' tag.
  • I have reviewed my diff in github, line by line and removed unexpected formatting changes, testing logs, or commented-out code.
  • Every change is related to the PR description.
  • I have linked this pull request to relevant issues (if any exist).

@maramihali maramihali added the crypto cryptography label Aug 8, 2023
@maramihali maramihali force-pushed the mm/polynomials-on-grumpkin branch from 7fcc2a6 to 973778d Compare August 8, 2023 20:37
@maramihali maramihali marked this pull request as ready for review August 8, 2023 20:37
@maramihali maramihali force-pushed the mm/polynomials-on-grumpkin branch from 973778d to 545144b Compare August 9, 2023 09:20
@maramihali maramihali force-pushed the mm/polynomials-on-grumpkin branch from 545144b to 4af5eb1 Compare August 10, 2023 10:13
@maramihali maramihali force-pushed the mm/polynomials-on-grumpkin branch from 4af5eb1 to 4180c77 Compare August 10, 2023 10:18
@maramihali maramihali enabled auto-merge (squash) August 10, 2023 10:29
@maramihali maramihali merged commit f09909a into master Aug 10, 2023
@maramihali maramihali deleted the mm/polynomials-on-grumpkin branch August 10, 2023 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
crypto cryptography
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Refactor the tests in polynomial_arithmetic.test.cpp to also run on grumpkin::fr
2 participants