chore(contracts): Rename Schnorr multi key account to just Schnorr account #1447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The name
SchnorrMultiKeyAccountwas confusing, since it seems to hint to a multisig contract, whereas it's just a contract with a signing key that's separate from the encryption key. Since this should be the default behaviour for all account contracts, this PR renamesSchnorrMultiKeyAccountto justSchnorrAccount, following the same naming asEcdsaAccount.The distinct one,
SchnorrSingleKeyAccount, which uses a single key for encryption and signing (which is advised against) still has that name until we can think of a better one.