Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(noir-ci): reinstate artifact builds #1396

Merged
merged 5 commits into from
Aug 3, 2023
Merged

fix(noir-ci): reinstate artifact builds #1396

merged 5 commits into from
Aug 3, 2023

Conversation

Maddiaa0
Copy link
Member

@Maddiaa0 Maddiaa0 commented Aug 3, 2023

This pr reintroduces the old build step such that the @aztec/noir-contracts package can be published correctly.

  • It changes the name of the old noir-contracts build step to noir-contracts-build to prevent the npm publish publishing the build step container rather than the artifacts container

Question:

  • Ive just copied the dockerfile from every other repo, i assume its fine if i just remove formatting for the noir contracts stuff

Checklist:

Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge.

  • If the pull request requires a cryptography review (e.g. cryptographic algorithm implementations) I have added the 'crypto' tag.
  • I have reviewed my diff in github, line by line and removed unexpected formatting changes, testing logs, or commented-out code.
  • Every change is related to the PR description.
  • I have linked this pull request to relevant issues (if any exist).

@Maddiaa0 Maddiaa0 marked this pull request as ready for review August 3, 2023 10:43
@Maddiaa0 Maddiaa0 requested review from ludamad and PhilWindle August 3, 2023 10:43
@Maddiaa0 Maddiaa0 enabled auto-merge (squash) August 3, 2023 10:49
@Maddiaa0 Maddiaa0 merged commit 2c43878 into master Aug 3, 2023
@Maddiaa0 Maddiaa0 deleted the md/noir-back branch August 3, 2023 10:58
codygunton pushed a commit that referenced this pull request Jan 23, 2024
* Updated fork block (#1396)

* Updated fork block

* Set redeploy flag

* Redploy dev net (#1398)

* Force redeploy (#1399)

Co-authored-by: joss-aztec <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants