Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

generate constants.sol from c++ constants #1374

Merged
merged 2 commits into from
Aug 3, 2023
Merged

generate constants.sol from c++ constants #1374

merged 2 commits into from
Aug 3, 2023

Conversation

rahul-kothari
Copy link
Contributor

@rahul-kothari rahul-kothari commented Aug 2, 2023 •
edited
Loading

Description

Closes #1261

  • Rename to KERNELS_PER_BASE_ROLLUP for clarity
  • Update remake-constants script to generate solidity constants!
  • Rename NUMBER_OF_L1_L2_MESSAGES_PER_ROLLUP to `NUMBER_OF_L1_TO_L2_MESSAGES_PER_ROLLUP

Checklist:

  • I have reviewed my diff in github, line by line.
  • Every change is related to the PR description.
  • I have linked this pull request to the issue(s) that it resolves.
  • There are no unexpected formatting changes, superfluous debug logs, or commented-out code.
  • The branch has been merged or rebased against the head of its merge target.
  • I'm happy for the PR to be merged at the reviewer's next convenience.

@rahul-kothari rahul-kothari force-pushed the rk/contract_constants_gen branch 2 times, most recently from a20a358 to 6b35122 Compare August 2, 2023 14:30
@rahul-kothari rahul-kothari force-pushed the rk/contract_constants_gen branch from bd16f79 to 00a5c83 Compare August 2, 2023 14:37
@rahul-kothari rahul-kothari force-pushed the rk/contract_constants_gen branch from 00a5c83 to 6044ca5 Compare August 2, 2023 15:34
@rahul-kothari rahul-kothari marked this pull request as ready for review August 2, 2023 16:50
Maddiaa0
Maddiaa0 approved these changes Aug 2, 2023
View reviewed changes
Copy link
Member

@Maddiaa0 Maddiaa0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nicely done

LHerskind
LHerskind approved these changes Aug 3, 2023
View reviewed changes
Copy link
Contributor

@LHerskind LHerskind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thats Nice GIF

@LHerskind LHerskind merged commit ae36667 into master Aug 3, 2023
@LHerskind LHerskind deleted the rk/contract_constants_gen branch August 3, 2023 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Maddiaa0 Maddiaa0 Maddiaa0 approved these changes

@LHerskind LHerskind LHerskind approved these changes

Assignees
No one assigned
Labels
None yet
Projects
A3
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

chore: Generate smart contract constants with in line with other generators
3 participants
@rahul-kothari @LHerskind @Maddiaa0