refactor: not breaking note processing on missing hash and nullifier func

yarn-project/acir-simulator/src/client/simulator.ts

@@ -173,7 +173,7 @@ export class AcirSimulator {
       };
     } catch (e) {
       throw new Error(
-        `Please define an unconstrained function "${computeNoteHashAndNullifierSignature}" in the noir contract. Bubbled error message: ${e}`,
+        `Mandatory implementation of "${computeNoteHashAndNullifierSignature}" missing in noir contract ${contractAddress.toString()}.`,
       );
     }
   }

yarn-project/aztec-rpc/src/note_processor/note_processor.ts

@@ -114,20 +114,24 @@ export class NoteProcessor {
                 indexOfTxInABlock * MAX_NEW_NULLIFIERS_PER_TX,
                 (indexOfTxInABlock + 1) * MAX_NEW_NULLIFIERS_PER_TX,
               );
-              userPertainingTxIndices.add(indexOfTxInABlock);
-              const { index, nonce, nullifier } = await this.findNoteIndexAndNullifier(
-                dataStartIndexForTx,
-                newCommitments,
-                newNullifiers[0],
-                noteSpendingInfo,
-              );
-              noteSpendingInfoDaos.push({
-                ...noteSpendingInfo,
-                index,
-                nonce,
-                nullifier,
-                publicKey: this.publicKey,
-              });
+              try {
+                const { index, nonce, nullifier } = await this.findNoteIndexAndNullifier(
+                  dataStartIndexForTx,
+                  newCommitments,
+                  newNullifiers[0],
+                  noteSpendingInfo,
+                );
+                noteSpendingInfoDaos.push({
+                  ...noteSpendingInfo,
+                  index,
+                  nonce,
+                  nullifier,
+                  publicKey: this.publicKey,
+                });
+                userPertainingTxIndices.add(indexOfTxInABlock);
+              } catch (e) {
+                this.log.warn(`Could not process note because of "${e}". Skipping note...`);
+              }
             }
           }
         }

yarn-project/aztec.js/package.local.json

@@ -2,4 +2,4 @@
   "scripts": {
     "build": "yarn clean && tsc -b && webpack"
   }
-}
+}

yarn-project/aztec.js/tsconfig.dest.json

@@ -11,7 +11,5 @@
       "path": "../types/tsconfig.dest.json"
     }
   ],
-  "exclude": [
-    "src/**/*.test.ts"
-  ]
-}
+  "exclude": ["src/**/*.test.ts"]
+}

yarn-project/circuits.js/tsconfig.dest.json

@@ -5,8 +5,5 @@
       "path": "../foundation/tsconfig.dest.json"
     }
   ],
-  "exclude": [
-    "src/**/*.test.ts",
-    "src/**/*.in.ts"
-  ]
-}
+  "exclude": ["src/**/*.test.ts", "src/**/*.in.ts"]
+}

yarn-project/foundation/tsconfig.dest.json

@@ -1,7 +1,5 @@
 {
   "extends": ".",
   "references": [],
-  "exclude": [
-    "src/**/*.test.ts"
-  ]
-}
+  "exclude": ["src/**/*.test.ts"]
+}

yarn-project/types/tsconfig.dest.json

@@ -8,7 +8,5 @@
       "path": "../foundation/tsconfig.dest.json"
     }
   ],
-  "exclude": [
-    "src/**/*.test.ts"
-  ]
-}
+  "exclude": ["src/**/*.test.ts"]
+}