Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: renamed take to limit #1361

Merged
merged 2 commits into from
Aug 2, 2023
Merged

refactor: renamed take to limit #1361

merged 2 commits into from
Aug 2, 2023

Conversation

benesjan
Copy link
Contributor

@benesjan benesjan commented Aug 2, 2023

Description

Fixes #1231

Checklist:

  • I have reviewed my diff in github, line by line.
  • Every change is related to the PR description.
  • I have linked this pull request to the issue(s) that it resolves.
  • There are no unexpected formatting changes, superfluous debug logs, or commented-out code.
  • The branch has been merged or rebased against the head of its merge target.
  • I'm happy for the PR to be merged at the reviewer's next convenience.

@benesjan benesjan enabled auto-merge (squash) August 2, 2023 09:25
@benesjan benesjan merged commit ba9d00b into master Aug 2, 2023
@benesjan benesjan deleted the janb/renaming-take-param-to-limit branch August 2, 2023 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhilWindle PhilWindle PhilWindle approved these changes

@spypsy spypsy spypsy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
A3
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename 'take' to 'limit'
3 participants
@benesjan @spypsy @PhilWindle