fix: reinstate barretenberg-benchmark-aggregator #1330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ludamad
force-pushed
the
ad/fix-barretenberg-benchmark-aggregator
branch
2 times, most recently
from
ee7d6a9 to
416b193
Compare
|
Ready for review (will need to change to target master) |
ludamad
force-pushed
the
ad/fix-barretenberg-benchmark-aggregator
branch
from
416b193 to
aa2420f
Compare
spalladino
approved these changes
Aug 1, 2023
| @@ -1053,8 +1027,7 @@ workflows: | |||
| filters: | |||
| branches: | |||
| only: | |||
| - DISABLED_FIXME # master # TODO(AD): See #1174 | |||
| <<: *defaults | |||
| - master | |||
There was a problem hiding this comment.
WDYT about enabling it on ad/fix-barretenberg-benchmark-aggregator as well, so we can test this works before merging, so we accidentally don't break master?
There was a problem hiding this comment.
Well, auto-merge decided for us :-P
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1174.