Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixing fuzzing build after composer splitting #1317

Merged
merged 10 commits into from
Aug 1, 2023
Merged

Conversation

Rumata888
Copy link
Contributor

@Rumata888 Rumata888 commented Jul 31, 2023

Description

After the splitting PR the fuzzing build was broken. This PR fixes that issue. It also adds the fuzzing build to CI so that such breaking changes get detected in the future

Checklist:

  • I have reviewed my diff in github, line by line.
  • Every change is related to the PR description.
  • I have linked this pull request to the issue(s) that it resolves.
  • There are no unexpected formatting changes, superfluous debug logs, or commented-out code.
  • The branch has been merged or rebased against the head of its merge target.
  • I'm happy for the PR to be merged at the reviewer's next convenience.

@Rumata888 Rumata888 changed the title Fixing fuzzing build after composer splitting DONT MERGE Fixing fuzzing build after composer splitting Jul 31, 2023
@Rumata888 Rumata888 force-pushed the is/fixing_fuzzing branch from 6ee9db8 to 8829f7c Compare July 31, 2023 16:48
@Rumata888 Rumata888 force-pushed the is/fixing_fuzzing branch from 8829f7c to 1f5831c Compare July 31, 2023 17:16
@Rumata888 Rumata888 changed the title DONT MERGE Fixing fuzzing build after composer splitting fix: Fixing fuzzing build after composer splitting Jul 31, 2023
a.next()
}
->std::convertible_to<uint32_t>;
};
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't love how it autoformats concepts with another {} inside the {}, but that's an aside

Copy link
Collaborator

@ludamad ludamad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this was mostly compile fixes right?

CI LGTM and C++ at a glance LGTM

@Rumata888 Rumata888 merged commit 6b2e759 into master Aug 1, 2023
@Rumata888 Rumata888 deleted the is/fixing_fuzzing branch August 1, 2023 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants