bump public constants #1316
Merged
bump public constants #1316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rahul-kothari
force-pushed
the
rk/public_constants
branch
2 times, most recently
from
1967597 to
a8fddaa
Compare
LHerskind
reviewed
Aug 1, 2023
| @@ -34,7 +34,7 @@ describe('kernel/public_kernel', () => { | |||
| await expect(simulatePublicKernelCircuit(input)).rejects.toThrow( | |||
| new CircuitError( | |||
| 7009, | |||
| `public_kernel_circuit: too many public data reads in one tx - array_push: capacity exceeded. Limit: 4 | |||
| `public_kernel_circuit: too many public data reads in one tx - array_push: capacity exceeded. Limit: 8 | |||
There was a problem hiding this comment.
You should be able to read from constants for the error messages instead of having hardcoded, if bumped you still need to find this value to update anyways.
6 tasks
ludamad
approved these changes
Aug 1, 2023
|
Didn't see Lasse reviewed, of course get his buy-in |
rahul-kothari
force-pushed
the
rk/public_constants
branch
from
838d661 to
48c327e
Compare
codygunton
pushed a commit
that referenced
this pull request
Jan 23, 2024
* schnorr: - use optional instead of possibly invalid signatures - c_bind functions return bool - need to change bb.js to handle this case - implement proof of possession in a separate module - unify call to generate schnorr challenge - domain separation for H_reg and H_non - check number of outputs during "combine_sigs" * compare number of round 1 nonces with num signers * fix verification of FS challenge in both pop & sig * added comments and parametrize test over hash * - slightly clean up headers - use two hash functions for proper domain separation - more generic serialization functions - hash message when generating a to prevent colisions - reinstate hmac for PoP - additional verification of round1 messages - update documentation * fix `valid_round1_nonces` usage * revert changes to tests used for testing * - hash the group generator for Hnon and Hreg - update documentation - use prefix and suffix instead of hashing m for 'a' - change order of Co-authored-by: Arijit Dutta <[email protected]> * Return zero buffer if failed to create combined key. * Add more error handlings. * Change return value type. * added comments to multisig ts wrapper * fix formatting * fix domain separation using string_view led to the domain separator not being included in hash * addresses comments by @arijitdutta67 Co-authored-by: Arijit Dutta <[email protected]> Co-authored-by: Leila Wang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Increase constants for public read/write!
Closes #1290
Checklist: