Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: New stdlib Transcript #1219

Merged
merged 11 commits into from
Aug 2, 2023
Prev Previous commit
Next Next commit
comment update
  • Loading branch information
ledwards2225 committed Aug 2, 2023
commit 8c3d4d464a16d980a4570a1dab66bbfcf0742b34
Original file line number Diff line number Diff line change
@@ -10,6 +10,7 @@
#include "../../primitives/biggroup/biggroup.hpp"
#include "../../primitives/field/field.hpp"

//TODO(luke): this namespace will be sensible once stdlib is moved out of the plonk namespace
namespace proof_system::plonk::stdlib::recursion::honk {
template <typename Builder> class Transcript {
public:
Original file line number Diff line number Diff line change
@@ -8,7 +8,6 @@

namespace proof_system::plonk::stdlib::recursion::honk {

// TODO(Cody): Testing only one circuit type.
using Builder = UltraCircuitBuilder;

using FF = barretenberg::fr;
@@ -76,6 +75,11 @@ void perform_mock_verifier_transcript_operations(auto transcript)
transcript.get_challenges("gamma", "delta");
}

/**
* @brief Test basic transcript functionality and check circuit
* @details Implicitly ensures stdlib interface is identical to native
* @todo(luke): Underlying circuit is nearly trivial until transcript implements hashing constraints
*/
TEST(stdlib_honk_transcript, basic_transcript_operations)
{
Builder builder;
@@ -102,6 +106,10 @@ TEST(stdlib_honk_transcript, basic_transcript_operations)
EXPECT_TRUE(builder.check_circuit());
}

/**
* @brief Check that native and stdlib verifier transcript functions produce equivalent outputs
*
*/
TEST(stdlib_honk_transcript, return_values)
{
Builder builder;