feat(blocks_tree): add blocks tree information to blocks #1189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maddiaa0
force-pushed
the
md/blocks-tree-smart-contract
branch
from
78b4640 to
d00fd2a
Compare
✅ Deploy Preview for preeminent-bienenstitch-606ad0 canceled.
|
Maddiaa0
force-pushed
the
md/blocks-tree-smart-contract
branch
from
d00fd2a to
98692dd
Compare
LHerskind
reviewed
Jul 27, 2023
| @@ -14,10 +14,10 @@ library Constants { | |||
|
|
|||
| // Constants used for decoding rollup blocks | |||
| // TODO(962): Make this constant consistent across the codebase. | |||
| uint256 internal constant COMMITMENTS_PER_KERNEL = 16; | |||
| uint256 private constant TREES_HEADER_SIZE = 0x140; | ||
|
|
||
| // Where the metadata ends and the block data begins. | ||
| uint256 private constant METADATA_OFFSET = 0x0300; |
There was a problem hiding this comment.
All the other things was named with some "sub-header", seems like it would make sense to use header here instead of metadata. Would also match better with some of the comments we have further down.
LHerskind
approved these changes
Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #1161
Built ontop of #1168
Tiny pr to add the blocks tree info to the solidity contract, aim is to prevent this being part of a huge pr later
Checklist: