Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: rename barretenberg_module to circuits_cmake_module in circuits #1122

Merged
merged 2 commits into from
Jul 19, 2023
Merged

chore: rename barretenberg_module to circuits_cmake_module in circuits #1122

merged 2 commits into from
Jul 19, 2023

Conversation

dbanks12
Copy link
Collaborator

@dbanks12 dbanks12 commented Jul 19, 2023 •
edited
Loading

Description

Closes #364

Checklist:

  • I have reviewed my diff in github, line by line.
  • Every change is related to the PR description.
  • I have linked this pull request to the issue(s) that it resolves.
  • There are no unexpected formatting changes, superfluous debug logs, or commented-out code.
  • The branch has been merged or rebased against the head of its merge target.
  • I'm happy for the PR to be merged at the reviewer's next convenience.

@dbanks12 dbanks12 requested review from ludamad, suyash67 and jeanmon July 19, 2023 20:23
@dbanks12 dbanks12 merged commit a0d93eb into master Jul 19, 2023
@dbanks12 dbanks12 deleted the db/364-rename-barretenberg-module branch July 19, 2023 21:12
jeanmon
jeanmon reviewed Jul 20, 2023
View reviewed changes
Copy link
Contributor

@jeanmon jeanmon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job @dbanks12 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeanmon jeanmon jeanmon left review comments

@ludamad ludamad ludamad approved these changes

@suyash67 suyash67 Awaiting requested review from suyash67

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename barretenberg_module
3 participants
@dbanks12 @ludamad @jeanmon