Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove abi refs from publisher #10766

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

MirandaWood
Copy link
Contributor

Removes unecessary import of abis to l1-publisher, now that we add errors to the RollupAbi (thanks to #10697). This means we can remove my ugly code to try and catch blob and leonidas errors from a header check.


Note: I found that the use of getContractError is still needed in tryGetErrorFromRevertedTx. Viem doesn't play nice when simulating blob txs and either doesn't allow blob sidecars (hence the checkBlobSlot override) or doesn't throw an error to catch.

I found a middle ground where prepareTransactionRequest would throw with the error we wanted in the case of a blob issue (e.g. incorrect blob proof), but this error still only has the selector thrown and not the custom name e.g.
Execution reverted with reason: custom error 0x5ca17bef: 0113d536ef349476f9a5112623449dd1cf574b8213bc6fe33c1edd63bf832890.
To get the name, I used viem's getContractError which works fine:
The contract function "propose" reverted. Error: Rollup__InvalidBlobProof(bytes32 blobHash) (0x0113d536ef349476f9a5112623449dd1cf574b8213bc6fe33c1edd63bf832890)


Another note: I also snuck in adding the issue number for #10754 in some comments (sorry)

Copy link
Contributor

Changes to circuit sizes

Generated at commit: 8be556a87274f144673593254bbfc2fce16057e1, compared to commit: 4e59b06cd1956d43bc44a219448603b4bcf58d27

🧾 Summary (100% most significant diffs)

Program ACIR opcodes (+/-) % Circuit size (+/-) %
rollup_base_public -166 ✅ -0.00% -366 ✅ -0.00%
rollup_base_private -177 ✅ -0.00% -375 ✅ -0.00%

Full diff report 👇
Program ACIR opcodes (+/-) % Circuit size (+/-) %
rollup_base_public 3,851,080 (-166) -0.00% 12,654,368 (-366) -0.00%
rollup_base_private 3,619,424 (-177) -0.00% 11,261,128 (-375) -0.00%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant