-
Notifications
You must be signed in to change notification settings - Fork 265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: make aztec.js bundleable by vite #10744
base: master
Are you sure you want to change the base?
Conversation
Hi! This is going to be addressed by #10704, which also starts a bigger refactor and code split that will make our libraries way more browser friendly. Hopefully I can get that one in today to unblock you! |
@Thunkar please close this PR, if it was addressed in yours |
I merged master and see that |
@olehmisar |
IDK. Vite just fails because it can’t destructure sep from path. Not destructuring fixes the issue for some reason. Idk why but it worked for me |
@olehmisar have you tried the polyfills package I used here? |
No, I am using https://github.com/ShieldSwap/vite-plugin-aztec |
I'll try your plugin with our vite box tomorrow and try to debug. The polyfill should support destructuring. |
I feel like too much of your time is being wasted on such a simple fix? |
Fixes #6073