Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: load balancers for the boot node, longer epochs #10632

Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
chore: load balancer for boot node
just-mitch committed Dec 11, 2024
commit 6599eced6cd726a9f031158a19078e845ac28299
11 changes: 9 additions & 2 deletions spartan/aztec-network/templates/boot-node.yaml
Original file line number Diff line number Diff line change
@@ -224,7 +224,6 @@ data:
export STAKING_ASSET_CONTRACT_ADDRESS={{ .Values.bootNode.contracts.stakingAssetAddress }}
export FEE_JUICE_PORTAL_CONTRACT_ADDRESS={{ .Values.bootNode.contracts.feeJuicePortalAddress }}
{{- end }}
{{if not .Values.network.public }}
---
# Headless service for StatefulSet DNS entries
apiVersion: v1
@@ -234,16 +233,24 @@ metadata:
labels:
{{- include "aztec-network.labels" . | nindent 4 }}
spec:
# If this is a public network, we want to expose the boot node as a LoadBalancer
{{- if .Values.network.public }}
type: LoadBalancer
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we had this in the past, right?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sort of. We had a load balancer, but I removed it for public networks because it didn't work as "external" when mixing tcp/udp.

So this incarnation always creates a service (public/private), but when it is a public network, we don't try to allow it to be used as something you can do p2p through.

{{- else }}
type: ClusterIP
clusterIP: None
{{- end }}
selector:
{{- include "aztec-network.selectorLabels" . | nindent 4 }}
app: boot-node
ports:
# External load balancers cannot handle mixed TCP/UDP ports, so we only expose the node port
{{- if not .Values.network.public }}
- port: {{ .Values.bootNode.service.p2pTcpPort }}
name: p2p-tpc
- port: {{ .Values.bootNode.service.p2pUdpPort }}
name: p2p-udp
protocol: UDP
{{- end }}
- port: {{ .Values.bootNode.service.nodePort }}
name: node
{{ end }}