refactor: add note to deliver note

[sklppy88]

In this PR, we are renaming pxe.addNote to pxe.deliverNote. The rationale was because in this function, we aren't actually 'adding a note' to state, as this can only be used when a note (hash) already exists. This is used to deliver the existing note (most likely to self), and (most likely) when said note was not emitted.

[sklppy88]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• refactor: add note to deliver note #10482 👈 (View in Graphite)
• refactor: remove get outgoing notes from pxe #10481
• refactor: consolidate contract functions in pxe #10480
• refactor: remove get registered account from pxe #10479
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

[iAmMichaelConnor]

I actually prefer addNote. "Deliver" suggests you are sending the note to someone else; but you're not; you're just adding the note to your pxe.

[sklppy88]

I actually prefer addNote. "Deliver" suggests you are sending the note to someone else; but you're not; you're just adding the note to your pxe.

I think during the discussion we preferred "deliver" over "add" because the note is not necessarily added, as the note hash must already exist for this to work. So in essence you may use this to "deliver" an already "added" / "created" note (that may not have been emitted) to yourself. Maybe we can think of a better name ?