Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: witness changes in file sponge.hpp #10345

Merged
merged 1 commit into from
Dec 2, 2024
Merged

fix: witness changes in file sponge.hpp #10345

merged 1 commit into from
Dec 2, 2024
+4 −4

Conversation

DanielKotov
Copy link
Contributor

Static analyzer found that initial values in cache and state arrays weren't properly constrained. Initially state fill in 0 + iv value, but these values weren't constrained as witnesses.

We replaced witness_t constructor with function create_constant_witness from class witness_t in file sponge.hpp.

All tests for poseidon2s passed after fix.

lucasxia01
lucasxia01 reviewed Dec 2, 2024
View reviewed changes
barretenberg/cpp/src/barretenberg/stdlib/hash/poseidon2/sponge/sponge.hpp
}
state[rate] = witness_t<Builder>(builder, domain_iv.get_value());
state[rate] = witness_t<Builder>::create_constant_witness(builder, domain_iv.get_value());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this .get_value seems a little suspicious. Should we just change the argument to be a bb::fr instead so its explicitly a value?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My analyzer didn't noticed this variable as dangerous...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After fix

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seem's like we have created constraint on domain_iv.get_value() as constant value, and after that there were created constraints for this variable in permutation

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yea, I'm not saying its dangerous in our current code but it looks a little weird to be passing in a field_t when we just always pass in a bb::fr?

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 2, 2024

Changes to public function bytecode sizes

Generated at commit: ecf9cbe1395bddcc35744a63d5b581a6782c74bb, compared to commit: cf05a7a346ea11853e940d5e9ac105ef0d629d35

🧾 Summary (100% most significant diffs)

Program Bytecode size in bytes (+/-) %
AvmTest::set_read_storage_single +554 ❌ +395.71%
DocsExample::initialize_public_immutable +680 ❌ +302.22%
AvmTest::read_storage_single +355 ❌ +268.94%
FeeJuice::set_portal +711 ❌ +234.65%
EasyPrivateVoting::end_vote +522 ❌ +228.95%
NFT::set_admin +522 ❌ +227.95%
Token::set_admin +522 ❌ +227.95%
Child::pub_inc_value +545 ❌ +227.08%
StaticChild::pub_inc_value +545 ❌ +227.08%
StaticChild::pub_illegal_inc_value +531 ❌ +188.97%
Child::pub_inc_value_internal +531 ❌ +185.66%
AvmInitializerTest::read_storage_immutable +341 ❌ +183.33%
NFT::public_get_symbol +331 ❌ +148.43%
TokenBridge::get_token +331 ❌ +148.43%
Token::get_admin +331 ❌ +148.43%
NFT::get_admin +327 ❌ +140.95%
NFT::public_get_name +327 ❌ +140.95%
Token::public_get_name +327 ❌ +140.95%
Token::public_get_symbol +327 ❌ +140.95%
Token::public_get_decimals +327 ❌ +132.39%
AvmTest::read_storage_list +372 ❌ +130.99%
TokenBridge::get_portal_address_public +327 ❌ +123.86%
TokenBridge::_assert_token_is_same +313 ❌ +118.56%
AvmTest::set_storage_single +140 ❌ +109.38%
Child::set_value_twice_with_nested_first +593 ❌ +100.68%
Child::set_value_twice_with_nested_last +593 ❌ +100.68%
AvmTest::variable_base_msm +225 ❌ +100.45%
AvmTest::set_storage_list +143 ❌ +98.62%
Token::_reduce_total_supply +494 ❌ +91.82%
TokenBlacklist::_reduce_total_supply +489 ❌ +90.89%
TokenBlacklist::total_supply +313 ❌ +90.72%
Token::total_supply +313 ❌ +90.72%
AvmTest::nested_call_to_add_with_gas +356 ❌ +65.44%
StaticParent::public_get_value_from_child +356 ❌ +64.14%
DocsExample::update_leader +129 ❌ +63.55%
Lending::get_assets +327 ❌ +63.13%
AvmTest::nested_static_call_to_add +356 ❌ +62.57%
AvmTest::nested_call_to_assert_same +356 ❌ +62.57%
AvmTest::nested_call_to_add +356 ❌ +62.57%
TestLog::emit_unencrypted_events +712 ❌ +61.97%
Child::pub_set_value +135 ❌ +58.95%
StaticChild::pub_set_value +135 ❌ +58.95%
Benchmarking::increment_balance +1,316 ❌ +55.27%
ImportTest::public_dispatch +496 ❌ +46.75%
Benchmarking::public_dispatch +1,758 ❌ +44.36%
TestLog::public_dispatch +994 ❌ +42.84%
StaticChild::public_dispatch +902 ❌ +42.71%
Crowdfunding::_publish_donation_receipts +406 ❌ +42.60%
Uniswap::_assert_token_is_same +291 ❌ +40.59%
DocsExample::public_dispatch +1,652 ❌ +39.43%
StatefulTest::public_constructor +1,031 ❌ +36.99%
TokenBridge::constructor +849 ❌ +36.02%
Auth::set_authorized +1,540 ❌ +33.89%
EasyPrivateVoting::constructor +795 ❌ +33.10%
Crowdfunding::public_dispatch +1,536 ❌ +32.86%
StatefulTest::public_dispatch +2,000 ❌ +32.62%
FPC::public_dispatch +2,303 ❌ +32.30%
Claim::constructor +790 ❌ +32.21%
TokenBridge::exit_to_l1_public +2,019 ❌ +31.91%
FPC::constructor +712 ❌ +30.72%
Claim::public_dispatch +982 ❌ +30.20%
AppSubscription::constructor +834 ❌ +29.43%
Crowdfunding::init +797 ❌ +29.34%
Auth::set_authorized_delay +1,358 ❌ +29.27%
PriceFeed::public_dispatch +899 ❌ +29.07%
AvmInitializerTest::constructor +559 ❌ +28.64%
TokenBlacklist::constructor +1,751 ❌ +28.12%
Uniswap::constructor +665 ❌ +28.12%
StaticParent::public_dispatch +1,618 ❌ +28.07%
Auth::constructor +651 ❌ +27.06%
TokenBlacklist::update_roles +1,599 ❌ +26.08%
AppSubscription::public_dispatch +1,033 ❌ +25.86%
Child::public_dispatch +1,220 ❌ +25.58%
Token::constructor +974 ❌ +23.61%
StatefulTest::increment_public_value_no_init_check +390 ❌ +22.91%
Auth::public_dispatch +1,992 ❌ +22.66%
AvmTest::add_storage_map +417 ❌ +21.94%
EasyPrivateVoting::add_to_tally_public +446 ❌ +21.72%
StatefulTest::increment_public_value +376 ❌ +21.47%
Lending::_borrow +1,576 ❌ +21.32%
AvmInitializerTest::public_dispatch +568 ❌ +20.96%
NFT::set_minter +367 ❌ +20.34%
Token::set_minter +362 ❌ +20.07%
NFT::finalize_transfer_to_private +1,080 ❌ +19.93%
NFT::_finalize_transfer_to_private_unsafe +1,066 ❌ +19.50%
Lending::_deposit +469 ❌ +18.49%
FeeJuice::public_dispatch +940 ❌ +17.78%
Token::public_dispatch +5,587 ❌ +17.74%
Token::finalize_mint_to_private +1,070 ❌ +17.52%
Token::_finalize_mint_to_private_unsafe +1,056 ❌ +17.16%
NFT::constructor +689 ❌ +17.01%
NFT::mint +474 ❌ +16.69%
StaticParent::public_nested_static_call +337 ❌ +16.47%
Spam::public_dispatch +532 ❌ +16.40%
AvmTest::keccak_hash +385 ❌ +16.06%
EasyPrivateVoting::public_dispatch +834 ❌ +16.04%
NFT::_store_payload_in_transient_storage_unsafe +190 ❌ +16.03%
Token::_store_payload_in_transient_storage_unsafe +190 ❌ +16.03%
FeeJuice::_increase_public_balance +337 ❌ +15.19%
Auth::get_authorized_delay +305 ❌ +14.87%
Child::set_value_with_two_nested_calls +138 ❌ +14.84%
AvmTest::bulk_testing +3,336 ❌ +14.74%
TokenBlacklist::mint_public +581 ❌ +14.54%
Test::emit_unencrypted +214 ❌ +14.42%
Spam::public_spam +345 ❌ +14.20%
TokenBlacklist::mint_private +529 ❌ +14.16%
AuthWitTest::public_dispatch +225 ❌ +13.56%
Token::finalize_transfer_to_private +877 ❌ +13.46%
TokenBlacklist::_increase_public_balance +331 ❌ +13.30%
Token::_increase_public_balance +331 ❌ +13.30%
NFT::owner_of +323 ❌ +13.30%
AvmTest::returndata_copy_oracle +234 ❌ +13.23%
Token::_finalize_transfer_to_private_unsafe +863 ❌ +13.15%
TokenBridge::claim_public +1,473 ❌ +13.08%
InclusionProofs::constructor +300 ❌ +13.04%
Token::complete_refund +678 ❌ +12.62%
Parent::public_dispatch +960 ❌ +12.58%
TokenBridge::public_dispatch +2,550 ❌ +12.44%
AvmTest::read_storage_map +209 ❌ +12.25%
NFT::public_dispatch +2,799 ❌ +11.82%
PriceFeed::get_price +207 ❌ +11.81%
Benchmarking::broadcast +205 ❌ +11.55%
TokenBlacklist::burn_public +595 ❌ +11.39%
TokenBlacklist::transfer_public +638 ❌ +11.39%
StatefulTest::get_public_value +195 ❌ +11.23%
AuthRegistry::consume +324 ❌ +11.22%
AuthRegistry::is_reject_all +195 ❌ +11.16%
Token::burn_public +460 ❌ +11.04%
Uniswap::public_dispatch +2,482 ❌ +10.80%
InclusionProofs::public_dispatch +406 ❌ +10.79%
AuthRegistry::is_consumable +205 ❌ +10.74%
NFT::is_minter +181 ❌ +10.05%
Token::is_minter +181 ❌ +10.05%
NFT::transfer_in_public +331 ❌ +9.95%
FeeJuice::balance_of_public +181 ❌ +9.81%
TokenBlacklist::shield +565 ❌ +9.76%
TokenBlacklist::public_dispatch +2,194 ❌ +9.47%
TokenBlacklist::balance_of_public +167 ❌ +8.79%
Token::balance_of_public +167 ❌ +8.79%
AvmTest::emit_unencrypted_log +236 ❌ +8.50%
AvmTest::set_storage_map +143 ❌ +7.95%
Lending::_repay +447 ❌ +7.88%
AuthRegistry::set_authorized +143 ❌ +7.71%
Router::public_dispatch +180 ❌ +7.62%
AuthRegistry::set_reject_all +129 ❌ +7.58%
FeeJuice::check_balance +163 ❌ +7.34%
Lending::init +213 ❌ +7.21%
Lending::_withdraw +606 ❌ +7.02%
AuthRegistry::_set_authorized +129 ❌ +6.79%
PriceFeed::set_price +113 ❌ +6.26%
AuthRegistry::public_dispatch +474 ❌ +5.97%
Test::public_dispatch +1,091 ❌ +5.70%
NFT::_finish_transfer_to_public +101 ❌ +5.66%
Auth::get_scheduled_authorized +100 ❌ +5.52%
Lending::public_dispatch +1,416 ❌ +5.23%
Auth::get_authorized +100 ❌ +5.23%
Uniswap::swap_public +775 ❌ +5.11%
Uniswap::_approve_bridge_and_exit_input_asset_to_L1 +287 ❌ +4.67%
CardGame::public_dispatch +723 ❌ +4.53%
Lending::get_position +178 ❌ +3.56%
Test::consume_message_from_arbitrary_sender_public +264 ❌ +3.34%
CardGame::start_game +158 ❌ +2.25%
TokenBlacklist::get_roles +57 ❌ +2.13%
CardGame::on_cards_claimed +140 ❌ +1.92%
AvmTest::sha256_hash +49 ❌ +1.25%
CardGame::on_card_played +48 ❌ +0.81%
CardGame::on_game_joined +29 ❌ +0.58%
AvmTest::public_dispatch -100 ✅ -0.16%
AvmTest::poseidon2_hash -3 ✅ -0.17%
Parent::public_nested_static_call -12 ✅ -0.36%
AvmTest::get_args_hash -8 ✅ -0.44%
Lending::update_accumulator -38 ✅ -0.66%
AvmTest::debug_logging -16 ✅ -1.24%
Lending::get_asset -33 ✅ -1.50%
AvmTest::u128_addition_overflow -26 ✅ -1.94%
AvmTest::elliptic_curve_add_and_double -16 ✅ -2.24%
Lending::deposit_public -59 ✅ -2.32%
Parent::pub_entry_point_twice -23 ✅ -2.36%
AvmTest::create_different_nullifier_in_nested_call -12 ✅ -2.43%
Lending::repay_public -59 ✅ -2.43%
AvmTest::create_same_nullifier_in_nested_call -12 ✅ -2.48%
ImportTest::pub_call_public_fn -12 ✅ -2.51%
AvmTest::nested_static_call_to_set_storage -12 ✅ -2.51%
AvmTest::elliptic_curve_add -16 ✅ -2.76%
AvmTest::keccak_f1600 -16 ✅ -3.21%
Lending::withdraw_public -63 ✅ -3.33%
Lending::borrow_public -63 ✅ -3.33%
Parent::public_static_call -40 ✅ -3.51%
StaticParent::public_static_call -40 ✅ -3.51%
AvmTest::to_radix_le -16 ✅ -3.80%
AvmTest::revert_oracle -16 ✅ -3.85%
FPC::prepare_fee -77 ✅ -3.88%
FPC::pay_refund -91 ✅ -4.46%
AvmTest::pedersen_hash -146 ✅ -4.72%
AvmTest::pedersen_hash_with_index -146 ✅ -4.72%
Router::_check_timestamp -58 ✅ -5.84%
AvmTest::pedersen_commit -74 ✅ -5.86%
Router::_check_block_number -58 ✅ -5.94%
Test::create_l2_to_l1_message_public -146 ✅ -6.63%
Parent::pub_entry_point -40 ✅ -6.92%
StaticParent::public_call -40 ✅ -6.92%
AvmTest::get_function_selector -16 ✅ -8.33%
AuthWitTest::consume_public -54 ✅ -8.68%
AvmTest::u128_from_integer_overflow -72 ✅ -8.81%
Child::pub_get_value -16 ✅ -9.52%
AvmTest::assert_calldata_copy -54 ✅ -10.17%
Test::is_time_equal -16 ✅ -10.19%
AvmTest::set_opcode_big_field -16 ✅ -10.39%
AvmTest::set_opcode_really_big_field -16 ✅ -10.39%
AvmTest::modulo2 -16 ✅ -11.11%
AvmTest::note_hash_exists -16 ✅ -11.35%
AvmTest::l1_to_l2_msg_exists -16 ✅ -11.35%
AvmTest::nullifier_exists -16 ✅ -11.43%
AvmTest::set_opcode_small_field -16 ✅ -11.59%
AvmTest::add_args_return -16 ✅ -11.59%
AvmTest::add_u128 -30 ✅ -11.86%
DocsExample::spend_public_authwit -16 ✅ -12.12%
AvmTest::set_opcode_u64 -16 ✅ -12.31%
AvmTest::send_l2_to_l1_msg -16 ✅ -12.40%
Test::create_l2_to_l1_message_arbitrary_recipient_public -16 ✅ -12.40%
AvmTest::test_get_contract_instance -58 ✅ -12.66%
AvmTest::set_opcode_u32 -16 ✅ -12.70%
AvmTest::nullifier_collision -16 ✅ -12.80%
AvmTest::test_get_contract_instance_matches -58 ✅ -12.80%
AvmTest::get_version -16 ✅ -13.11%
AvmTest::get_timestamp -16 ✅ -13.11%
AvmTest::get_l2_gas_left -16 ✅ -13.11%
AvmTest::get_address -16 ✅ -13.11%
AvmTest::get_chain_id -16 ✅ -13.11%
AvmTest::get_da_gas_left -16 ✅ -13.11%
AvmTest::set_opcode_u8 -16 ✅ -13.11%
AvmTest::get_fee_per_l2_gas -16 ✅ -13.11%
AvmTest::get_block_number -16 ✅ -13.11%
AvmTest::get_sender -16 ✅ -13.11%
AvmTest::get_fee_per_da_gas -16 ✅ -13.11%
AvmTest::get_transaction_fee -16 ✅ -13.11%
AvmTest::check_selector -30 ✅ -13.22%
AvmTest::new_note_hash -16 ✅ -13.22%
AvmTest::new_nullifier -16 ✅ -13.22%
Test::emit_nullifier_public -16 ✅ -13.22%
AvmTest::assertion_failure -30 ✅ -13.95%
StaticChild::pub_get_value -30 ✅ -14.02%
InclusionProofs::test_nullifier_inclusion_from_public -30 ✅ -14.93%
AvmTest::return_oracle -68 ✅ -16.27%
InclusionProofs::push_nullifier_public -30 ✅ -17.14%
AvmTest::assert_same -30 ✅ -17.65%
AvmTest::emit_nullifier_and_check -30 ✅ -17.65%
AvmTest::assert_nullifier_exists -30 ✅ -18.07%
AvmTest::assert_timestamp -30 ✅ -18.18%
Test::dummy_public_call -30 ✅ -19.11%
Test::assert_public_global_vars -100 ✅ -25.00%
Full diff report 👇
Program Bytecode size in bytes (+/-) %
AvmTest::set_read_storage_single 694 (+554) +395.71%
DocsExample::initialize_public_immutable 905 (+680) +302.22%
AvmTest::read_storage_single 487 (+355) +268.94%
FeeJuice::set_portal 1,014 (+711) +234.65%
EasyPrivateVoting::end_vote 750 (+522) +228.95%
NFT::set_admin 751 (+522) +227.95%
Token::set_admin 751 (+522) +227.95%
Child::pub_inc_value 785 (+545) +227.08%
StaticChild::pub_inc_value 785 (+545) +227.08%
StaticChild::pub_illegal_inc_value 812 (+531) +188.97%
Child::pub_inc_value_internal 817 (+531) +185.66%
AvmInitializerTest::read_storage_immutable 527 (+341) +183.33%
NFT::public_get_symbol 554 (+331) +148.43%
TokenBridge::get_token 554 (+331) +148.43%
Token::get_admin 554 (+331) +148.43%
NFT::get_admin 559 (+327) +140.95%
NFT::public_get_name 559 (+327) +140.95%
Token::public_get_name 559 (+327) +140.95%
Token::public_get_symbol 559 (+327) +140.95%
Token::public_get_decimals 574 (+327) +132.39%
AvmTest::read_storage_list 656 (+372) +130.99%
TokenBridge::get_portal_address_public 591 (+327) +123.86%
TokenBridge::_assert_token_is_same 577 (+313) +118.56%
AvmTest::set_storage_single 268 (+140) +109.38%
Child::set_value_twice_with_nested_first 1,182 (+593) +100.68%
Child::set_value_twice_with_nested_last 1,182 (+593) +100.68%
AvmTest::variable_base_msm 449 (+225) +100.45%
AvmTest::set_storage_list 288 (+143) +98.62%
Token::_reduce_total_supply 1,032 (+494) +91.82%
TokenBlacklist::_reduce_total_supply 1,027 (+489) +90.89%
TokenBlacklist::total_supply 658 (+313) +90.72%
Token::total_supply 658 (+313) +90.72%
AvmTest::nested_call_to_add_with_gas 900 (+356) +65.44%
StaticParent::public_get_value_from_child 911 (+356) +64.14%
DocsExample::update_leader 332 (+129) +63.55%
Lending::get_assets 845 (+327) +63.13%
AvmTest::nested_static_call_to_add 925 (+356) +62.57%
AvmTest::nested_call_to_assert_same 925 (+356) +62.57%
AvmTest::nested_call_to_add 925 (+356) +62.57%
TestLog::emit_unencrypted_events 1,861 (+712) +61.97%
Child::pub_set_value 364 (+135) +58.95%
StaticChild::pub_set_value 364 (+135) +58.95%
Benchmarking::increment_balance 3,697 (+1,316) +55.27%
ImportTest::public_dispatch 1,557 (+496) +46.75%
Benchmarking::public_dispatch 5,721 (+1,758) +44.36%
TestLog::public_dispatch 3,314 (+994) +42.84%
StaticChild::public_dispatch 3,014 (+902) +42.71%
Crowdfunding::_publish_donation_receipts 1,359 (+406) +42.60%
Uniswap::_assert_token_is_same 1,008 (+291) +40.59%
DocsExample::public_dispatch 5,842 (+1,652) +39.43%
StatefulTest::public_constructor 3,818 (+1,031) +36.99%
TokenBridge::constructor 3,206 (+849) +36.02%
Auth::set_authorized 6,084 (+1,540) +33.89%
EasyPrivateVoting::constructor 3,197 (+795) +33.10%
Crowdfunding::public_dispatch 6,210 (+1,536) +32.86%
StatefulTest::public_dispatch 8,132 (+2,000) +32.62%
FPC::public_dispatch 9,434 (+2,303) +32.30%
Claim::constructor 3,243 (+790) +32.21%
TokenBridge::exit_to_l1_public 8,346 (+2,019) +31.91%
FPC::constructor 3,030 (+712) +30.72%
Claim::public_dispatch 4,234 (+982) +30.20%
AppSubscription::constructor 3,668 (+834) +29.43%
Crowdfunding::init 3,513 (+797) +29.34%
Auth::set_authorized_delay 5,998 (+1,358) +29.27%
PriceFeed::public_dispatch 3,992 (+899) +29.07%
AvmInitializerTest::constructor 2,511 (+559) +28.64%
TokenBlacklist::constructor 7,978 (+1,751) +28.12%
Uniswap::constructor 3,030 (+665) +28.12%
StaticParent::public_dispatch 7,382 (+1,618) +28.07%
Auth::constructor 3,057 (+651) +27.06%
TokenBlacklist::update_roles 7,731 (+1,599) +26.08%
AppSubscription::public_dispatch 5,028 (+1,033) +25.86%
Child::public_dispatch 5,990 (+1,220) +25.58%
Token::constructor 5,099 (+974) +23.61%
StatefulTest::increment_public_value_no_init_check 2,092 (+390) +22.91%
Auth::public_dispatch 10,782 (+1,992) +22.66%
AvmTest::add_storage_map 2,318 (+417) +21.94%
EasyPrivateVoting::add_to_tally_public 2,499 (+446) +21.72%
StatefulTest::increment_public_value 2,127 (+376) +21.47%
Lending::_borrow 8,967 (+1,576) +21.32%
AvmInitializerTest::public_dispatch 3,278 (+568) +20.96%
NFT::set_minter 2,171 (+367) +20.34%
Token::set_minter 2,166 (+362) +20.07%
NFT::finalize_transfer_to_private 6,500 (+1,080) +19.93%
NFT::_finalize_transfer_to_private_unsafe 6,533 (+1,066) +19.50%
Lending::_deposit 3,005 (+469) +18.49%
FeeJuice::public_dispatch 6,227 (+940) +17.78%
Token::public_dispatch 37,081 (+5,587) +17.74%
Token::finalize_mint_to_private 7,178 (+1,070) +17.52%
Token::_finalize_mint_to_private_unsafe 7,211 (+1,056) +17.16%
NFT::constructor 4,739 (+689) +17.01%
NFT::mint 3,314 (+474) +16.69%
StaticParent::public_nested_static_call 2,383 (+337) +16.47%
Spam::public_dispatch 3,776 (+532) +16.40%
AvmTest::keccak_hash 2,783 (+385) +16.06%
EasyPrivateVoting::public_dispatch 6,033 (+834) +16.04%
NFT::_store_payload_in_transient_storage_unsafe 1,375 (+190) +16.03%
Token::_store_payload_in_transient_storage_unsafe 1,375 (+190) +16.03%
FeeJuice::_increase_public_balance 2,556 (+337) +15.19%
Auth::get_authorized_delay 2,356 (+305) +14.87%
Child::set_value_with_two_nested_calls 1,068 (+138) +14.84%
AvmTest::bulk_testing 25,969 (+3,336) +14.74%
TokenBlacklist::mint_public 4,577 (+581) +14.54%
Test::emit_unencrypted 1,698 (+214) +14.42%
Spam::public_spam 2,774 (+345) +14.20%
TokenBlacklist::mint_private 4,266 (+529) +14.16%
AuthWitTest::public_dispatch 1,884 (+225) +13.56%
Token::finalize_transfer_to_private 7,392 (+877) +13.46%
TokenBlacklist::_increase_public_balance 2,819 (+331) +13.30%
Token::_increase_public_balance 2,819 (+331) +13.30%
NFT::owner_of 2,752 (+323) +13.30%
AvmTest::returndata_copy_oracle 2,003 (+234) +13.23%
Token::_finalize_transfer_to_private_unsafe 7,425 (+863) +13.15%
TokenBridge::claim_public 12,734 (+1,473) +13.08%
InclusionProofs::constructor 2,601 (+300) +13.04%
Token::complete_refund 6,051 (+678) +12.62%
Parent::public_dispatch 8,589 (+960) +12.58%
TokenBridge::public_dispatch 23,042 (+2,550) +12.44%
AvmTest::read_storage_map 1,915 (+209) +12.25%
NFT::public_dispatch 26,483 (+2,799) +11.82%
PriceFeed::get_price 1,960 (+207) +11.81%
Benchmarking::broadcast 1,980 (+205) +11.55%
TokenBlacklist::burn_public 5,818 (+595) +11.39%
TokenBlacklist::transfer_public 6,241 (+638) +11.39%
StatefulTest::get_public_value 1,932 (+195) +11.23%
AuthRegistry::consume 3,212 (+324) +11.22%
AuthRegistry::is_reject_all 1,942 (+195) +11.16%
Token::burn_public 4,627 (+460) +11.04%
Uniswap::public_dispatch 25,453 (+2,482) +10.80%
InclusionProofs::public_dispatch 4,168 (+406) +10.79%
AuthRegistry::is_consumable 2,113 (+205) +10.74%
NFT::is_minter 1,982 (+181) +10.05%
Token::is_minter 1,982 (+181) +10.05%
NFT::transfer_in_public 3,658 (+331) +9.95%
FeeJuice::balance_of_public 2,026 (+181) +9.81%
TokenBlacklist::shield 6,356 (+565) +9.76%
TokenBlacklist::public_dispatch 25,372 (+2,194) +9.47%
TokenBlacklist::balance_of_public 2,066 (+167) +8.79%
Token::balance_of_public 2,066 (+167) +8.79%
AvmTest::emit_unencrypted_log 3,013 (+236) +8.50%
AvmTest::set_storage_map 1,942 (+143) +7.95%
Lending::_repay 6,117 (+447) +7.88%
AuthRegistry::set_authorized 1,997 (+143) +7.71%
Router::public_dispatch 2,541 (+180) +7.62%
AuthRegistry::set_reject_all 1,831 (+129) +7.58%
FeeJuice::check_balance 2,385 (+163) +7.34%
Lending::init 3,166 (+213) +7.21%
Lending::_withdraw 9,239 (+606) +7.02%
AuthRegistry::_set_authorized 2,030 (+129) +6.79%
PriceFeed::set_price 1,918 (+113) +6.26%
AuthRegistry::public_dispatch 8,412 (+474) +5.97%
Test::public_dispatch 20,216 (+1,091) +5.70%
NFT::_finish_transfer_to_public 1,887 (+101) +5.66%
Auth::get_scheduled_authorized 1,913 (+100) +5.52%
Lending::public_dispatch 28,483 (+1,416) +5.23%
Auth::get_authorized 2,013 (+100) +5.23%
Uniswap::swap_public 15,937 (+775) +5.11%
Uniswap::_approve_bridge_and_exit_input_asset_to_L1 6,429 (+287) +4.67%
CardGame::public_dispatch 16,676 (+723) +4.53%
Lending::get_position 5,178 (+178) +3.56%
Test::consume_message_from_arbitrary_sender_public 8,177 (+264) +3.34%
CardGame::start_game 7,180 (+158) +2.25%
TokenBlacklist::get_roles 2,739 (+57) +2.13%
CardGame::on_cards_claimed 7,438 (+140) +1.92%
AvmTest::sha256_hash 3,964 (+49) +1.25%
CardGame::on_card_played 5,997 (+48) +0.81%
CardGame::on_game_joined 5,056 (+29) +0.58%
AvmTest::public_dispatch 60,562 (-100) -0.16%
AvmTest::poseidon2_hash 1,726 (-3) -0.17%
Parent::public_nested_static_call 3,348 (-12) -0.36%
AvmTest::get_args_hash 1,796 (-8) -0.44%
Lending::update_accumulator 5,704 (-38) -0.66%
AvmTest::debug_logging 1,276 (-16) -1.24%
Lending::get_asset 2,167 (-33) -1.50%
AvmTest::u128_addition_overflow 1,311 (-26) -1.94%
AvmTest::elliptic_curve_add_and_double 697 (-16) -2.24%
Lending::deposit_public 2,483 (-59) -2.32%
Parent::pub_entry_point_twice 952 (-23) -2.36%
AvmTest::create_different_nullifier_in_nested_call 482 (-12) -2.43%
Lending::repay_public 2,366 (-59) -2.43%
AvmTest::create_same_nullifier_in_nested_call 472 (-12) -2.48%
ImportTest::pub_call_public_fn 467 (-12) -2.51%
AvmTest::nested_static_call_to_set_storage 466 (-12) -2.51%
AvmTest::elliptic_curve_add 564 (-16) -2.76%
AvmTest::keccak_f1600 482 (-16) -3.21%
Lending::withdraw_public 1,831 (-63) -3.33%
Lending::borrow_public 1,831 (-63) -3.33%
Parent::public_static_call 1,098 (-40) -3.51%
StaticParent::public_static_call 1,098 (-40) -3.51%
AvmTest::to_radix_le 405 (-16) -3.80%
AvmTest::revert_oracle 400 (-16) -3.85%
FPC::prepare_fee 1,909 (-77) -3.88%
FPC::pay_refund 1,950 (-91) -4.46%
AvmTest::pedersen_hash 2,949 (-146) -4.72%
AvmTest::pedersen_hash_with_index 2,949 (-146) -4.72%
Router::_check_timestamp 935 (-58) -5.84%
AvmTest::pedersen_commit 1,189 (-74) -5.86%
Router::_check_block_number 918 (-58) -5.94%
Test::create_l2_to_l1_message_public 2,056 (-146) -6.63%
Parent::pub_entry_point 538 (-40) -6.92%
StaticParent::public_call 538 (-40) -6.92%
AvmTest::get_function_selector 176 (-16) -8.33%
AuthWitTest::consume_public 568 (-54) -8.68%
AvmTest::u128_from_integer_overflow 745 (-72) -8.81%
Child::pub_get_value 152 (-16) -9.52%
AvmTest::assert_calldata_copy 477 (-54) -10.17%
Test::is_time_equal 141 (-16) -10.19%
AvmTest::set_opcode_big_field 138 (-16) -10.39%
AvmTest::set_opcode_really_big_field 138 (-16) -10.39%
AvmTest::modulo2 128 (-16) -11.11%
AvmTest::note_hash_exists 125 (-16) -11.35%
AvmTest::l1_to_l2_msg_exists 125 (-16) -11.35%
AvmTest::nullifier_exists 124 (-16) -11.43%
AvmTest::set_opcode_small_field 122 (-16) -11.59%
AvmTest::add_args_return 122 (-16) -11.59%
AvmTest::add_u128 223 (-30) -11.86%
DocsExample::spend_public_authwit 116 (-16) -12.12%
AvmTest::set_opcode_u64 114 (-16) -12.31%
AvmTest::send_l2_to_l1_msg 113 (-16) -12.40%
Test::create_l2_to_l1_message_arbitrary_recipient_public 113 (-16) -12.40%
AvmTest::test_get_contract_instance 400 (-58) -12.66%
AvmTest::set_opcode_u32 110 (-16) -12.70%
AvmTest::nullifier_collision 109 (-16) -12.80%
AvmTest::test_get_contract_instance_matches 395 (-58) -12.80%
AvmTest::get_version 106 (-16) -13.11%
AvmTest::get_timestamp 106 (-16) -13.11%
AvmTest::get_l2_gas_left 106 (-16) -13.11%
AvmTest::get_address 106 (-16) -13.11%
AvmTest::get_chain_id 106 (-16) -13.11%
AvmTest::get_da_gas_left 106 (-16) -13.11%
AvmTest::set_opcode_u8 106 (-16) -13.11%
AvmTest::get_fee_per_l2_gas 106 (-16) -13.11%
AvmTest::get_block_number 106 (-16) -13.11%
AvmTest::get_sender 106 (-16) -13.11%
AvmTest::get_fee_per_da_gas 106 (-16) -13.11%
AvmTest::get_transaction_fee 106 (-16) -13.11%
AvmTest::check_selector 197 (-30) -13.22%
AvmTest::new_note_hash 105 (-16) -13.22%
AvmTest::new_nullifier 105 (-16) -13.22%
Test::emit_nullifier_public 105 (-16) -13.22%
AvmTest::assertion_failure 185 (-30) -13.95%
StaticChild::pub_get_value 184 (-30) -14.02%
InclusionProofs::test_nullifier_inclusion_from_public 171 (-30) -14.93%
AvmTest::return_oracle 350 (-68) -16.27%
InclusionProofs::push_nullifier_public 145 (-30) -17.14%
AvmTest::assert_same 140 (-30) -17.65%
AvmTest::emit_nullifier_and_check 140 (-30) -17.65%
AvmTest::assert_nullifier_exists 136 (-30) -18.07%
AvmTest::assert_timestamp 135 (-30) -18.18%
Test::dummy_public_call 127 (-30) -19.11%
Test::assert_public_global_vars 300 (-100) -25.00%

lucasxia01
lucasxia01 approved these changes Dec 2, 2024
View reviewed changes
Copy link
Contributor

@lucasxia01 lucasxia01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me! I would be curious to see what other bugs the static analyzer finds. I know for a fact we have other issues like this.

@DanielKotov DanielKotov merged commit 4a38edf into master Dec 2, 2024
47 checks passed
@DanielKotov DanielKotov deleted the dk/poseidon2s_fix branch December 2, 2024 17:44
@AztecBot AztecBot mentioned this pull request Dec 2, 2024
Merged
just-mitch pushed a commit that referenced this pull request Dec 6, 2024
@AztecBot
chore(master): Release 0.66.0 (#10282)
fc61b27 
🤖 I have created a release *beep* *boop*
---


<details><summary>aztec-package: 0.66.0</summary>

##
[0.66.0](aztec-package-v0.65.2...aztec-package-v0.66.0)
(2024-12-06)


### ⚠ BREAKING CHANGES

* Remove debug and winston in favor of pino
([#10355](#10355))

### Features

* Agent and broker expose OTEL metrics
([#10264](#10264))
([c2c8cc6](c2c8cc6))
* Epoch cache, do not attest if not in committee or from current
proposer
([#10327](#10327))
([9ebaa65](9ebaa65))
* Staking integration
([#10403](#10403))
([ecd6c4f](ecd6c4f))


### Miscellaneous

* Remove debug and winston in favor of pino
([#10355](#10355))
([c246aba](c246aba))
</details>

<details><summary>barretenberg.js: 0.66.0</summary>

##
[0.66.0](barretenberg.js-v0.65.2...barretenberg.js-v0.66.0)
(2024-12-06)


### Miscellaneous

* **barretenberg.js:** Synchronize aztec-packages versions
</details>

<details><summary>aztec-packages: 0.66.0</summary>

##
[0.66.0](aztec-packages-v0.65.2...aztec-packages-v0.66.0)
(2024-12-06)


### ⚠ BREAKING CHANGES

* remove `ec` module from stdlib
(noir-lang/noir#6612)
* Disallow `#[export]` on associated methods
(noir-lang/noir#6626)
* Require types of globals to be specified
(noir-lang/noir#6592)
* remove eddsa from stdlib (noir-lang/noir#6591)
* Remove debug and winston in favor of pino
([#10355](#10355))
* remove SchnorrVerify opcode
([#9897](#9897))

### Features

* Add `array_refcount` and `slice_refcount` builtins for debugging
(noir-lang/noir#6584)
([3304046](3304046))
* Add `BoundedVec::from_parts` and `BoundedVec::from_parts_unchecked`
(noir-lang/noir#6691)
([3304046](3304046))
* Add memory report into the CI
(noir-lang/noir#6630)
([3304046](3304046))
* Add workflow_call trigger to network-deploy
([#10451](#10451))
([18254e6](18254e6))
* Adding configurable data dir and p2p pk for testnet nodes
([#10422](#10422))
([77b0039](77b0039))
* Agent and broker expose OTEL metrics
([#10264](#10264))
([c2c8cc6](c2c8cc6))
* Allow filtering which SSA passes are printed
(noir-lang/noir#6636)
([3304046](3304046))
* Allow ignoring test failures from foreign calls
(noir-lang/noir#6660)
([3304046](3304046))
* Allow querying block number for tree indices
([#10332](#10332))
([cf05a7a](cf05a7a))
* AMM
([#10153](#10153))
([90668c3](90668c3))
* Avoid incrementing reference counts in some cases
(noir-lang/noir#6568)
([3304046](3304046))
* Avoid inserting an empty leaf in indexed trees on update
([#10281](#10281))
([5a04ca8](5a04ca8))
* Avoid inserting an empty leaf in indexed trees on update
([#10334](#10334))
([80fad45](80fad45))
* **bb:** Define std::hash for field
([#10312](#10312))
([752bc59](752bc59))
* Better error message when trying to invoke struct function field
(noir-lang/noir#6661)
([3304046](3304046))
* Client IVC API
([#10217](#10217))
([cc54a1e](cc54a1e))
* **comptime:** Implement blackbox functions in comptime interpreter
(noir-lang/noir#6551)
([3304046](3304046))
* Delete attestations older than a slot
([#10326](#10326))
([24abcfe](24abcfe))
* Deploy devnet to k8s
([#10449](#10449))
([27506c1](27506c1))
* Deploy networks via github actions
([#10381](#10381))
([7e19b39](7e19b39))
* **docs:** Applied structure feedback
([#9288](#9288))
([5b0b721](5b0b721))
* Epoch cache, do not attest if not in committee or from current
proposer
([#10327](#10327))
([9ebaa65](9ebaa65))
* Gas Utils for L1 operations
([#9834](#9834))
([17fa214](17fa214))
* Improve parser recovery of constructor field with '::' instead of ':'
(noir-lang/noir#6701)
([3304046](3304046))
* Integrate verify_proof calls in mock protocol circuits
([#9253](#9253))
([7ed89aa](7ed89aa))
* Making testnet script write a docker compose file
([#10333](#10333))
([be54cc3](be54cc3))
* Manage enqueued calls & phases in AVM witgen
([#10310](#10310))
([e7ebef8](e7ebef8))
* Mock IVC state from arbitrary acir IVC recursion constraints
([#10314](#10314))
([ac7c0da](ac7c0da))
* Optionally emit public bytecode
([#10365](#10365))
([84ff623](84ff623))
* **p2p:** Persist node private p2p keys
([#10324](#10324))
([1c32eda](1c32eda))
* **p2p:** Snappy compress p2p messages
([#10417](#10417))
([c643a54](c643a54))
* **perf:** Track last loads per block in mem2reg and remove them if
possible (noir-lang/noir#6088)
([3304046](3304046))
* Process blocks in parallel during epoch proving
([#10263](#10263))
([a9d418c](a9d418c))
* Reduce memory consumption by storing array length as `u32` during SSA
(noir-lang/noir#6606)
([3304046](3304046))
* Release please for release branch
([#10467](#10467))
([38941bf](38941bf))
* Replace quadratic removal of `rc` instructions
(noir-lang/noir#6705)
([3304046](3304046))
* Replace quadratic removal of rc instructions
([#10416](#10416))
([9d833c5](9d833c5))
* Revert changes to `ValueMerger` and `Instruction::IfElse`
(noir-lang/noir#6673)
([3304046](3304046))
* Show printable byte arrays as byte strings in SSA
(noir-lang/noir#6709)
([3304046](3304046))
* Simplify `jmpif`s by reversing branches if condition is negated
(noir-lang/noir#5891)
([3304046](3304046))
* **ssa:** Deduplicate intrinsics with predicates
(noir-lang/noir#6615)
([3304046](3304046))
* **ssa:** Hoisting of array get using known induction variable maximum
(noir-lang/noir#6639)
([3304046](3304046))
* **ssa:** Loop invariant code motion
(noir-lang/noir#6563)
([3304046](3304046))
* **ssa:** Option to set the maximum acceptable Brillig bytecode
increase in unrolling (noir-lang/noir#6641)
([3304046](3304046))
* **ssa:** Simplify array get from set that writes to the same dynamic
index (noir-lang/noir#6684)
([3304046](3304046))
* Staking integration
([#10403](#10403))
([ecd6c4f](ecd6c4f))
* Standalone ssd
([#10317](#10317))
([c324781](c324781))
* Switch to using an external noir implementation of Schnorr
([#10330](#10330))
([6cbd375](6cbd375))
* Sync from aztec-packages (noir-lang/noir#6576)
([3304046](3304046))
* Sync from aztec-packages (noir-lang/noir#6634)
([3304046](3304046))
* Sync from aztec-packages (noir-lang/noir#6656)
([3304046](3304046))
* Terraform for alerting on metrics
([#10192](#10192))
([05c9e5d](05c9e5d)),
closes
[#9956](#9956)
* Test release network via ci workflow
([#10388](#10388))
([e6060ec](e6060ec)),
closes
[#10383](#10383)
* **tooling:** Skip program transformation when loaded from cache
(noir-lang/noir#6689)
([3304046](3304046))
* Try to inline brillig calls with all constant arguments
(noir-lang/noir#6548)
([3304046](3304046))
* Ultra rollup flows
([#10162](#10162))
([c53f4cf](c53f4cf))
* Zip and propagate private logs
([#10210](#10210))
([5c32747](5c32747))
* Zip and silo and propagate private logs
([#10308](#10308))
([90d4385](90d4385))


### Bug Fixes

* Add helm
([#10454](#10454))
([2eb9ade](2eb9ade))
* Add secret
([#10453](#10453))
([95601df](95601df))
* Add type
([#10452](#10452))
([cd9699f](cd9699f))
* Allow multiple `_` parameters, and disallow `_` as an expression you
can read from (noir-lang/noir#6657)
([3304046](3304046))
* Always return an array of `u8`s when simplifying `Intrinsic::ToRadix`
calls (noir-lang/noir#6663)
([3304046](3304046))
* Await block unwind when a reorg happens
([#10380](#10380))
([5a02480](5a02480))
* Bbup cleanup and fix
([#10067](#10067))
([0ff8177](0ff8177))
* Bootstrapping devnet
([#10396](#10396))
([f3c7294](f3c7294))
* Bot waits for pxe synch
([#10316](#10316))
([ebd4165](ebd4165))
* Consider prereleases to be compatible with pre-1.0.0 releases
(noir-lang/noir#6580)
([3304046](3304046))
* Correct signed integer handling in `noirc_abi`
(noir-lang/noir#6638)
([3304046](3304046))
* Correct type when simplifying `derive_pedersen_generators`
(noir-lang/noir#6579)
([3304046](3304046))
* Correct types returned by constant EC operations simplified within SSA
(noir-lang/noir#6652)
([3304046](3304046))
* Disallow `#[export]` on associated methods
(noir-lang/noir#6626)
([3304046](3304046))
* Do not warn on unused functions marked with #[export]
(noir-lang/noir#6625)
([3304046](3304046))
* Don't pass default value for --node-url
([#10427](#10427))
([5299481](5299481)),
closes
[#10419](#10419)
* Don't remove necessary RC instructions in DIE pass
(noir-lang/noir#6585)
([3304046](3304046))
* Don't report visibility errors when elaborating comptime value
(noir-lang/noir#6498)
([3304046](3304046))
* Get node info from a PXE
([#10420](#10420))
([ed972f3](ed972f3))
* Increase timeouts
([#10412](#10412))
([d3b8838](d3b8838))
* LSP auto-import text indent
(noir-lang/noir#6699)
([3304046](3304046))
* LSP code action wasn't triggering on beginning or end of identifier
(noir-lang/noir#6616)
([3304046](3304046))
* **LSP:** Use generic self type to narrow down methods to complete
(noir-lang/noir#6617)
([3304046](3304046))
* Move spartan-script tf to spartan, use file in bucket
([#10395](#10395))
([5cef628](5cef628))
* Nit
([#10392](#10392))
([d6985a8](d6985a8))
* Optimize array ref counts to copy arrays much less often
(noir-lang/noir#6685)
([3304046](3304046))
* **p2p:** Override msg Id
([#10415](#10415))
([990d11b](990d11b))
* Parse a bit more SSA stuff
(noir-lang/noir#6599)
([3304046](3304046))
* Preserve newlines between comments when formatting statements
(noir-lang/noir#6601)
([3304046](3304046))
* Prevent hoisting binary instructions which can overflow
(noir-lang/noir#6672)
([3304046](3304046))
* **prover:** Handle starting blocks out of order in prover
([#10350](#10350))
([9106102](9106102))
* Publicly register contract classes
([#10385](#10385))
([94e6e1a](94e6e1a))
* Remove `compiler_version` from new `Nargo.toml`
(noir-lang/noir#6590)
([3304046](3304046))
* Revert "feat: Avoid inserting an empty leaf in indexed trees on
update"
([#10319](#10319))
([887c011](887c011))
* Revert "feat: zip and propagate private logs"
([#10302](#10302))
([9d70728](9d70728))
* Safely insert sibling paths
([#10423](#10423))
([41f7645](41f7645))
* **ssa:** Don't deduplicate constraints in blocks that are not
dominated (noir-lang/noir#6627)
([3304046](3304046))
* **ssa:** Remove RC tracker in DIE
(noir-lang/noir#6700)
([3304046](3304046))
* **ssa:** Track all local allocations during flattening
(noir-lang/noir#6619)
([3304046](3304046))
* Tf vars
([#10457](#10457))
([00aaef6](00aaef6))
* Typo in u128 docs (noir-lang/noir#6711)
([3304046](3304046))
* Url in bbup install
([#10456](#10456))
([1b0dfb7](1b0dfb7))
* Use correct type for attribute arguments
(noir-lang/noir#6640)
([3304046](3304046))
* Used signed division for signed modulo
(noir-lang/noir#6635)
([3304046](3304046))
* Witness changes in file sponge.hpp
([#10345](#10345))
([4a38edf](4a38edf))


### Miscellaneous

* Add `ram_blowup_regression` to memory report
(noir-lang/noir#6683)
([3304046](3304046))
* Add panic for compiler error described in
[#6620](#6620)
(noir-lang/noir#6621)
([3304046](3304046))
* **avm:** Fake verification routine for avm recursion in public base
rollup
([#10382](#10382))
([a1e5966](a1e5966)),
closes
[#10243](#10243)
* **avm:** Remove function selector type of getenv opcode
([#10406](#10406))
([38c0c14](38c0c14)),
closes
[#9396](#9396)
* Batch archiver requests
([#10442](#10442))
([9443e8e](9443e8e))
* Boot node has fixed peer id private key
([#10352](#10352))
([cae1203](cae1203))
* Bump alert in gossip_network.test.ts
([#10430](#10430))
([2c2169b](2c2169b))
* Centralized helm flag for proving and clean release tf deploys
([#10221](#10221))
([c2c1744](c2c1744))
* **ci:** Move playwright install to `+deps`
([#10293](#10293))
([d7bd306](d7bd306))
* Clean up archiver logs
([#10429](#10429))
([4fcbc59](4fcbc59))
* Consolidate some CI workflows to reduce sprawl
(noir-lang/noir#6696)
([3304046](3304046))
* Contracts on a diet
([#10389](#10389))
([dddb008](dddb008))
* Deduplicate constants across blocks
([#9972](#9972))
([69bb64f](69bb64f))
* Derive PartialEq and Hash for FieldElement
(noir-lang/noir#6610)
([3304046](3304046))
* **docs:** Remove additional `DEBUG` references, add note on
`LOG_LEVEL`s
([#10434](#10434))
([e1e5906](e1e5906))
* Don't generate proofs of verifier circuits in test
([#10405](#10405))
([c00ebdd](c00ebdd))
* Fix sassy-salamander chores v1
([#10218](#10218))
([7227b48](7227b48)),
closes
[#10074](#10074)
[#10075](#10075)
[#10077](#10077)
* Fix tests in `noirc_abi_wasm`
(noir-lang/noir#6688)
([3304046](3304046))
* Fix traces endpoint url in native testnet script
([#10309](#10309))
([2367c62](2367c62))
* Fix typo in test name (noir-lang/noir#6589)
([3304046](3304046))
* Fix warning when compiling `noir_wasm`
(noir-lang/noir#6686)
([3304046](3304046))
* Ignore almost-empty directories in nargo_cli tests
(noir-lang/noir#6611)
([3304046](3304046))
* Improve error message of `&T`
(noir-lang/noir#6633)
([3304046](3304046))
* Log manual contract class registrations
([#10354](#10354))
([da1470d](da1470d))
* Making bbup a shell script
([#10426](#10426))
([1c29554](1c29554))
* **network_test.sh:** Work around 143 by disabling stern
([#10436](#10436))
([64f6dad](64f6dad))
* Parallelise construction of perturbator coefficients at each level
([#10304](#10304))
([ba335bd](ba335bd))
* Parallelise inverse polynomial construction for lookup relations
([#10413](#10413))
([427cf59](427cf59))
* Pin foundry version in CI
(noir-lang/noir#6642)
([3304046](3304046))
* Public inputs in unit tests with proving were incorrectly set
([#10300](#10300))
([0311bf3](0311bf3))
* Pull out cfg simplification changes
([#10279](#10279))
([c48ae90](c48ae90))
* Pull out constant brillig inliner
([#10291](#10291))
([0577c1a](0577c1a))
* Pull out loop invariant optimization
([#10277](#10277))
([94cba37](94cba37))
* Pull out sync changes
([#10292](#10292))
([49f80b3](49f80b3))
* Random typos
([#10393](#10393))
([ed47a42](ed47a42))
* Redo typo PR by Dimitrolito
([#10364](#10364))
([da809c5](da809c5))
* Redo typo PR by Dimitrolito
(noir-lang/noir#6614)
([3304046](3304046))
* Redo typo PR by donatik27
(noir-lang/noir#6575)
([3304046](3304046))
* Redo typo PR by leopardracer
([#10363](#10363))
([0d1b722](0d1b722))
* Redo typo PR by leopardracer
([#10444](#10444))
([3653c4c](3653c4c))
* Refactor foreign call executors
(noir-lang/noir#6659)
([3304046](3304046))
* Refactor indexed tree to use traits
([#10361](#10361))
([621cbaf](621cbaf))
* Refactor poseidon2 (noir-lang/noir#6655)
([3304046](3304046))
* Release Noir(1.0.0-beta.0)
(noir-lang/noir#6562)
([3304046](3304046))
* Remove `ec` module from stdlib
(noir-lang/noir#6612)
([3304046](3304046))
* Remove debug and winston in favor of pino
([#10355](#10355))
([c246aba](c246aba))
* Remove eddsa from stdlib (noir-lang/noir#6591)
([3304046](3304046))
* Remove inliner override for `reference_counts` test
(noir-lang/noir#6714)
([3304046](3304046))
* Remove SchnorrVerify opcode
([#9897](#9897))
([93cd323](93cd323))
* Remove temporary allocations from `num_bits`
(noir-lang/noir#6600)
([3304046](3304046))
* Remove unused dep
([#10295](#10295))
([2a07355](2a07355))
* Replace relative paths to noir-protocol-circuits
([8fd8236](8fd8236))
* Replace relative paths to noir-protocol-circuits
([5d11e24](5d11e24))
* Replace relative paths to noir-protocol-circuits
([e7a99f2](e7a99f2))
* Replace relative paths to noir-protocol-circuits
([2496118](2496118))
* Replace relative paths to noir-protocol-circuits
([d77dc96](d77dc96))
* Replace relative paths to noir-protocol-circuits
([46d12e3](46d12e3))
* Require types of globals to be specified
(noir-lang/noir#6592)
([3304046](3304046))
* Revert "fix: Don't remove necessary RC instructions in DIE pass
(noir-lang/noir#6585)"
(noir-lang/noir#6693)
([3304046](3304046))
* Sassy network
([#10468](#10468))
([92eb377](92eb377))
* Simplify otel config, 1val setup, fix pod dns, retries
([#10344](#10344))
([be91d80](be91d80))
* Skip A-&gt;B B->A e2e_2_pxes test
([#10297](#10297))
([b75bfd0](b75bfd0))
* Sync logging with jest
([#10459](#10459))
([6e33cb9](6e33cb9))
* Typo in oracles how to (noir-lang/noir#6598)
([3304046](3304046))
* Update noir-bench-report version
(noir-lang/noir#6675)
([3304046](3304046))
* Update pprof (noir-lang/noir#6710)
([3304046](3304046))
* Update release-please action
(noir-lang/noir#6704)
([3304046](3304046))
* Use non default mnemonic for releases
([#10400](#10400))
([bb5f364](bb5f364))
</details>

<details><summary>barretenberg: 0.66.0</summary>

##
[0.66.0](barretenberg-v0.65.2...barretenberg-v0.66.0)
(2024-12-06)


### ⚠ BREAKING CHANGES

* remove SchnorrVerify opcode
([#9897](#9897))

### Features

* Allow querying block number for tree indices
([#10332](#10332))
([cf05a7a](cf05a7a))
* Avoid inserting an empty leaf in indexed trees on update
([#10281](#10281))
([5a04ca8](5a04ca8))
* Avoid inserting an empty leaf in indexed trees on update
([#10334](#10334))
([80fad45](80fad45))
* **bb:** Define std::hash for field
([#10312](#10312))
([752bc59](752bc59))
* Client IVC API
([#10217](#10217))
([cc54a1e](cc54a1e))
* Integrate verify_proof calls in mock protocol circuits
([#9253](#9253))
([7ed89aa](7ed89aa))
* Manage enqueued calls & phases in AVM witgen
([#10310](#10310))
([e7ebef8](e7ebef8))
* Mock IVC state from arbitrary acir IVC recursion constraints
([#10314](#10314))
([ac7c0da](ac7c0da))
* Ultra rollup flows
([#10162](#10162))
([c53f4cf](c53f4cf))


### Bug Fixes

* Bbup cleanup and fix
([#10067](#10067))
([0ff8177](0ff8177))
* Revert "feat: Avoid inserting an empty leaf in indexed trees on
update"
([#10319](#10319))
([887c011](887c011))
* Url in bbup install
([#10456](#10456))
([1b0dfb7](1b0dfb7))
* Witness changes in file sponge.hpp
([#10345](#10345))
([4a38edf](4a38edf))


### Miscellaneous

* **avm:** Fake verification routine for avm recursion in public base
rollup
([#10382](#10382))
([a1e5966](a1e5966)),
closes
[#10243](#10243)
* **avm:** Remove function selector type of getenv opcode
([#10406](#10406))
([38c0c14](38c0c14)),
closes
[#9396](#9396)
* Don't generate proofs of verifier circuits in test
([#10405](#10405))
([c00ebdd](c00ebdd))
* Making bbup a shell script
([#10426](#10426))
([1c29554](1c29554))
* Parallelise construction of perturbator coefficients at each level
([#10304](#10304))
([ba335bd](ba335bd))
* Parallelise inverse polynomial construction for lookup relations
([#10413](#10413))
([427cf59](427cf59))
* Public inputs in unit tests with proving were incorrectly set
([#10300](#10300))
([0311bf3](0311bf3))
* Redo typo PR by Dimitrolito
([#10364](#10364))
([da809c5](da809c5))
* Redo typo PR by leopardracer
([#10363](#10363))
([0d1b722](0d1b722))
* Remove SchnorrVerify opcode
([#9897](#9897))
([93cd323](93cd323))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
AztecBot added a commit to AztecProtocol/barretenberg that referenced this pull request Dec 7, 2024
@AztecBot
chore(master): Release 0.66.0 (#10282)
4a04424 
🤖 I have created a release *beep* *boop*
---


<details><summary>aztec-package: 0.66.0</summary>

##
[0.66.0](AztecProtocol/aztec-packages@aztec-package-v0.65.2...aztec-package-v0.66.0)
(2024-12-06)


### ⚠ BREAKING CHANGES

* Remove debug and winston in favor of pino
([#10355](AztecProtocol/aztec-packages#10355))

### Features

* Agent and broker expose OTEL metrics
([#10264](AztecProtocol/aztec-packages#10264))
([c2c8cc6](AztecProtocol/aztec-packages@c2c8cc6))
* Epoch cache, do not attest if not in committee or from current
proposer
([#10327](AztecProtocol/aztec-packages#10327))
([9ebaa65](AztecProtocol/aztec-packages@9ebaa65))
* Staking integration
([#10403](AztecProtocol/aztec-packages#10403))
([ecd6c4f](AztecProtocol/aztec-packages@ecd6c4f))


### Miscellaneous

* Remove debug and winston in favor of pino
([#10355](AztecProtocol/aztec-packages#10355))
([c246aba](AztecProtocol/aztec-packages@c246aba))
</details>

<details><summary>barretenberg.js: 0.66.0</summary>

##
[0.66.0](AztecProtocol/aztec-packages@barretenberg.js-v0.65.2...barretenberg.js-v0.66.0)
(2024-12-06)


### Miscellaneous

* **barretenberg.js:** Synchronize aztec-packages versions
</details>

<details><summary>aztec-packages: 0.66.0</summary>

##
[0.66.0](AztecProtocol/aztec-packages@aztec-packages-v0.65.2...aztec-packages-v0.66.0)
(2024-12-06)


### ⚠ BREAKING CHANGES

* remove `ec` module from stdlib
(noir-lang/noir#6612)
* Disallow `#[export]` on associated methods
(noir-lang/noir#6626)
* Require types of globals to be specified
(noir-lang/noir#6592)
* remove eddsa from stdlib (noir-lang/noir#6591)
* Remove debug and winston in favor of pino
([#10355](AztecProtocol/aztec-packages#10355))
* remove SchnorrVerify opcode
([#9897](AztecProtocol/aztec-packages#9897))

### Features

* Add `array_refcount` and `slice_refcount` builtins for debugging
(noir-lang/noir#6584)
([3304046](AztecProtocol/aztec-packages@3304046))
* Add `BoundedVec::from_parts` and `BoundedVec::from_parts_unchecked`
(noir-lang/noir#6691)
([3304046](AztecProtocol/aztec-packages@3304046))
* Add memory report into the CI
(noir-lang/noir#6630)
([3304046](AztecProtocol/aztec-packages@3304046))
* Add workflow_call trigger to network-deploy
([#10451](AztecProtocol/aztec-packages#10451))
([18254e6](AztecProtocol/aztec-packages@18254e6))
* Adding configurable data dir and p2p pk for testnet nodes
([#10422](AztecProtocol/aztec-packages#10422))
([77b0039](AztecProtocol/aztec-packages@77b0039))
* Agent and broker expose OTEL metrics
([#10264](AztecProtocol/aztec-packages#10264))
([c2c8cc6](AztecProtocol/aztec-packages@c2c8cc6))
* Allow filtering which SSA passes are printed
(noir-lang/noir#6636)
([3304046](AztecProtocol/aztec-packages@3304046))
* Allow ignoring test failures from foreign calls
(noir-lang/noir#6660)
([3304046](AztecProtocol/aztec-packages@3304046))
* Allow querying block number for tree indices
([#10332](AztecProtocol/aztec-packages#10332))
([cf05a7a](AztecProtocol/aztec-packages@cf05a7a))
* AMM
([#10153](AztecProtocol/aztec-packages#10153))
([90668c3](AztecProtocol/aztec-packages@90668c3))
* Avoid incrementing reference counts in some cases
(noir-lang/noir#6568)
([3304046](AztecProtocol/aztec-packages@3304046))
* Avoid inserting an empty leaf in indexed trees on update
([#10281](AztecProtocol/aztec-packages#10281))
([5a04ca8](AztecProtocol/aztec-packages@5a04ca8))
* Avoid inserting an empty leaf in indexed trees on update
([#10334](AztecProtocol/aztec-packages#10334))
([80fad45](AztecProtocol/aztec-packages@80fad45))
* **bb:** Define std::hash for field
([#10312](AztecProtocol/aztec-packages#10312))
([752bc59](AztecProtocol/aztec-packages@752bc59))
* Better error message when trying to invoke struct function field
(noir-lang/noir#6661)
([3304046](AztecProtocol/aztec-packages@3304046))
* Client IVC API
([#10217](AztecProtocol/aztec-packages#10217))
([cc54a1e](AztecProtocol/aztec-packages@cc54a1e))
* **comptime:** Implement blackbox functions in comptime interpreter
(noir-lang/noir#6551)
([3304046](AztecProtocol/aztec-packages@3304046))
* Delete attestations older than a slot
([#10326](AztecProtocol/aztec-packages#10326))
([24abcfe](AztecProtocol/aztec-packages@24abcfe))
* Deploy devnet to k8s
([#10449](AztecProtocol/aztec-packages#10449))
([27506c1](AztecProtocol/aztec-packages@27506c1))
* Deploy networks via github actions
([#10381](AztecProtocol/aztec-packages#10381))
([7e19b39](AztecProtocol/aztec-packages@7e19b39))
* **docs:** Applied structure feedback
([#9288](AztecProtocol/aztec-packages#9288))
([5b0b721](AztecProtocol/aztec-packages@5b0b721))
* Epoch cache, do not attest if not in committee or from current
proposer
([#10327](AztecProtocol/aztec-packages#10327))
([9ebaa65](AztecProtocol/aztec-packages@9ebaa65))
* Gas Utils for L1 operations
([#9834](AztecProtocol/aztec-packages#9834))
([17fa214](AztecProtocol/aztec-packages@17fa214))
* Improve parser recovery of constructor field with '::' instead of ':'
(noir-lang/noir#6701)
([3304046](AztecProtocol/aztec-packages@3304046))
* Integrate verify_proof calls in mock protocol circuits
([#9253](AztecProtocol/aztec-packages#9253))
([7ed89aa](AztecProtocol/aztec-packages@7ed89aa))
* Making testnet script write a docker compose file
([#10333](AztecProtocol/aztec-packages#10333))
([be54cc3](AztecProtocol/aztec-packages@be54cc3))
* Manage enqueued calls & phases in AVM witgen
([#10310](AztecProtocol/aztec-packages#10310))
([e7ebef8](AztecProtocol/aztec-packages@e7ebef8))
* Mock IVC state from arbitrary acir IVC recursion constraints
([#10314](AztecProtocol/aztec-packages#10314))
([ac7c0da](AztecProtocol/aztec-packages@ac7c0da))
* Optionally emit public bytecode
([#10365](AztecProtocol/aztec-packages#10365))
([84ff623](AztecProtocol/aztec-packages@84ff623))
* **p2p:** Persist node private p2p keys
([#10324](AztecProtocol/aztec-packages#10324))
([1c32eda](AztecProtocol/aztec-packages@1c32eda))
* **p2p:** Snappy compress p2p messages
([#10417](AztecProtocol/aztec-packages#10417))
([c643a54](AztecProtocol/aztec-packages@c643a54))
* **perf:** Track last loads per block in mem2reg and remove them if
possible (noir-lang/noir#6088)
([3304046](AztecProtocol/aztec-packages@3304046))
* Process blocks in parallel during epoch proving
([#10263](AztecProtocol/aztec-packages#10263))
([a9d418c](AztecProtocol/aztec-packages@a9d418c))
* Reduce memory consumption by storing array length as `u32` during SSA
(noir-lang/noir#6606)
([3304046](AztecProtocol/aztec-packages@3304046))
* Release please for release branch
([#10467](AztecProtocol/aztec-packages#10467))
([38941bf](AztecProtocol/aztec-packages@38941bf))
* Replace quadratic removal of `rc` instructions
(noir-lang/noir#6705)
([3304046](AztecProtocol/aztec-packages@3304046))
* Replace quadratic removal of rc instructions
([#10416](AztecProtocol/aztec-packages#10416))
([9d833c5](AztecProtocol/aztec-packages@9d833c5))
* Revert changes to `ValueMerger` and `Instruction::IfElse`
(noir-lang/noir#6673)
([3304046](AztecProtocol/aztec-packages@3304046))
* Show printable byte arrays as byte strings in SSA
(noir-lang/noir#6709)
([3304046](AztecProtocol/aztec-packages@3304046))
* Simplify `jmpif`s by reversing branches if condition is negated
(noir-lang/noir#5891)
([3304046](AztecProtocol/aztec-packages@3304046))
* **ssa:** Deduplicate intrinsics with predicates
(noir-lang/noir#6615)
([3304046](AztecProtocol/aztec-packages@3304046))
* **ssa:** Hoisting of array get using known induction variable maximum
(noir-lang/noir#6639)
([3304046](AztecProtocol/aztec-packages@3304046))
* **ssa:** Loop invariant code motion
(noir-lang/noir#6563)
([3304046](AztecProtocol/aztec-packages@3304046))
* **ssa:** Option to set the maximum acceptable Brillig bytecode
increase in unrolling (noir-lang/noir#6641)
([3304046](AztecProtocol/aztec-packages@3304046))
* **ssa:** Simplify array get from set that writes to the same dynamic
index (noir-lang/noir#6684)
([3304046](AztecProtocol/aztec-packages@3304046))
* Staking integration
([#10403](AztecProtocol/aztec-packages#10403))
([ecd6c4f](AztecProtocol/aztec-packages@ecd6c4f))
* Standalone ssd
([#10317](AztecProtocol/aztec-packages#10317))
([c324781](AztecProtocol/aztec-packages@c324781))
* Switch to using an external noir implementation of Schnorr
([#10330](AztecProtocol/aztec-packages#10330))
([6cbd375](AztecProtocol/aztec-packages@6cbd375))
* Sync from aztec-packages (noir-lang/noir#6576)
([3304046](AztecProtocol/aztec-packages@3304046))
* Sync from aztec-packages (noir-lang/noir#6634)
([3304046](AztecProtocol/aztec-packages@3304046))
* Sync from aztec-packages (noir-lang/noir#6656)
([3304046](AztecProtocol/aztec-packages@3304046))
* Terraform for alerting on metrics
([#10192](AztecProtocol/aztec-packages#10192))
([05c9e5d](AztecProtocol/aztec-packages@05c9e5d)),
closes
[#9956](AztecProtocol/aztec-packages#9956)
* Test release network via ci workflow
([#10388](AztecProtocol/aztec-packages#10388))
([e6060ec](AztecProtocol/aztec-packages@e6060ec)),
closes
[#10383](AztecProtocol/aztec-packages#10383)
* **tooling:** Skip program transformation when loaded from cache
(noir-lang/noir#6689)
([3304046](AztecProtocol/aztec-packages@3304046))
* Try to inline brillig calls with all constant arguments
(noir-lang/noir#6548)
([3304046](AztecProtocol/aztec-packages@3304046))
* Ultra rollup flows
([#10162](AztecProtocol/aztec-packages#10162))
([c53f4cf](AztecProtocol/aztec-packages@c53f4cf))
* Zip and propagate private logs
([#10210](AztecProtocol/aztec-packages#10210))
([5c32747](AztecProtocol/aztec-packages@5c32747))
* Zip and silo and propagate private logs
([#10308](AztecProtocol/aztec-packages#10308))
([90d4385](AztecProtocol/aztec-packages@90d4385))


### Bug Fixes

* Add helm
([#10454](AztecProtocol/aztec-packages#10454))
([2eb9ade](AztecProtocol/aztec-packages@2eb9ade))
* Add secret
([#10453](AztecProtocol/aztec-packages#10453))
([95601df](AztecProtocol/aztec-packages@95601df))
* Add type
([#10452](AztecProtocol/aztec-packages#10452))
([cd9699f](AztecProtocol/aztec-packages@cd9699f))
* Allow multiple `_` parameters, and disallow `_` as an expression you
can read from (noir-lang/noir#6657)
([3304046](AztecProtocol/aztec-packages@3304046))
* Always return an array of `u8`s when simplifying `Intrinsic::ToRadix`
calls (noir-lang/noir#6663)
([3304046](AztecProtocol/aztec-packages@3304046))
* Await block unwind when a reorg happens
([#10380](AztecProtocol/aztec-packages#10380))
([5a02480](AztecProtocol/aztec-packages@5a02480))
* Bbup cleanup and fix
([#10067](AztecProtocol/aztec-packages#10067))
([0ff8177](AztecProtocol/aztec-packages@0ff8177))
* Bootstrapping devnet
([#10396](AztecProtocol/aztec-packages#10396))
([f3c7294](AztecProtocol/aztec-packages@f3c7294))
* Bot waits for pxe synch
([#10316](AztecProtocol/aztec-packages#10316))
([ebd4165](AztecProtocol/aztec-packages@ebd4165))
* Consider prereleases to be compatible with pre-1.0.0 releases
(noir-lang/noir#6580)
([3304046](AztecProtocol/aztec-packages@3304046))
* Correct signed integer handling in `noirc_abi`
(noir-lang/noir#6638)
([3304046](AztecProtocol/aztec-packages@3304046))
* Correct type when simplifying `derive_pedersen_generators`
(noir-lang/noir#6579)
([3304046](AztecProtocol/aztec-packages@3304046))
* Correct types returned by constant EC operations simplified within SSA
(noir-lang/noir#6652)
([3304046](AztecProtocol/aztec-packages@3304046))
* Disallow `#[export]` on associated methods
(noir-lang/noir#6626)
([3304046](AztecProtocol/aztec-packages@3304046))
* Do not warn on unused functions marked with #[export]
(noir-lang/noir#6625)
([3304046](AztecProtocol/aztec-packages@3304046))
* Don't pass default value for --node-url
([#10427](AztecProtocol/aztec-packages#10427))
([5299481](AztecProtocol/aztec-packages@5299481)),
closes
[#10419](AztecProtocol/aztec-packages#10419)
* Don't remove necessary RC instructions in DIE pass
(noir-lang/noir#6585)
([3304046](AztecProtocol/aztec-packages@3304046))
* Don't report visibility errors when elaborating comptime value
(noir-lang/noir#6498)
([3304046](AztecProtocol/aztec-packages@3304046))
* Get node info from a PXE
([#10420](AztecProtocol/aztec-packages#10420))
([ed972f3](AztecProtocol/aztec-packages@ed972f3))
* Increase timeouts
([#10412](AztecProtocol/aztec-packages#10412))
([d3b8838](AztecProtocol/aztec-packages@d3b8838))
* LSP auto-import text indent
(noir-lang/noir#6699)
([3304046](AztecProtocol/aztec-packages@3304046))
* LSP code action wasn't triggering on beginning or end of identifier
(noir-lang/noir#6616)
([3304046](AztecProtocol/aztec-packages@3304046))
* **LSP:** Use generic self type to narrow down methods to complete
(noir-lang/noir#6617)
([3304046](AztecProtocol/aztec-packages@3304046))
* Move spartan-script tf to spartan, use file in bucket
([#10395](AztecProtocol/aztec-packages#10395))
([5cef628](AztecProtocol/aztec-packages@5cef628))
* Nit
([#10392](AztecProtocol/aztec-packages#10392))
([d6985a8](AztecProtocol/aztec-packages@d6985a8))
* Optimize array ref counts to copy arrays much less often
(noir-lang/noir#6685)
([3304046](AztecProtocol/aztec-packages@3304046))
* **p2p:** Override msg Id
([#10415](AztecProtocol/aztec-packages#10415))
([990d11b](AztecProtocol/aztec-packages@990d11b))
* Parse a bit more SSA stuff
(noir-lang/noir#6599)
([3304046](AztecProtocol/aztec-packages@3304046))
* Preserve newlines between comments when formatting statements
(noir-lang/noir#6601)
([3304046](AztecProtocol/aztec-packages@3304046))
* Prevent hoisting binary instructions which can overflow
(noir-lang/noir#6672)
([3304046](AztecProtocol/aztec-packages@3304046))
* **prover:** Handle starting blocks out of order in prover
([#10350](AztecProtocol/aztec-packages#10350))
([9106102](AztecProtocol/aztec-packages@9106102))
* Publicly register contract classes
([#10385](AztecProtocol/aztec-packages#10385))
([94e6e1a](AztecProtocol/aztec-packages@94e6e1a))
* Remove `compiler_version` from new `Nargo.toml`
(noir-lang/noir#6590)
([3304046](AztecProtocol/aztec-packages@3304046))
* Revert "feat: Avoid inserting an empty leaf in indexed trees on
update"
([#10319](AztecProtocol/aztec-packages#10319))
([887c011](AztecProtocol/aztec-packages@887c011))
* Revert "feat: zip and propagate private logs"
([#10302](AztecProtocol/aztec-packages#10302))
([9d70728](AztecProtocol/aztec-packages@9d70728))
* Safely insert sibling paths
([#10423](AztecProtocol/aztec-packages#10423))
([41f7645](AztecProtocol/aztec-packages@41f7645))
* **ssa:** Don't deduplicate constraints in blocks that are not
dominated (noir-lang/noir#6627)
([3304046](AztecProtocol/aztec-packages@3304046))
* **ssa:** Remove RC tracker in DIE
(noir-lang/noir#6700)
([3304046](AztecProtocol/aztec-packages@3304046))
* **ssa:** Track all local allocations during flattening
(noir-lang/noir#6619)
([3304046](AztecProtocol/aztec-packages@3304046))
* Tf vars
([#10457](AztecProtocol/aztec-packages#10457))
([00aaef6](AztecProtocol/aztec-packages@00aaef6))
* Typo in u128 docs (noir-lang/noir#6711)
([3304046](AztecProtocol/aztec-packages@3304046))
* Url in bbup install
([#10456](AztecProtocol/aztec-packages#10456))
([1b0dfb7](AztecProtocol/aztec-packages@1b0dfb7))
* Use correct type for attribute arguments
(noir-lang/noir#6640)
([3304046](AztecProtocol/aztec-packages@3304046))
* Used signed division for signed modulo
(noir-lang/noir#6635)
([3304046](AztecProtocol/aztec-packages@3304046))
* Witness changes in file sponge.hpp
([#10345](AztecProtocol/aztec-packages#10345))
([4a38edf](AztecProtocol/aztec-packages@4a38edf))


### Miscellaneous

* Add `ram_blowup_regression` to memory report
(noir-lang/noir#6683)
([3304046](AztecProtocol/aztec-packages@3304046))
* Add panic for compiler error described in
[#6620](AztecProtocol/aztec-packages#6620)
(noir-lang/noir#6621)
([3304046](AztecProtocol/aztec-packages@3304046))
* **avm:** Fake verification routine for avm recursion in public base
rollup
([#10382](AztecProtocol/aztec-packages#10382))
([a1e5966](AztecProtocol/aztec-packages@a1e5966)),
closes
[#10243](AztecProtocol/aztec-packages#10243)
* **avm:** Remove function selector type of getenv opcode
([#10406](AztecProtocol/aztec-packages#10406))
([38c0c14](AztecProtocol/aztec-packages@38c0c14)),
closes
[#9396](AztecProtocol/aztec-packages#9396)
* Batch archiver requests
([#10442](AztecProtocol/aztec-packages#10442))
([9443e8e](AztecProtocol/aztec-packages@9443e8e))
* Boot node has fixed peer id private key
([#10352](AztecProtocol/aztec-packages#10352))
([cae1203](AztecProtocol/aztec-packages@cae1203))
* Bump alert in gossip_network.test.ts
([#10430](AztecProtocol/aztec-packages#10430))
([2c2169b](AztecProtocol/aztec-packages@2c2169b))
* Centralized helm flag for proving and clean release tf deploys
([#10221](AztecProtocol/aztec-packages#10221))
([c2c1744](AztecProtocol/aztec-packages@c2c1744))
* **ci:** Move playwright install to `+deps`
([#10293](AztecProtocol/aztec-packages#10293))
([d7bd306](AztecProtocol/aztec-packages@d7bd306))
* Clean up archiver logs
([#10429](AztecProtocol/aztec-packages#10429))
([4fcbc59](AztecProtocol/aztec-packages@4fcbc59))
* Consolidate some CI workflows to reduce sprawl
(noir-lang/noir#6696)
([3304046](AztecProtocol/aztec-packages@3304046))
* Contracts on a diet
([#10389](AztecProtocol/aztec-packages#10389))
([dddb008](AztecProtocol/aztec-packages@dddb008))
* Deduplicate constants across blocks
([#9972](AztecProtocol/aztec-packages#9972))
([69bb64f](AztecProtocol/aztec-packages@69bb64f))
* Derive PartialEq and Hash for FieldElement
(noir-lang/noir#6610)
([3304046](AztecProtocol/aztec-packages@3304046))
* **docs:** Remove additional `DEBUG` references, add note on
`LOG_LEVEL`s
([#10434](AztecProtocol/aztec-packages#10434))
([e1e5906](AztecProtocol/aztec-packages@e1e5906))
* Don't generate proofs of verifier circuits in test
([#10405](AztecProtocol/aztec-packages#10405))
([c00ebdd](AztecProtocol/aztec-packages@c00ebdd))
* Fix sassy-salamander chores v1
([#10218](AztecProtocol/aztec-packages#10218))
([7227b48](AztecProtocol/aztec-packages@7227b48)),
closes
[#10074](AztecProtocol/aztec-packages#10074)
[#10075](AztecProtocol/aztec-packages#10075)
[#10077](AztecProtocol/aztec-packages#10077)
* Fix tests in `noirc_abi_wasm`
(noir-lang/noir#6688)
([3304046](AztecProtocol/aztec-packages@3304046))
* Fix traces endpoint url in native testnet script
([#10309](AztecProtocol/aztec-packages#10309))
([2367c62](AztecProtocol/aztec-packages@2367c62))
* Fix typo in test name (noir-lang/noir#6589)
([3304046](AztecProtocol/aztec-packages@3304046))
* Fix warning when compiling `noir_wasm`
(noir-lang/noir#6686)
([3304046](AztecProtocol/aztec-packages@3304046))
* Ignore almost-empty directories in nargo_cli tests
(noir-lang/noir#6611)
([3304046](AztecProtocol/aztec-packages@3304046))
* Improve error message of `&T`
(noir-lang/noir#6633)
([3304046](AztecProtocol/aztec-packages@3304046))
* Log manual contract class registrations
([#10354](AztecProtocol/aztec-packages#10354))
([da1470d](AztecProtocol/aztec-packages@da1470d))
* Making bbup a shell script
([#10426](AztecProtocol/aztec-packages#10426))
([1c29554](AztecProtocol/aztec-packages@1c29554))
* **network_test.sh:** Work around 143 by disabling stern
([#10436](AztecProtocol/aztec-packages#10436))
([64f6dad](AztecProtocol/aztec-packages@64f6dad))
* Parallelise construction of perturbator coefficients at each level
([#10304](AztecProtocol/aztec-packages#10304))
([ba335bd](AztecProtocol/aztec-packages@ba335bd))
* Parallelise inverse polynomial construction for lookup relations
([#10413](AztecProtocol/aztec-packages#10413))
([427cf59](AztecProtocol/aztec-packages@427cf59))
* Pin foundry version in CI
(noir-lang/noir#6642)
([3304046](AztecProtocol/aztec-packages@3304046))
* Public inputs in unit tests with proving were incorrectly set
([#10300](AztecProtocol/aztec-packages#10300))
([0311bf3](AztecProtocol/aztec-packages@0311bf3))
* Pull out cfg simplification changes
([#10279](AztecProtocol/aztec-packages#10279))
([c48ae90](AztecProtocol/aztec-packages@c48ae90))
* Pull out constant brillig inliner
([#10291](AztecProtocol/aztec-packages#10291))
([0577c1a](AztecProtocol/aztec-packages@0577c1a))
* Pull out loop invariant optimization
([#10277](AztecProtocol/aztec-packages#10277))
([94cba37](AztecProtocol/aztec-packages@94cba37))
* Pull out sync changes
([#10292](AztecProtocol/aztec-packages#10292))
([49f80b3](AztecProtocol/aztec-packages@49f80b3))
* Random typos
([#10393](AztecProtocol/aztec-packages#10393))
([ed47a42](AztecProtocol/aztec-packages@ed47a42))
* Redo typo PR by Dimitrolito
([#10364](AztecProtocol/aztec-packages#10364))
([da809c5](AztecProtocol/aztec-packages@da809c5))
* Redo typo PR by Dimitrolito
(noir-lang/noir#6614)
([3304046](AztecProtocol/aztec-packages@3304046))
* Redo typo PR by donatik27
(noir-lang/noir#6575)
([3304046](AztecProtocol/aztec-packages@3304046))
* Redo typo PR by leopardracer
([#10363](AztecProtocol/aztec-packages#10363))
([0d1b722](AztecProtocol/aztec-packages@0d1b722))
* Redo typo PR by leopardracer
([#10444](AztecProtocol/aztec-packages#10444))
([3653c4c](AztecProtocol/aztec-packages@3653c4c))
* Refactor foreign call executors
(noir-lang/noir#6659)
([3304046](AztecProtocol/aztec-packages@3304046))
* Refactor indexed tree to use traits
([#10361](AztecProtocol/aztec-packages#10361))
([621cbaf](AztecProtocol/aztec-packages@621cbaf))
* Refactor poseidon2 (noir-lang/noir#6655)
([3304046](AztecProtocol/aztec-packages@3304046))
* Release Noir(1.0.0-beta.0)
(noir-lang/noir#6562)
([3304046](AztecProtocol/aztec-packages@3304046))
* Remove `ec` module from stdlib
(noir-lang/noir#6612)
([3304046](AztecProtocol/aztec-packages@3304046))
* Remove debug and winston in favor of pino
([#10355](AztecProtocol/aztec-packages#10355))
([c246aba](AztecProtocol/aztec-packages@c246aba))
* Remove eddsa from stdlib (noir-lang/noir#6591)
([3304046](AztecProtocol/aztec-packages@3304046))
* Remove inliner override for `reference_counts` test
(noir-lang/noir#6714)
([3304046](AztecProtocol/aztec-packages@3304046))
* Remove SchnorrVerify opcode
([#9897](AztecProtocol/aztec-packages#9897))
([93cd323](AztecProtocol/aztec-packages@93cd323))
* Remove temporary allocations from `num_bits`
(noir-lang/noir#6600)
([3304046](AztecProtocol/aztec-packages@3304046))
* Remove unused dep
([#10295](AztecProtocol/aztec-packages#10295))
([2a07355](AztecProtocol/aztec-packages@2a07355))
* Replace relative paths to noir-protocol-circuits
([8fd8236](AztecProtocol/aztec-packages@8fd8236))
* Replace relative paths to noir-protocol-circuits
([5d11e24](AztecProtocol/aztec-packages@5d11e24))
* Replace relative paths to noir-protocol-circuits
([e7a99f2](AztecProtocol/aztec-packages@e7a99f2))
* Replace relative paths to noir-protocol-circuits
([2496118](AztecProtocol/aztec-packages@2496118))
* Replace relative paths to noir-protocol-circuits
([d77dc96](AztecProtocol/aztec-packages@d77dc96))
* Replace relative paths to noir-protocol-circuits
([46d12e3](AztecProtocol/aztec-packages@46d12e3))
* Require types of globals to be specified
(noir-lang/noir#6592)
([3304046](AztecProtocol/aztec-packages@3304046))
* Revert "fix: Don't remove necessary RC instructions in DIE pass
(noir-lang/noir#6585)"
(noir-lang/noir#6693)
([3304046](AztecProtocol/aztec-packages@3304046))
* Sassy network
([#10468](AztecProtocol/aztec-packages#10468))
([92eb377](AztecProtocol/aztec-packages@92eb377))
* Simplify otel config, 1val setup, fix pod dns, retries
([#10344](AztecProtocol/aztec-packages#10344))
([be91d80](AztecProtocol/aztec-packages@be91d80))
* Skip A-&gt;B B->A e2e_2_pxes test
([#10297](AztecProtocol/aztec-packages#10297))
([b75bfd0](AztecProtocol/aztec-packages@b75bfd0))
* Sync logging with jest
([#10459](AztecProtocol/aztec-packages#10459))
([6e33cb9](AztecProtocol/aztec-packages@6e33cb9))
* Typo in oracles how to (noir-lang/noir#6598)
([3304046](AztecProtocol/aztec-packages@3304046))
* Update noir-bench-report version
(noir-lang/noir#6675)
([3304046](AztecProtocol/aztec-packages@3304046))
* Update pprof (noir-lang/noir#6710)
([3304046](AztecProtocol/aztec-packages@3304046))
* Update release-please action
(noir-lang/noir#6704)
([3304046](AztecProtocol/aztec-packages@3304046))
* Use non default mnemonic for releases
([#10400](AztecProtocol/aztec-packages#10400))
([bb5f364](AztecProtocol/aztec-packages@bb5f364))
</details>

<details><summary>barretenberg: 0.66.0</summary>

##
[0.66.0](AztecProtocol/aztec-packages@barretenberg-v0.65.2...barretenberg-v0.66.0)
(2024-12-06)


### ⚠ BREAKING CHANGES

* remove SchnorrVerify opcode
([#9897](AztecProtocol/aztec-packages#9897))

### Features

* Allow querying block number for tree indices
([#10332](AztecProtocol/aztec-packages#10332))
([cf05a7a](AztecProtocol/aztec-packages@cf05a7a))
* Avoid inserting an empty leaf in indexed trees on update
([#10281](AztecProtocol/aztec-packages#10281))
([5a04ca8](AztecProtocol/aztec-packages@5a04ca8))
* Avoid inserting an empty leaf in indexed trees on update
([#10334](AztecProtocol/aztec-packages#10334))
([80fad45](AztecProtocol/aztec-packages@80fad45))
* **bb:** Define std::hash for field
([#10312](AztecProtocol/aztec-packages#10312))
([752bc59](AztecProtocol/aztec-packages@752bc59))
* Client IVC API
([#10217](AztecProtocol/aztec-packages#10217))
([cc54a1e](AztecProtocol/aztec-packages@cc54a1e))
* Integrate verify_proof calls in mock protocol circuits
([#9253](AztecProtocol/aztec-packages#9253))
([7ed89aa](AztecProtocol/aztec-packages@7ed89aa))
* Manage enqueued calls & phases in AVM witgen
([#10310](AztecProtocol/aztec-packages#10310))
([e7ebef8](AztecProtocol/aztec-packages@e7ebef8))
* Mock IVC state from arbitrary acir IVC recursion constraints
([#10314](AztecProtocol/aztec-packages#10314))
([ac7c0da](AztecProtocol/aztec-packages@ac7c0da))
* Ultra rollup flows
([#10162](AztecProtocol/aztec-packages#10162))
([c53f4cf](AztecProtocol/aztec-packages@c53f4cf))


### Bug Fixes

* Bbup cleanup and fix
([#10067](AztecProtocol/aztec-packages#10067))
([0ff8177](AztecProtocol/aztec-packages@0ff8177))
* Revert "feat: Avoid inserting an empty leaf in indexed trees on
update"
([#10319](AztecProtocol/aztec-packages#10319))
([887c011](AztecProtocol/aztec-packages@887c011))
* Url in bbup install
([#10456](AztecProtocol/aztec-packages#10456))
([1b0dfb7](AztecProtocol/aztec-packages@1b0dfb7))
* Witness changes in file sponge.hpp
([#10345](AztecProtocol/aztec-packages#10345))
([4a38edf](AztecProtocol/aztec-packages@4a38edf))


### Miscellaneous

* **avm:** Fake verification routine for avm recursion in public base
rollup
([#10382](AztecProtocol/aztec-packages#10382))
([a1e5966](AztecProtocol/aztec-packages@a1e5966)),
closes
[#10243](AztecProtocol/aztec-packages#10243)
* **avm:** Remove function selector type of getenv opcode
([#10406](AztecProtocol/aztec-packages#10406))
([38c0c14](AztecProtocol/aztec-packages@38c0c14)),
closes
[#9396](AztecProtocol/aztec-packages#9396)
* Don't generate proofs of verifier circuits in test
([#10405](AztecProtocol/aztec-packages#10405))
([c00ebdd](AztecProtocol/aztec-packages@c00ebdd))
* Making bbup a shell script
([#10426](AztecProtocol/aztec-packages#10426))
([1c29554](AztecProtocol/aztec-packages@1c29554))
* Parallelise construction of perturbator coefficients at each level
([#10304](AztecProtocol/aztec-packages#10304))
([ba335bd](AztecProtocol/aztec-packages@ba335bd))
* Parallelise inverse polynomial construction for lookup relations
([#10413](AztecProtocol/aztec-packages#10413))
([427cf59](AztecProtocol/aztec-packages@427cf59))
* Public inputs in unit tests with proving were incorrectly set
([#10300](AztecProtocol/aztec-packages#10300))
([0311bf3](AztecProtocol/aztec-packages@0311bf3))
* Redo typo PR by Dimitrolito
([#10364](AztecProtocol/aztec-packages#10364))
([da809c5](AztecProtocol/aztec-packages@da809c5))
* Redo typo PR by leopardracer
([#10363](AztecProtocol/aztec-packages#10363))
([0d1b722](AztecProtocol/aztec-packages@0d1b722))
* Remove SchnorrVerify opcode
([#9897](AztecProtocol/aztec-packages#9897))
([93cd323](AztecProtocol/aztec-packages@93cd323))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucasxia01 lucasxia01 lucasxia01 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DanielKotov @lucasxia01