Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert merge changes, compile time down from 90 to 10 mins #10341

Merged
merged 5 commits into from
Dec 3, 2024

Conversation

MirandaWood
Copy link
Contributor

Reverted the noir changes from this merge: fe6fa68#diff-44fc1bda823fb66518af03520024bce3369ceb8114807d5ca9cf301d8bfcec7cL563
Bootstrapping protocol circuits went from 90mins to 10mins at the compile stage.
(Apologies for lack of formatting)

@TomAFrench TomAFrench marked this pull request as ready for review December 2, 2024 15:06

This comment was marked as off-topic.

Copy link
Contributor

github-actions bot commented Dec 2, 2024

Changes to circuit sizes

Generated at commit: e5a5454e2554bf977273ebbdb3074fe766c19f8d, compared to commit: ccb82b26758aea1c38adbc4c989052b03292cd59

🧾 Summary (100% most significant diffs)

Program ACIR opcodes (+/-) % Circuit size (+/-) %
private_kernel_tail +1,200 ❌ +29.03% +2,668 ❌ +21.32%
private_kernel_init +5,703 ❌ +26.64% +4,625 ❌ +13.40%
private_kernel_tail_to_public +1,334 ❌ +7.67% +3,822 ❌ +12.95%
private_kernel_inner +7,864 ❌ +20.94% +6,128 ❌ +10.77%
private_kernel_reset +6,624 ❌ +7.88% +8,670 ❌ +1.40%
rollup_base_public -17,435 ✅ -4.21% +20,653 ❌ +0.63%
private_kernel_empty +350 ❌ +57.10% +350 ❌ +0.04%
rollup_block_root -12,117 ✅ -2.23% -12,135 ✅ -0.29%
rollup_base_private +651 ❌ +0.36% -23,004 ✅ -1.17%

Full diff report 👇
Program ACIR opcodes (+/-) % Circuit size (+/-) %
private_kernel_tail 5,333 (+1,200) +29.03% 15,183 (+2,668) +21.32%
private_kernel_init 27,112 (+5,703) +26.64% 39,131 (+4,625) +13.40%
private_kernel_tail_to_public 18,720 (+1,334) +7.67% 33,327 (+3,822) +12.95%
private_kernel_inner 45,416 (+7,864) +20.94% 63,010 (+6,128) +10.77%
private_kernel_reset 90,653 (+6,624) +7.88% 626,709 (+8,670) +1.40%
rollup_base_public 396,740 (-17,435) -4.21% 3,307,963 (+20,653) +0.63%
private_kernel_empty 963 (+350) +57.10% 901,990 (+350) +0.04%
rollup_block_root 532,259 (-12,117) -2.23% 4,125,897 (-12,135) -0.29%
rollup_base_private 180,815 (+651) +0.36% 1,946,889 (-23,004) -1.17%

This comment was marked as off-topic.

This comment was marked as off-topic.

@MirandaWood MirandaWood mentioned this pull request Dec 3, 2024
@MirandaWood MirandaWood merged commit f5aac25 into mw/blob-circuit-2 Dec 3, 2024
68 checks passed
@MirandaWood MirandaWood deleted the mw/blob-circuit-2-test branch December 3, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant