Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Mini Aztec Connect With Uniswap #879

Closed
Tracked by #843
LHerskind opened this issue Jun 19, 2023 · 1 comment
Closed
Tracked by #843

feat: Mini Aztec Connect With Uniswap #879

LHerskind opened this issue Jun 19, 2023 · 1 comment
Assignees
Labels
T-feature-request Type: Adding a brand new feature (not to be confused with improving an existing feature).

Comments

@LHerskind
Copy link
Contributor

Extend the Uniswap noir contract with extension to aggregate multiple "swaps" with the same parameters into one large swap (Aztec Connect style).

The swap flow itself will be similarly to what is outlined in #843, but the aggregation itself should be done before this, and have a distribution stage afterwards ensuring that people get their funds.

  1. Aggregate
  2. Perform swap as in Tracking issue: Trading on Uniswap L1 from L2  #843
  3. Distribute

Aztec connect used the sequencer to perform the distribute step, consider doing similar with "partial" claims, or let the users individually handle their claims. For now, don't need to consider fees.

@github-project-automation github-project-automation bot moved this to Todo in A3 Jun 19, 2023
@LHerskind LHerskind added the T-feature-request Type: Adding a brand new feature (not to be confused with improving an existing feature). label Jun 19, 2023
@LHerskind LHerskind assigned Maddiaa0 and unassigned rahul-kothari Aug 8, 2023
@Maddiaa0 Maddiaa0 moved this from Todo to In Progress in A3 Aug 21, 2023
@Maddiaa0 Maddiaa0 assigned LHerskind and unassigned Maddiaa0 Aug 22, 2023
@LHerskind LHerskind moved this from In Progress to In Review in A3 Aug 26, 2023
@iAmMichaelConnor iAmMichaelConnor modified the milestones: 🚀 Initial F&F Sandbox Release, 📢 Initial Public Sandbox Release Aug 30, 2023
@LHerskind LHerskind moved this from In Review to Blocked in A3 Sep 5, 2023
@LHerskind LHerskind removed this from the 📢 Initial Public Sandbox Release milestone Sep 18, 2023
@LHerskind
Copy link
Contributor Author

Replaced by #2167

@github-project-automation github-project-automation bot moved this from Blocked to Done in A3 Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-feature-request Type: Adding a brand new feature (not to be confused with improving an existing feature).
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants