Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(vc): validators should only attest proposal they know are from the leader #8721

Closed
Tracked by #7681
Maddiaa0 opened this issue Sep 24, 2024 · 0 comments · Fixed by #10327
Closed
Tracked by #7681

feat(vc): validators should only attest proposal they know are from the leader #8721

Maddiaa0 opened this issue Sep 24, 2024 · 0 comments · Fixed by #10327
Assignees
@Maddiaa0
Labels
C-validator Component: validator client
Milestone
TestNet

Comments

@Maddiaa0
Copy link
Member

Maddiaa0 commented Sep 24, 2024 •
edited
Loading

Overview

AC:

  • given that attestors know the leader for a given epoch, they should only attest to proposals that come from said leader, this is dependant on

For the meantime, the validator client can request the leader from the l1 contract and store it locally / cache it based on the hard timings
@github-project-automation github-project-automation bot moved this to Todo in A3 Sep 24, 2024
@Maddiaa0 Maddiaa0 mentioned this issue Sep 24, 2024
Open
@Maddiaa0 Maddiaa0 added this to the Sequencer & Prover Testnet milestone Sep 24, 2024
@Maddiaa0 Maddiaa0 self-assigned this Sep 24, 2024
@Maddiaa0 Maddiaa0 removed this from A3 Sep 24, 2024
@Maddiaa0 Maddiaa0 added the C-validator Component: validator client label Oct 2, 2024
@github-project-automation github-project-automation bot moved this to Todo in A3 Oct 2, 2024
@Maddiaa0 Maddiaa0 mentioned this issue Dec 2, 2024
Merged
Maddiaa0 added a commit that referenced this issue Dec 6, 2024
@Maddiaa0 @just-mitch
feat: epoch cache, do not attest if not in committee or from current …
9ebaa65 
…proposer (#10327)

some of: #7962
fixes: #8721

---------

Co-authored-by: Mitch <[email protected]>
Co-authored-by: just-mitch <[email protected]>
@github-project-automation github-project-automation bot moved this from Todo to Done in A3 Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Maddiaa0 Maddiaa0

Labels
C-validator Component: validator client
Projects
A3
Status: Done
Milestone
TestNet
2 participants
@Maddiaa0 @just-mitch