feat: rate limit peers in request response p2p interactions

[Maddiaa0]

Overview

Add global / peer based rate limiting of request response p2p interactions based on a GCRA rate limiter

fixes: #8460

[Maddiaa0]

• refactor: use config object to make phase manager less noisy #8586
• refactor: remove multiple public dbs #8585
• feat(vc): remove viem signers from validator client #8517
• feat: rate limit peers in request response p2p interactions #8498 👈
• feat: Add timeouts for request / response stream connections #8434
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Maddiaa0 and the rest of your teammates on Graphite

[AztecBot]

Benchmark results

Metrics with a significant change:

• proof_construction_time_sha256_30_ms (16): 1,369 (-20%)
• protocol_circuit_simulation_time_in_ms (private-kernel-tail-to-public): 1,002 (-29%)
• avm_simulation_time_ms (FeeJuice:_increase_public_balance): 47.7 (-66%)
• avm_simulation_time_ms (FeeJuice:set_portal): 13.9 (+57%)
• avm_simulation_time_ms (Token:assert_minter_and_mint): 322 (+436%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Proof generation

Each column represents the number of threads used in proof generation.

Metric	1 threads	4 threads	16 threads	32 threads	64 threads
proof_construction_time_sha256_ms	5,753	1,545	707	747 (-1%)	768 (-1%)
proof_construction_time_sha256_30_ms	11,456 (-1%)	3,055 (-1%)	⚠️ 1,369 (-20%)	1,423 (-9%)	1,467 (-5%)
proof_construction_time_sha256_100_ms	45,287	11,777 (-1%)	5,737 (+3%)	5,932	5,352 (-6%)
proof_construction_time_poseidon_hash_ms	79.0 (+1%)	34.0	34.0	57.0 (-2%)	88.0 (+1%)
proof_construction_time_poseidon_hash_30_ms	1,526	428 (+3%)	200 (+1%)	221 (-1%)	273 (+2%)
proof_construction_time_poseidon_hash_100_ms	5,632	1,500	668 (-1%)	720 (-2%)	741 (-1%)

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	4 txs	8 txs	16 txs
l1_rollup_calldata_size_in_bytes	4,612	8,260	15,524
l1_rollup_calldata_gas	52,792	97,674	186,860
l1_rollup_execution_gas	819,478	1,555,768	3,346,389
l2_block_processing_time_in_ms	255 (+1%)	451	805
l2_block_building_time_in_ms	9,336 (-1%)	18,306 (-1%)	36,821
l2_block_rollup_simulation_time_in_ms	9,336 (-1%)	18,306 (-1%)	36,821
l2_block_public_tx_process_time_in_ms	7,942	16,903 (-1%)	35,374

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 8 txs.

Metric	3 blocks	5 blocks
node_history_sync_time_in_ms	3,229 (+2%)	3,997 (-2%)
node_database_size_in_bytes	14,229,744	18,243,824
pxe_database_size_in_bytes	16,258	26,818

Circuits stats

Stats on running time and I/O sizes collected for every kernel circuit run across all benchmarks.

Circuit	simulation_time_in_ms	witness_generation_time_in_ms	input_size_in_bytes	output_size_in_bytes	proving_time_in_ms
private-kernel-init	71.7 (-6%)	380 (+1%)	20,975	44,933	N/A
private-kernel-inner	139 (-2%)	693	71,787	45,067	N/A
private-kernel-reset-tiny	321 (-3%)	712 (+2%)	64,273	44,922	N/A
private-kernel-tail	152	133 (+2%)	50,551	57,178	N/A
base-parity	5.53	N/A	160	96.0	N/A
root-parity	35.2 (+1%)	N/A	73,964	96.0	N/A
base-rollup	2,094 (-2%)	N/A	189,128	664	N/A
block-root-rollup	41.0	N/A	58,217	2,448	N/A
public-kernel-setup	86.6 (+1%)	N/A	114,433	79,670	N/A
public-kernel-app-logic	99.3	N/A	114,251	79,670	N/A
public-kernel-tail	583 (-1%)	N/A	487,098	16,414	N/A
private-kernel-reset-small	304 (+1%)	N/A	66,345	45,629	N/A
private-kernel-tail-to-public	⚠️ 1,002 (-29%)	607 (-1%)	448,120	1,825	N/A
public-kernel-teardown	85.2 (-1%)	N/A	114,697	79,670	N/A
merge-rollup	19.8 (-1%)	N/A	38,182	664	N/A
undefined	N/A	N/A	N/A	N/A	104,630 (+2%)

Stats on running time collected for app circuits

Function	input_size_in_bytes	output_size_in_bytes	witness_generation_time_in_ms
ContractClassRegisterer:register	1,344	11,731	350 (+1%)
ContractInstanceDeployer:deploy	1,408	11,731	18.1 (-1%)
MultiCallEntrypoint:entrypoint	1,920	11,731	426 (+1%)
FeeJuice:deploy	1,376	11,731	395 (+1%)
SchnorrAccount:constructor	1,312	11,731	60.1
SchnorrAccount:entrypoint	2,336	11,731	368 (-1%)
FeeJuice:claim	1,344	11,731	36.7 (-2%)
Token:privately_mint_private_note	1,280	11,731	73.3 (+10%)
FPC:fee_entrypoint_public	1,344	11,731	25.6 (+6%)
Token:transfer	1,312	11,731	206
Benchmarking:create_note	1,344	11,731	74.6 (+2%)
SchnorrAccount:verify_private_authwit	1,280	11,731	26.3 (-1%)
Token:unshield	1,376	11,731	488
FPC:fee_entrypoint_private	1,376	11,731	647 (-1%)

AVM Simulation

Time to simulate various public functions in the AVM.

Function	time_ms	bytecode_size_in_bytes
FeeJuice:_increase_public_balance	⚠️ 47.7 (-66%)	1,188
FeeJuice:set_portal	⚠️ 13.9 (+57%)	1,170
Token:constructor	252 (+2%)	10,378
FPC:constructor	71.8 (+2%)	7,877
FeeJuice:check_balance	35.5	995
Token:mint_public	253 (+5%)	2,123
Token:assert_minter_and_mint	⚠️ 322 (+436%)	1,435
AuthRegistry:set_authorized	38.8 (+7%)	515
FPC:prepare_fee	83.1 (+2%)	1,588
Token:transfer_public	16.2 (-4%)	8,603
FPC:pay_refund	37.8	2,090
Benchmarking:increment_balance	998 (-1%)	1,516
Token:_increase_public_balance	36.4 (-2%)	1,159
FPC:pay_refund_with_shielded_rebate	48.9 (-2%)	2,090

Public DB Access

Time to access various public DBs.

Function	time_ms
get-nullifier-index	0.164

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	16 leaves	64 leaves	128 leaves	256 leaves	512 leaves	1024 leaves
batch_insert_into_append_only_tree_16_depth_ms	2.17 (+1%)	3.85 (-1%)	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.7	31.8	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.113 (+1%)	0.108 (-1%)	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	11.2	17.8 (+1%)	31.4 (+3%)	59.7 (-1%)	113 (+2%)
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	95.9	159	287	543	1,055
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	0.108 (+1%)	0.103 (+1%)	0.102 (+2%)	0.103 (-1%)	0.101 (+1%)
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	14.3	26.2 (-1%)	44.2 (+2%)	85.8 (+3%)	161 (-2%)
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	109	207	357	691	1,363
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	0.109	0.106 (-1%)	0.102 (+1%)	0.106 (+2%)	0.102 (-3%)
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	16.2 (+1%)	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	129	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	0.106 (+1%)	N/A	N/A	N/A	N/A

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric	0 registered classes	1 registered classes
tx_size_in_bytes	72,419	668,302

Transaction size based on fee payment method

| Metric | |
| - | |

[just-mitch]

Am I crazy? I don't see how this allows for the burst check. Consider:

The quota is 10 requests per second, emissionInterval is 100ms, limitInterval 1000ms

Then two requests come in back-to-back

Request 1:
Suppose the initial vst is 1000
now is 1050
now (1050) > vst (1000), so we pass the first check
newVst is calculated as 1000 + 100 = 1100
newVst (1100) - now (1050) = 50, which is <= limitInterval (1000)
The request is allowed, and vst is updated to 1100

Request 2 (immediately after):
vst is now 1100
now is still around 1050
now (1050) < vst (1100), so the request is immediately denied

[Maddiaa0]

Nah I don't think you are I've over simplified it, I'll adjust

[just-mitch]

🔥 . Or I guess 🧊 , since it keeps rates chill 😏 .

[just-mitch]

Lovely documentation