Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: rate limit direct p2p requests from nodes #8460

Closed
Tracked by #8077
Maddiaa0 opened this issue Sep 9, 2024 · 0 comments · Fixed by #8498
Closed
Tracked by #8077

feat: rate limit direct p2p requests from nodes #8460

Maddiaa0 opened this issue Sep 9, 2024 · 0 comments · Fixed by #8498
Assignees

Comments

@Maddiaa0
Copy link
Member

Maddiaa0 commented Sep 9, 2024

Overview

The request response mechanism is a target for DDosing among nodes. To help with this, nodes will need to be able to rate limit requests that come in.

The most appropriate sort of rate limiting algorithm appears to be GRCA rate limiter ( based on an exploration into the lodestar codebase ).

A/C:
Implement a rate limiting mechanism that can:

  • Have different rate limiting quotas based on each ReqResp subprotocol
  • Be able to be integrated with a peer scoring mechanism
  • Have a different per peer / global rate limiting quota across protocols.
  • Cope with load spikes + malicious peers effectively.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant