Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Change U128 serde to respect "canonical" Noir serde #8271

Open
Thunkar opened this issue Aug 29, 2024 · 2 comments
Open

bug: Change U128 serde to respect "canonical" Noir serde #8271

Thunkar opened this issue Aug 29, 2024 · 2 comments
Assignees
Labels
T-bug Type: Bug. Something is broken.
Milestone

Comments

@Thunkar
Copy link
Contributor

Thunkar commented Aug 29, 2024

It generates a myriad of problems and difficult to debug issues. U128 currently is a struct with two limbs, well, let's (de)serialize it as such and not "collapse" it into a Field. Further reading: https://hackmd.io/@aztec-network/Hkbo4p9gR?type=view

Note: Because of this issue we have a lot of conversions to and from U128 in our codebase (e.g. Token::balance_of_public converts U128 to a Field before returning the value). Once this is tackled find all these conversions and remove them. Look for TODO(#8271) in the codebase.

@Thunkar Thunkar added the T-bug Type: Bug. Something is broken. label Aug 29, 2024
@Thunkar Thunkar self-assigned this Aug 29, 2024
@github-project-automation github-project-automation bot moved this to Todo in A3 Aug 29, 2024
@benesjan
Copy link
Contributor

Relevant discussion

@benesjan benesjan mentioned this issue Oct 10, 2024
@nventuro
Copy link
Contributor

Related to #7728

@nventuro nventuro added this to the TestNet milestone Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-bug Type: Bug. Something is broken.
Projects
Status: Todo
Development

No branches or pull requests

3 participants