Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Constants without dependencies #8084

Open
Tracked by #7820
LHerskind opened this issue Aug 20, 2024 · 0 comments
Open
Tracked by #7820

feat: Constants without dependencies #8084

LHerskind opened this issue Aug 20, 2024 · 0 comments

Comments

@LHerskind
Copy link
Contributor

The current constants setup where we use the constants.nr to build the others files are a pain in the ass if dealing with places that needs the constants but is itself a dependency of the noir-protocol-circuits.

I suggest that we move the constants down to foundation which don't have dependencies on anything else than bb.js which should be acceptable for this case.

It is especially a pain when dealing with things in the Ethereum package such at ethereum slot durations or constants to be used in the deployments (FEE_JUICE_INITIAL_MINT).

Might also help us with #3342 and circular dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

No branches or pull requests

1 participant