refactor(avm): no fake rows in main trace

[fcarreiro]

Needed for gas accounting.

There are some extra changes but it's the best I could split the PR.

PS: We do have repeated SLOADS/SSTORES which are kind of fake, but all else should be good (modulo the stubbed gadgets that dont have a selector).

[fcarreiro]

• refactor(avm): no fake rows in main trace #7823 👈
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @fcarreiro and the rest of your teammates on Graphite

[AztecBot]

Benchmark results

Metrics with a significant change:

• proof_construction_time_sha256_100_ms (16): 5,644 (-19%)
• proof_construction_time_sha256_30_ms (16): 1,422 (-19%)
• protocol_circuit_simulation_time_in_ms (private-kernel-tail-to-public): 2,332 (-31%)
• avm_simulation_time_ms (AuthRegistry:set_authorized): 10.4 (+41%)
• avm_simulation_time_ms (Token:transfer_public): 31.7 (-30%)
• avm_simulation_time_ms (Token:_increase_public_balance): 9.47 (-82%)
• protocol_circuit_proving_time_in_ms (base-parity): 1,695 (+55%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Proof generation

Each column represents the number of threads used in proof generation.

Metric	1 threads	4 threads	16 threads	32 threads	64 threads
proof_construction_time_sha256_ms	5,704	1,538	702	744	768 (+1%)
proof_construction_time_sha256_30_ms	11,696 (-1%)	3,159	⚠️ 1,422 (-19%)	1,449 (-10%)	1,472 (-5%)
proof_construction_time_sha256_100_ms	43,658	12,298 (-2%)	⚠️ 5,644 (-19%)	5,587 (-8%)	5,506 (-5%)
proof_construction_time_poseidon_hash_ms	78.0	34.0	35.0 (+3%)	59.0 (+2%)	88.0 (+1%)
proof_construction_time_poseidon_hash_30_ms	1,518	416	201 (+1%)	224 (+1%)	269
proof_construction_time_poseidon_hash_100_ms	5,614	1,512	679 (+1%)	724 (+1%)	750

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	4 txs	8 txs	16 txs
l1_rollup_calldata_size_in_bytes	740	740	740
l1_rollup_calldata_gas	6,704	6,716	6,716
l1_rollup_execution_gas	611,971	612,134	612,285
l2_block_processing_time_in_ms	247 (-2%)	444 (+2%)	807 (+2%)
l2_block_building_time_in_ms	9,640 (+1%)	18,600	37,406
l2_block_rollup_simulation_time_in_ms	9,639 (+1%)	18,599	37,405
l2_block_public_tx_process_time_in_ms	8,003 (+1%)	16,802 (+1%)	35,521

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 8 txs.

Metric	3 blocks	5 blocks
node_history_sync_time_in_ms	2,733 (-1%)	3,587
node_database_size_in_bytes	12,718,160	16,945,232
pxe_database_size_in_bytes	16,254	26,813

Circuits stats

Stats on running time and I/O sizes collected for every kernel circuit run across all benchmarks.

Circuit	simulation_time_in_ms	witness_generation_time_in_ms	input_size_in_bytes	output_size_in_bytes	proving_time_in_ms	proof_size_in_bytes	num_public_inputs	size_in_gates
private-kernel-init	96.4 (-1%)	413 (+5%)	21,846	44,858	N/A	N/A	N/A	N/A
private-kernel-inner	174	732 (+5%)	72,545	45,005	N/A	N/A	N/A	N/A
private-kernel-tail	679	847 (+3%)	53,216	50,574	N/A	N/A	N/A	N/A
base-parity	5.88	596 (+5%)	160	96.0	⚠️ 1,695 (+55%)	13,188	19.0	65,536
root-parity	109 (+1%)	113 (-10%)	69,084	96.0	27,808 (-11%)	13,188	19.0	4,194,304
base-rollup	2,963	5,515 (+2%)	182,736	664	86,281 (-11%)	14,020	45.0	16,777,216
root-rollup	97.1 (+1%)	103 (-10%)	54,525	716	25,385 (-11%)	13,988	44.0	4,194,304
public-kernel-setup	90.8	2,727 (-2%)	103,513	70,710	15,302 (-13%)	128,708	3,629	2,097,152
public-kernel-app-logic	106 (+1%)	4,120	103,513	70,710	8,934 (-11%)	128,708	3,629	1,048,576
public-kernel-tail	576	29,026 (-3%)	403,238	11,326	92,879 (-14%)	27,204	457	16,777,216
private-kernel-reset-tiny	193 (+5%)	881 (+1%)	68,621	44,750	N/A	N/A	N/A	N/A
private-kernel-tail-to-public	⚠️ 2,332 (-31%)	1,616 (+3%)	942,862	1,697	N/A	N/A	N/A	N/A
public-kernel-teardown	86.3 (-2%)	4,250 (+2%)	103,513	70,710	16,425 (-11%)	128,708	3,629	2,097,152
merge-rollup	59.7	N/A	35,742	664	N/A	N/A	N/A	N/A
undefined	N/A	N/A	N/A	N/A	66,845 (-4%)	N/A	N/A	N/A

Stats on running time collected for app circuits

Function	input_size_in_bytes	output_size_in_bytes	witness_generation_time_in_ms	proof_size_in_bytes	proving_time_in_ms
ContractClassRegisterer:register	1,344	11,731	343 (+2%)	N/A	N/A
ContractInstanceDeployer:deploy	1,408	11,731	18.4 (+2%)	N/A	N/A
MultiCallEntrypoint:entrypoint	1,920	11,731	481 (+2%)	N/A	N/A
FeeJuice:deploy	1,376	11,731	401 (+5%)	N/A	N/A
SchnorrAccount:constructor	1,312	11,731	177 (+1%)	N/A	N/A
SchnorrAccount:entrypoint	2,304	11,731	537 (+1%)	N/A	N/A
Token:privately_mint_private_note	1,280	11,731	225 (+2%)	N/A	N/A
FPC:fee_entrypoint_public	1,344	11,731	32.5 (-2%)	N/A	N/A
Token:transfer	1,312	11,731	455 (+1%)	N/A	N/A
AuthRegistry:set_authorized (avm)	18,491	N/A	N/A	147,296	2,602 (+6%)
FPC:prepare_fee (avm)	22,958	N/A	N/A	147,360	3,355 (+8%)
Token:transfer_public (avm)	61,614	N/A	N/A	147,360	17,138 (-1%)
AuthRegistry:consume (avm)	41,719	N/A	N/A	147,328	7,610 (+3%)
FPC:pay_refund (avm)	26,227	N/A	N/A	147,328	7,136 (-1%)
Benchmarking:create_note	1,344	11,731	169 (+1%)	N/A	N/A
SchnorrAccount:verify_private_authwit	1,280	11,731	27.4	N/A	N/A
Token:unshield	1,376	11,731	731 (-1%)	N/A	N/A
FPC:fee_entrypoint_private	1,376	11,731	963 (-2%)	N/A	N/A

AVM Simulation

Time to simulate various public functions in the AVM.

Function	time_ms	bytecode_size_in_bytes
FeeJuice:_increase_public_balance	95.4 (+1%)	8,139
FeeJuice:set_portal	10.7 (+10%)	2,362
Token:constructor	119 (-1%)	31,107
FPC:constructor	92.5 (-1%)	22,380
FeeJuice:mint_public	81.2 (+3%)	6,150
Token:mint_public	83.1	11,720
Token:assert_minter_and_mint	89.8 (+2%)	8,028
AuthRegistry:set_authorized	⚠️ 10.4 (+41%)	4,537
FPC:prepare_fee	278 (-1%)	8,812
Token:transfer_public	⚠️ 31.7 (-30%)	47,374
FPC:pay_refund	68.4 (+4%)	12,114
Benchmarking:increment_balance	1,010 (+1%)	7,450
Token:_increase_public_balance	⚠️ 9.47 (-82%)	8,960
FPC:pay_refund_with_shielded_rebate	138 (-2%)	12,663

Public DB Access

Time to access various public DBs.

Function	time_ms
get-nullifier-index	0.154 (-2%)

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	16 leaves	64 leaves	128 leaves	256 leaves	512 leaves	1024 leaves
batch_insert_into_append_only_tree_16_depth_ms	2.19 (+4%)	3.89 (+1%)	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.8	31.7	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.114 (+4%)	0.110 (+1%)	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	11.2 (+3%)	17.9	30.8 (+1%)	59.4 (+2%)	113 (+1%)
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	95.9	159	287	543	1,055
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	0.108 (+3%)	0.104	0.100 (+1%)	0.102 (+3%)	0.101
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	14.3 (+2%)	27.0 (+3%)	43.6 (+1%)	83.3 (+2%)	161 (+1%)
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	109	207	355	691	1,363
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	0.108 (+1%)	0.104 (-2%)	0.106	0.103 (+1%)	0.102 (+1%)
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	16.7 (+3%)	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	132	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	0.107 (+2%)	N/A	N/A	N/A	N/A

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric	0 registered classes	1 registered classes
tx_size_in_bytes	63,593	665,008

Transaction size based on fee payment method

| Metric | |
| - | |