refactor(avm): no fake rows in main trace

AztecProtocol · Aug 7, 2024 · 996386b · 996386b
1 parent ef30c8f
commit 996386b
Show file tree

Hide file tree

Showing 16 changed files with 978 additions and 1,479 deletions.
diff --git a/barretenberg/cpp/format.sh b/barretenberg/cpp/format.sh
@@ -13,6 +13,12 @@ if [ "$1" == "staged" ]; then
     sed -i.bak 's/\r$//' $FILE && rm ${FILE}.bak
     git add $FILE
   done
+elif [ "$1" == "changed" ]; then
+  echo Formatting barretenberg changed files...
+  for FILE in $(git diff-index --diff-filter=d --relative --name-only HEAD | grep -e '\.\(cpp\|hpp\|tcc\)$'); do
+    clang-format-16 -i $FILE
+    sed -i.bak 's/\r$//' $FILE && rm ${FILE}.bak
+  done
 elif [ "$1" == "check" ]; then
   for FILE in $(find ./src -iname *.hpp -o -iname *.cpp -o -iname *.tcc | grep -v src/msgpack-c); do
     clang-format-16 --dry-run --Werror $FILE

diff --git a/barretenberg/cpp/pil/avm/main.pil b/barretenberg/cpp/pil/avm/main.pil
@@ -497,11 +497,11 @@ namespace main(256);
     //       Alternatively, we introduce a boolean selector for the three opcodes mentioned above.
     //       Note: External call gas cost is not constrained
     pol commit sel_gas_accounting_active;
-    pol commit sel_mem_op_activate_gas; // TODO: remove this one
     // TODO: remove sload and sstore from here
     // This temporarily disables gas tracking for sload and sstore because our gas
     // tracking doesn't work properly for instructions that span multiple rows
-    sel_gas_accounting_active - OPCODE_SELECTORS - SEL_ALL_CTRL_FLOW - sel_op_sload - sel_op_sstore - sel_mem_op_activate_gas = 0;
+    // TODO: disabling this until PR in stack.
+    // sel_gas_accounting_active - OPCODE_SELECTORS - SEL_ALL_CTRL_FLOW - sel_op_sload - sel_op_sstore - sel_mem_op_activate_gas = 0;
 
     // Program counter must increment if not jumping or returning
     // TODO: support for muli-rows opcode in execution trace such as

diff --git a/barretenberg/cpp/src/barretenberg/vm/avm/generated/circuit_builder.cpp b/barretenberg/cpp/src/barretenberg/vm/avm/generated/circuit_builder.cpp
@@ -206,7 +206,6 @@ AvmCircuitBuilder::ProverPolynomials AvmCircuitBuilder::compute_polynomials() co
         polys.main_sel_gas_accounting_active[i] = rows[i].main_sel_gas_accounting_active;
         polys.main_sel_last[i] = rows[i].main_sel_last;
         polys.main_sel_mem_op_a[i] = rows[i].main_sel_mem_op_a;
-        polys.main_sel_mem_op_activate_gas[i] = rows[i].main_sel_mem_op_activate_gas;
         polys.main_sel_mem_op_b[i] = rows[i].main_sel_mem_op_b;
         polys.main_sel_mem_op_c[i] = rows[i].main_sel_mem_op_c;
         polys.main_sel_mem_op_d[i] = rows[i].main_sel_mem_op_d;

diff --git a/barretenberg/cpp/src/barretenberg/vm/avm/generated/circuit_builder.hpp b/barretenberg/cpp/src/barretenberg/vm/avm/generated/circuit_builder.hpp
@@ -20,8 +20,8 @@ class AvmCircuitBuilder {
     using Polynomial = Flavor::Polynomial;
     using ProverPolynomials = Flavor::ProverPolynomials;
 
-    static constexpr size_t num_fixed_columns = 704;
-    static constexpr size_t num_polys = 704 + 74;
+    static constexpr size_t num_fixed_columns = 703;
+    static constexpr size_t num_polys = 703 + 74;
     std::vector<Row> rows;
 
     void set_trace(std::vector<Row>&& trace) { rows = std::move(trace); }