Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[keys] Prevent registration of invalid keys #7515

Closed
nventuro opened this issue Jul 17, 2024 · 2 comments
Closed

[keys] Prevent registration of invalid keys #7515

nventuro opened this issue Jul 17, 2024 · 2 comments

Comments

@nventuro
Copy link
Contributor

nventuro commented Jul 17, 2024 •
edited by benesjan
Loading

We should disallow accounts from registering keys that are not valid points on the curve, since this is always a mistake that will result in notes not being created.

Look for "TODO(#7515)" in the codebase.
@github-project-automation github-project-automation bot moved this to Todo in A3 Jul 17, 2024
This was referenced Jul 19, 2024
Open
Closed
benesjan added a commit that referenced this issue Jul 23, 2024
@benesjan
linking issue #7515
2c0318a
@nventuro
Copy link
Contributor Author

Now that private storage slots are also points (with #7437), this consideration extends to them.

benesjan added a commit that referenced this issue Jul 24, 2024
@benesjan
linking issue #7515
943fe72
benesjan added a commit that referenced this issue Jul 24, 2024
@benesjan
linking issue #7515
81c0d71
benesjan added a commit that referenced this issue Jul 25, 2024
@benesjan
linking issue #7515
d1a3fa5
@nventuro
Copy link
Contributor Author

As of #8613 there's no more key registration.

@github-project-automation github-project-automation bot moved this from Todo to Done in A3 Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
A3
Archived in project
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nventuro