docs: making private refunds smooth-brain friendly #7343

benesjan · 2024-07-04T13:54:14Z

I've been going through the private refunds today and since it's all quite complex I decided to add more comments and clean that up

benesjan · 2024-07-04T13:54:28Z

fix: privacy leak in private refund #7358
docs: making private refunds smooth-brain friendly #7343 👈
master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @benesjan and the rest of your teammates on Graphite

AztecBot · 2024-07-04T14:33:48Z

Benchmark results

Metrics with a significant change:

proof_construction_time_sha256_30_ms (1): 13,865 (+17%)
proof_construction_time_sha256_30_ms (32): 1,651 (+17%)
avm_simulation_time_ms (Token:mint_public): 43.8 (-43%)
avm_simulation_time_ms (Token:transfer_public): 46.7 (+61%)
avm_simulation_time_ms (Token:_increase_public_balance): 52.7 (+254%)
protocol_circuit_proving_time_in_ms (private-kernel-init): 17,023 (+19%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Proof generation

Each column represents the number of threads used in proof generation.

Metric	1 threads	4 threads	16 threads	32 threads	64 threads
proof_construction_time_sha256_ms	5,713 (-1%)	1,556	703 (-1%)	750 (-1%)	775 (+1%)
proof_construction_time_sha256_30_ms	⚠️ 13,865 (+17%)	3,132 (-1%)	1,399	⚠️ 1,651 (+17%)	1,473
proof_construction_time_sha256_100_ms	46,405 (+6%)	11,713 (-1%)	5,392	5,373 (-1%)	5,339
proof_construction_time_poseidon_hash_ms	78.0 (-1%)	34.0	34.0	57.0 (-2%)	87.0
proof_construction_time_poseidon_hash_30_ms	1,515 (-1%)	414 (-1%)	200 (+1%)	220 (-4%)	265
proof_construction_time_poseidon_hash_100_ms	5,731 (-1%)	1,564 (-1%)	719	786 (+3%)	785 (-1%)

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	4 txs	8 txs	16 txs
l1_rollup_calldata_size_in_bytes	1,412	1,412	1,412
l1_rollup_calldata_gas	9,452	9,474	9,476
l1_rollup_execution_gas	611,191	611,364	611,517
l2_block_processing_time_in_ms	760 (+1%)	1,414	2,708 (-1%)
l2_block_building_time_in_ms	18,870	37,634 (+1%)	73,542
l2_block_rollup_simulation_time_in_ms	18,870	37,634 (+1%)	73,542
l2_block_public_tx_process_time_in_ms	16,080	34,651 (+1%)	70,615

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 8 txs.

Metric	3 blocks	5 blocks
node_history_sync_time_in_ms	7,040	9,855
node_database_size_in_bytes	12,443,728	16,207,952 (+1%)
pxe_database_size_in_bytes	16,254	26,813

Circuits stats

Stats on running time and I/O sizes collected for every kernel circuit run across all benchmarks.

Circuit	simulation_time_in_ms	witness_generation_time_in_ms	proving_time_in_ms	input_size_in_bytes	output_size_in_bytes	proof_size_in_bytes	num_public_inputs	size_in_gates
private-kernel-init	110 (+1%)	389 (-6%)	⚠️ 17,023 (+19%)	19,990	55,022	74,432	2,259	524,288
private-kernel-inner	220 (-1%)	800 (+14%)	28,408 (-6%)	82,090	55,022	74,432	2,259	1,048,576
private-kernel-tail	1,056	2,463 (-2%)	56,048 (+4%)	62,345	62,057	14,912	399	2,097,152
base-parity	6.06 (-2%)	1,282 (-1%)	2,635	128	64.0	2,208	2.00	131,072
root-parity	48.4 (-1%)	70.9 (+6%)	41,053 (+3%)	27,100	64.0	2,720	18.0	2,097,152
base-rollup	5,942 (+1%)	4,829 (-1%)	91,324	170,330	728	3,648	47.0	4,194,304
root-rollup	109 (-1%)	82.4 (+1%)	22,584 (-6%)	25,253	620	3,456	41.0	1,048,576
public-kernel-setup	439	2,327 (-3%)	41,467 (-2%)	102,121	80,278	106,912	3,274	2,097,152
public-kernel-app-logic	396 (+1%)	3,208 (-5%)	41,712 (-5%)	102,121	80,278	106,912	3,274	2,097,152
public-kernel-tail	1,133	26,494 (-2%)	178,812 (-1%)	399,014	10,014	14,912	399	8,388,608
private-kernel-reset-small	290	1,257 (-6%)	24,905 (-6%)	79,209	55,022	74,432	2,259	1,048,576
public-kernel-teardown	384	3,240 (-3%)	41,297 (-6%)	102,121	80,278	106,912	3,274	2,097,152
merge-rollup	29.0 (-1%)	N/A	N/A	16,486	728	N/A	N/A	N/A
private-kernel-tail-to-public	N/A	8,506	56,371 (-7%)	N/A	N/A	106,912	3,274	2,097,152

Stats on running time collected for app circuits

Function	input_size_in_bytes	output_size_in_bytes	witness_generation_time_in_ms	proof_size_in_bytes	proving_time_in_ms	size_in_gates	num_public_inputs
ContractClassRegisterer:register	1,344	9,364	394	N/A	N/A	N/A	N/A
ContractInstanceDeployer:deploy	1,408	9,364	24.5	N/A	N/A	N/A	N/A
MultiCallEntrypoint:entrypoint	1,920	9,364	640 (-2%)	N/A	N/A	N/A	N/A
GasToken:deploy	1,376	9,364	541 (-1%)	N/A	N/A	N/A	N/A
SchnorrAccount:constructor	1,312	9,364	470 (-3%)	N/A	N/A	N/A	N/A
SchnorrAccount:entrypoint	2,304	9,364	821	16,000	4,717 (-1%)	131,072	433
Token:privately_mint_private_note	1,280	9,364	524 (-3%)	N/A	N/A	N/A	N/A
FPC:fee_entrypoint_public	1,344	9,364	89.7 (-4%)	16,000	1,777 (+7%)	65,536	433
Token:transfer	1,312	9,364	1,611 (-1%)	16,000	11,713 (+1%)	524,288	433
AuthRegistry:set_authorized (avm)	19,226	N/A	N/A	91,264	1,364 (-2%)	N/A	N/A
FPC:prepare_fee (avm)	26,668	N/A	N/A	91,328	2,762 (-4%)	N/A	N/A
Token:transfer_public (avm)	42,918	N/A	N/A	91,328	3,931 (+1%)	N/A	N/A
AuthRegistry:consume (avm)	33,104	N/A	N/A	91,264	2,852 (-3%)	N/A	N/A
FPC:pay_refund (avm)	36,833	N/A	N/A	91,296	22,753 (-2%)	N/A	N/A
Benchmarking:create_note	1,344	9,364	464	N/A	N/A	N/A	N/A
SchnorrAccount:verify_private_authwit	1,280	9,364	40.9 (-1%)	N/A	N/A	N/A	N/A
Token:unshield	1,376	9,364	1,305 (-1%)	N/A	N/A	N/A	N/A
FPC:fee_entrypoint_private	1,376	9,364	1,699 (-7%)	N/A	N/A	N/A	N/A

AVM Simulation

Time to simulate various public functions in the AVM.

Function	time_ms	bytecode_size_in_bytes
GasToken:_increase_public_balance	68.8 (-6%)	13,790
GasToken:set_portal	12.8 (-15%)	3,339
Token:constructor	96.6 (+6%)	23,692
FPC:constructor	62.0 (+1%)	13,592
GasToken:mint_public	49.3 (-2%)	10,158
Token:mint_public	⚠️ 43.8 (-43%)	19,034
Token:assert_minter_and_mint	125 (-15%)	12,925
AuthRegistry:set_authorized	27.5 (-1%)	7,812
FPC:prepare_fee	110 (+2%)	15,062
Token:transfer_public	⚠️ 46.7 (+61%)	31,218
FPC:pay_refund	123 (-4%)	25,260
Benchmarking:increment_balance	1,974	15,267
Token:_increase_public_balance	⚠️ 52.7 (+254%)	15,006
FPC:pay_refund_with_shielded_rebate	115 (-24%)	26,347

Public DB Access

Time to access various public DBs.

Function	time_ms
get-nullifier-index	0.154

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	16 leaves	64 leaves	128 leaves	256 leaves	512 leaves	1024 leaves
batch_insert_into_append_only_tree_16_depth_ms	10.4	16.8	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.8	31.7	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.599	0.516	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	47.9 (-1%)	75.9	132	245	473 (-1%)
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	95.9	159	287	543	1,055
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	0.490 (-1%)	0.467	0.454	0.444	0.442 (-1%)
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	59.3	112	183 (-1%)	352	696 (-1%)
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	109	207	355	691	1,363
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	0.501	0.503 (+1%)	0.486	0.477	0.478
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	72.5	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	133	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	0.516	N/A	N/A	N/A	N/A

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric	0 registered classes	1 registered classes
tx_size_in_bytes	74,057	667,841

Transaction size based on fee payment method

| Metric | |
| - | |

noir-projects/noir-contracts/contracts/private_fpc_contract/src/main.nr

noir-projects/noir-contracts/contracts/private_token_contract/src/types/token_note.nr

yarn-project/end-to-end/src/e2e_fees/account_init.test.ts

github-actions · 2024-07-05T09:00:44Z

Changes to circuit sizes

Generated at commit: 61f7005d2960dadcb18116b798a74c61b007d430, compared to commit: 586c0b019d0c2c462188f03c9c31d25a46e35eb6

🧾 Summary (100% most significant diffs)

Program	ACIR opcodes (+/-)	%	Circuit size (+/-)	%
public_kernel_setup	-645 ✅	-0.35%	-147,288 ✅	-10.04%
public_kernel_teardown	-1,642 ✅	-0.68%	-279,863 ✅	-16.82%
public_kernel_app_logic	-1,640 ✅	-0.68%	-279,861 ✅	-16.83%

Full diff report 👇

Program	ACIR opcodes (+/-)	%	Circuit size (+/-)	%
public_kernel_setup	182,710 (-645)	-0.35%	1,319,393 (-147,288)	-10.04%
public_kernel_teardown	241,237 (-1,642)	-0.68%	1,383,582 (-279,863)	-16.82%
public_kernel_app_logic	241,041 (-1,640)	-0.68%	1,383,344 (-279,861)	-16.83%

LHerskind

The maths are super broken 😬
It is not ok to use generators as they are used here. But can see that #7320 exists for that, so this seem to more be description, but description needs to be updated along with the changes to make it understandable and not as broken as it is currently (#7319).

Based on this PR not trying to fix any of the brokenness but add more description I think it in itself is ok, but looking forward to see it being fixed 😭

LHerskind · 2024-07-05T11:45:19Z

noir-projects/aztec-nr/aztec/src/note/utils.nr

@@ -9,14 +9,18 @@ use dep::protocol_types::{
    utils::arr_copy_slice
 };

+pub fn compute_inner_note_hash_from_preimage(storage_slot: Field, note_content_hash: Field) -> Field {


The name here is slightly odd to me as it is always a pre-image, but here I would think it would be the note preimage 🤷

I don't know how else to call this but I am open to suggestions 😜

Maybe silo_note_content_hash_to_storage_slot?

That doesn't tell you that the return value is what we call inner_note_hash in our terminology and I think it's important to emphasize these terms to not get lost in all the hashing.

LHerskind · 2024-07-05T12:39:34Z

noir-projects/noir-contracts/contracts/private_fpc_contract/src/lib.nr

@@ -3,13 +3,13 @@ use dep::aztec::oracle::logs::emit_unencrypted_log_private_internal;
 use dep::aztec::hash::compute_unencrypted_log_hash;
 use dep::aztec::context::PrivateContext;

-fn emit_nonce_as_unencrypted_log(context: &mut PrivateContext, nonce: Field) {
+fn emit_randomness_as_unencrypted_log(context: &mut PrivateContext, randomness: Field) {


👁️ 🥄

This is a consequence of the function being nuked from private context in your PR 😬 Not really sure what to do about this. Maybe we could move the original function to a danger.nr file in aztec-nr?

noir-projects/noir-contracts/contracts/private_token_contract/src/main.nr

LHerskind · 2024-07-05T14:26:50Z

noir-projects/noir-contracts/contracts/private_token_contract/src/main.nr

        );
+
+        // 5. Set the public teardown function to `complete_refund(...)`. Public teardown is the only time when a public


Me being slightly ignorant around fees. Is anything stopping me from calling set_public_teardown_function multiple times? Is there a point wherein it must have been set? @just-mitch.

Namely here thinking about the case where it is updated in a later call 👀 Would the complete_refund then simply not be executed?

Yes, there is a check in noir-projects/noir-protocol-circuits/crates/private-kernel-lib/src/components/private_kernel_circuit_output_validator.nr that ensures you cannot overwrite the teardown function; attempts to do so will cause the kernel to fail.

LHerskind · 2024-07-05T14:32:35Z

noir-projects/noir-contracts/contracts/private_token_contract/src/main.nr

        user_point_x: Field,
        user_point_y: Field
    ) {
-        let fpc_point = EmbeddedCurvePoint { x: fpc_point_x, y: fpc_point_y, is_infinite: false };
+        // 1. We get the final note content hashes by calling the `complete_refund` on the note.
+        let fee_payer_point = EmbeddedCurvePoint { x: fee_payer_point_x, y: fee_payer_point_y, is_infinite: false };
        let user_point = EmbeddedCurvePoint { x: user_point_x, y: user_point_y, is_infinite: false };
        let tx_fee = context.transaction_fee();


More ignorance from my side. But when computing the fee at this point, you will not include the insertions that happen later here or any of the compute. Does the FPC end up paying for those and then the user underpays here, or 👀? @just-mitch

The teardown phase is special in that the user pre-pays for the gas consumed. So the user specifies:

DA/L2 gas limit

teardown DA/L2 gas limit (which is a subset of the above)

Then the AVM starts teardown with the teardown limits set as start gas. So really the FPC needs to be checking in setup that the amount specified for teardown is sufficient to make sure it doesn't run OOG, but regardless context.transaction_fee() is always exclusive of what is actually done in teardown, as long as we don't run out of gas.

So yes, in effect, the FPC could overpay if the teardown limit is too high, but they ought to be charging the user for that overpayment.

noir-projects/noir-contracts/contracts/private_token_contract/src/types/token_note.nr

yarn-project/end-to-end/src/e2e_fees/private_refunds.test.ts

benesjan · 2024-07-05T15:28:18Z

@LHerskind will address your comments in a PR on top of the stack to avoid conflicts.

* master: (176 commits) refactor: counters (#7342) chore: notify Noir team on changes to the stdlib (#7387) chore(bb): do not instantiate Relation (#7389) chore(avm): avoid including flavor where possible (#7361) chore(avm): better log_derivative_inverse_round (#7360) chore(avm): smaller prover (#7359) chore(avm): smaller transcript (#7357) feat: Sync from noir (#7352) feat: VK tree (#6914) chore(docs): Update token tutorial (#7241) chore: sync external contributions (#6984) fix: privacy leak in private refund (#7358) fix: included argshash computation in public call_interfaces and cleanup (#7354) docs: making private refunds smooth-brain friendly (#7343) refactor: optimize public call stack item hashing (#7330) fix: Allow importing notes from other contracts and inject them in the macros (#7349) refactor: Optimize private call stack item hash for gate count (#7285) git subrepo push --branch=master noir-projects/aztec-nr git_subrepo.sh: Fix parent in .gitrepo file. [skip ci] chore: replace relative paths to noir-protocol-circuits ...

🤖 I have created a release *beep* *boop* --- <details><summary>aztec-package: 0.46.0</summary> ## [0.46.0](aztec-package-v0.45.1...aztec-package-v0.46.0) (2024-07-09) ### Features * VK tree ([#6914](#6914)) ([8631237](8631237)) </details> <details><summary>barretenberg.js: 0.46.0</summary> ## [0.46.0](barretenberg.js-v0.45.1...barretenberg.js-v0.46.0) (2024-07-09) ### Miscellaneous * **barretenberg.js:** Synchronize aztec-packages versions </details> <details><summary>aztec-packages: 0.46.0</summary> ## [0.46.0](aztec-packages-v0.45.1...aztec-packages-v0.46.0) (2024-07-09) ### ⚠ BREAKING CHANGES * constant inputs for blackbox ([#7222](#7222)) ### Features * Add more slice methods to the stdlib (noir-lang/noir#5424) ([6137a10](6137a10)) * Constant inputs for blackbox ([#7222](#7222)) ([9f9ded2](9f9ded2)) * Detect subgraphs that are completely independent from inputs or outputs (noir-lang/noir#5402) ([c7b1ae4](c7b1ae4)) * Lsp "go to definition" for modules (noir-lang/noir#5406) ([c7b1ae4](c7b1ae4)) * Lsp rename/find-all-references for traits (noir-lang/noir#5409) ([c7b1ae4](c7b1ae4)) * Lsp rename/find-all-references for type aliases (noir-lang/noir#5414) ([6137a10](6137a10)) * Sync from aztec-packages (noir-lang/noir#5408) ([c7b1ae4](c7b1ae4)) * Sync from aztec-packages (noir-lang/noir#5432) ([6137a10](6137a10)) * TXE docs and usability ([#7305](#7305)) ([6b2a351](6b2a351)) * Unquote multiple items from annotations (noir-lang/noir#5441) ([6137a10](6137a10)) * VK tree ([#6914](#6914)) ([8631237](8631237)) ### Bug Fixes * Allow importing notes from other contracts and inject them in the macros ([#7349](#7349)) ([586c0b0](586c0b0)) * Change panic to error in interpreter (noir-lang/noir#5446) ([6137a10](6137a10)) * Complete call stacks with no_predicates (noir-lang/noir#5418) ([c7b1ae4](c7b1ae4)) * Correct range for overlfowing/underflowing integer assignment (noir-lang/noir#5416) ([c7b1ae4](c7b1ae4)) * Included argshash computation in public call_interfaces and cleanup ([#7354](#7354)) ([13e9b94](13e9b94)) * Lsp find struct reference in return locations and paths (noir-lang/noir#5404) ([c7b1ae4](c7b1ae4)) * Lsp struct rename/reference difference (noir-lang/noir#5411) ([6137a10](6137a10)) * Privacy leak in private refund ([#7358](#7358)) ([e05f6f0](e05f6f0)), closes [#7321](#7321) ### Miscellaneous * Add remaining slice methods to the interpreter (noir-lang/noir#5422) ([c7b1ae4](c7b1ae4)) * Add test and benchmarks for poseidon2 (noir-lang/noir#5386) ([c7b1ae4](c7b1ae4)) * **avm:** Avoid including flavor where possible ([#7361](#7361)) ([dbdffd6](dbdffd6)) * **avm:** Better log_derivative_inverse_round ([#7360](#7360)) ([6329833](6329833)) * **avm:** Smaller prover ([#7359](#7359)) ([7d8c833](7d8c833)) * **avm:** Smaller transcript ([#7357](#7357)) ([3952a44](3952a44)) * **bb:** Do not instantiate Relation ([#7389](#7389)) ([d9cbf4c](d9cbf4c)) * Counters ([#7342](#7342)) ([819f370](819f370)) * **docs:** Fix link to docker ([#7395](#7395)) ([ad4a401](ad4a401)) * **docs:** Update token tutorial ([#7241](#7241)) ([0414eb5](0414eb5)) * Dummy workflow (noir-lang/noir#5438) ([6137a10](6137a10)) * Extracts refactoring of reading error payloads from [#5403](#5403) (noir-lang/noir#5413) ([6137a10](6137a10)) * Generate declaration files for VKs ([#7391](#7391)) ([7c96636](7c96636)) * Merge `BarretenbergVerifierBackend` and `BarretenbergBackend` (noir-lang/noir#5399) ([6137a10](6137a10)) * Move SSA checks to a new folder (noir-lang/noir#5434) ([6137a10](6137a10)) * Notify Noir team on changes to the stdlib ([#7387](#7387)) ([061aac3](061aac3)) * Optimize private call stack item hash for gate count ([#7285](#7285)) ([783d9b6](783d9b6)) * Optimize public call stack item hashing ([#7330](#7330)) ([4a5093c](4a5093c)) * Refactor logic around inlining `no_predicates` functions (noir-lang/noir#5433) ([6137a10](6137a10)) * Replace relative paths to noir-protocol-circuits ([8510269](8510269)) * Replace relative paths to noir-protocol-circuits ([9eb8d1c](9eb8d1c)) * Sync external contributions ([#6984](#6984)) ([a265b29](a265b29)) ### Documentation * Making private refunds smooth-brain friendly ([#7343](#7343)) ([533c937](533c937)) * Update overview.md (fix link text) ([#7344](#7344)) ([79e5856](79e5856)) </details> <details><summary>barretenberg: 0.46.0</summary> ## [0.46.0](barretenberg-v0.45.1...barretenberg-v0.46.0) (2024-07-09) ### ⚠ BREAKING CHANGES * constant inputs for blackbox ([#7222](#7222)) ### Features * Constant inputs for blackbox ([#7222](#7222)) ([9f9ded2](9f9ded2)) ### Miscellaneous * **avm:** Avoid including flavor where possible ([#7361](#7361)) ([dbdffd6](dbdffd6)) * **avm:** Better log_derivative_inverse_round ([#7360](#7360)) ([6329833](6329833)) * **avm:** Smaller prover ([#7359](#7359)) ([7d8c833](7d8c833)) * **avm:** Smaller transcript ([#7357](#7357)) ([3952a44](3952a44)) * **bb:** Do not instantiate Relation ([#7389](#7389)) ([d9cbf4c](d9cbf4c)) * Counters ([#7342](#7342)) ([819f370](819f370)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

🤖 I have created a release *beep* *boop* --- <details><summary>aztec-package: 0.46.0</summary> ## [0.46.0](AztecProtocol/aztec-packages@aztec-package-v0.45.1...aztec-package-v0.46.0) (2024-07-09) ### Features * VK tree ([#6914](AztecProtocol/aztec-packages#6914)) ([8631237](AztecProtocol/aztec-packages@8631237)) </details> <details><summary>barretenberg.js: 0.46.0</summary> ## [0.46.0](AztecProtocol/aztec-packages@barretenberg.js-v0.45.1...barretenberg.js-v0.46.0) (2024-07-09) ### Miscellaneous * **barretenberg.js:** Synchronize aztec-packages versions </details> <details><summary>aztec-packages: 0.46.0</summary> ## [0.46.0](AztecProtocol/aztec-packages@aztec-packages-v0.45.1...aztec-packages-v0.46.0) (2024-07-09) ### ⚠ BREAKING CHANGES * constant inputs for blackbox ([#7222](AztecProtocol/aztec-packages#7222)) ### Features * Add more slice methods to the stdlib (noir-lang/noir#5424) ([6137a10](AztecProtocol/aztec-packages@6137a10)) * Constant inputs for blackbox ([#7222](AztecProtocol/aztec-packages#7222)) ([9f9ded2](AztecProtocol/aztec-packages@9f9ded2)) * Detect subgraphs that are completely independent from inputs or outputs (noir-lang/noir#5402) ([c7b1ae4](AztecProtocol/aztec-packages@c7b1ae4)) * Lsp "go to definition" for modules (noir-lang/noir#5406) ([c7b1ae4](AztecProtocol/aztec-packages@c7b1ae4)) * Lsp rename/find-all-references for traits (noir-lang/noir#5409) ([c7b1ae4](AztecProtocol/aztec-packages@c7b1ae4)) * Lsp rename/find-all-references for type aliases (noir-lang/noir#5414) ([6137a10](AztecProtocol/aztec-packages@6137a10)) * Sync from aztec-packages (noir-lang/noir#5408) ([c7b1ae4](AztecProtocol/aztec-packages@c7b1ae4)) * Sync from aztec-packages (noir-lang/noir#5432) ([6137a10](AztecProtocol/aztec-packages@6137a10)) * TXE docs and usability ([#7305](AztecProtocol/aztec-packages#7305)) ([6b2a351](AztecProtocol/aztec-packages@6b2a351)) * Unquote multiple items from annotations (noir-lang/noir#5441) ([6137a10](AztecProtocol/aztec-packages@6137a10)) * VK tree ([#6914](AztecProtocol/aztec-packages#6914)) ([8631237](AztecProtocol/aztec-packages@8631237)) ### Bug Fixes * Allow importing notes from other contracts and inject them in the macros ([#7349](AztecProtocol/aztec-packages#7349)) ([586c0b0](AztecProtocol/aztec-packages@586c0b0)) * Change panic to error in interpreter (noir-lang/noir#5446) ([6137a10](AztecProtocol/aztec-packages@6137a10)) * Complete call stacks with no_predicates (noir-lang/noir#5418) ([c7b1ae4](AztecProtocol/aztec-packages@c7b1ae4)) * Correct range for overlfowing/underflowing integer assignment (noir-lang/noir#5416) ([c7b1ae4](AztecProtocol/aztec-packages@c7b1ae4)) * Included argshash computation in public call_interfaces and cleanup ([#7354](AztecProtocol/aztec-packages#7354)) ([13e9b94](AztecProtocol/aztec-packages@13e9b94)) * Lsp find struct reference in return locations and paths (noir-lang/noir#5404) ([c7b1ae4](AztecProtocol/aztec-packages@c7b1ae4)) * Lsp struct rename/reference difference (noir-lang/noir#5411) ([6137a10](AztecProtocol/aztec-packages@6137a10)) * Privacy leak in private refund ([#7358](AztecProtocol/aztec-packages#7358)) ([e05f6f0](AztecProtocol/aztec-packages@e05f6f0)), closes [#7321](AztecProtocol/aztec-packages#7321) ### Miscellaneous * Add remaining slice methods to the interpreter (noir-lang/noir#5422) ([c7b1ae4](AztecProtocol/aztec-packages@c7b1ae4)) * Add test and benchmarks for poseidon2 (noir-lang/noir#5386) ([c7b1ae4](AztecProtocol/aztec-packages@c7b1ae4)) * **avm:** Avoid including flavor where possible ([#7361](AztecProtocol/aztec-packages#7361)) ([dbdffd6](AztecProtocol/aztec-packages@dbdffd6)) * **avm:** Better log_derivative_inverse_round ([#7360](AztecProtocol/aztec-packages#7360)) ([6329833](AztecProtocol/aztec-packages@6329833)) * **avm:** Smaller prover ([#7359](AztecProtocol/aztec-packages#7359)) ([7d8c833](AztecProtocol/aztec-packages@7d8c833)) * **avm:** Smaller transcript ([#7357](AztecProtocol/aztec-packages#7357)) ([3952a44](AztecProtocol/aztec-packages@3952a44)) * **bb:** Do not instantiate Relation ([#7389](AztecProtocol/aztec-packages#7389)) ([d9cbf4c](AztecProtocol/aztec-packages@d9cbf4c)) * Counters ([#7342](AztecProtocol/aztec-packages#7342)) ([819f370](AztecProtocol/aztec-packages@819f370)) * **docs:** Fix link to docker ([#7395](AztecProtocol/aztec-packages#7395)) ([ad4a401](AztecProtocol/aztec-packages@ad4a401)) * **docs:** Update token tutorial ([#7241](AztecProtocol/aztec-packages#7241)) ([0414eb5](AztecProtocol/aztec-packages@0414eb5)) * Dummy workflow (noir-lang/noir#5438) ([6137a10](AztecProtocol/aztec-packages@6137a10)) * Extracts refactoring of reading error payloads from [#5403](AztecProtocol/aztec-packages#5403) (noir-lang/noir#5413) ([6137a10](AztecProtocol/aztec-packages@6137a10)) * Generate declaration files for VKs ([#7391](AztecProtocol/aztec-packages#7391)) ([7c96636](AztecProtocol/aztec-packages@7c96636)) * Merge `BarretenbergVerifierBackend` and `BarretenbergBackend` (noir-lang/noir#5399) ([6137a10](AztecProtocol/aztec-packages@6137a10)) * Move SSA checks to a new folder (noir-lang/noir#5434) ([6137a10](AztecProtocol/aztec-packages@6137a10)) * Notify Noir team on changes to the stdlib ([#7387](AztecProtocol/aztec-packages#7387)) ([061aac3](AztecProtocol/aztec-packages@061aac3)) * Optimize private call stack item hash for gate count ([#7285](AztecProtocol/aztec-packages#7285)) ([783d9b6](AztecProtocol/aztec-packages@783d9b6)) * Optimize public call stack item hashing ([#7330](AztecProtocol/aztec-packages#7330)) ([4a5093c](AztecProtocol/aztec-packages@4a5093c)) * Refactor logic around inlining `no_predicates` functions (noir-lang/noir#5433) ([6137a10](AztecProtocol/aztec-packages@6137a10)) * Replace relative paths to noir-protocol-circuits ([8510269](AztecProtocol/aztec-packages@8510269)) * Replace relative paths to noir-protocol-circuits ([9eb8d1c](AztecProtocol/aztec-packages@9eb8d1c)) * Sync external contributions ([#6984](AztecProtocol/aztec-packages#6984)) ([a265b29](AztecProtocol/aztec-packages@a265b29)) ### Documentation * Making private refunds smooth-brain friendly ([#7343](AztecProtocol/aztec-packages#7343)) ([533c937](AztecProtocol/aztec-packages@533c937)) * Update overview.md (fix link text) ([#7344](AztecProtocol/aztec-packages#7344)) ([79e5856](AztecProtocol/aztec-packages@79e5856)) </details> <details><summary>barretenberg: 0.46.0</summary> ## [0.46.0](AztecProtocol/aztec-packages@barretenberg-v0.45.1...barretenberg-v0.46.0) (2024-07-09) ### ⚠ BREAKING CHANGES * constant inputs for blackbox ([#7222](AztecProtocol/aztec-packages#7222)) ### Features * Constant inputs for blackbox ([#7222](AztecProtocol/aztec-packages#7222)) ([9f9ded2](AztecProtocol/aztec-packages@9f9ded2)) ### Miscellaneous * **avm:** Avoid including flavor where possible ([#7361](AztecProtocol/aztec-packages#7361)) ([dbdffd6](AztecProtocol/aztec-packages@dbdffd6)) * **avm:** Better log_derivative_inverse_round ([#7360](AztecProtocol/aztec-packages#7360)) ([6329833](AztecProtocol/aztec-packages@6329833)) * **avm:** Smaller prover ([#7359](AztecProtocol/aztec-packages#7359)) ([7d8c833](AztecProtocol/aztec-packages@7d8c833)) * **avm:** Smaller transcript ([#7357](AztecProtocol/aztec-packages#7357)) ([3952a44](AztecProtocol/aztec-packages@3952a44)) * **bb:** Do not instantiate Relation ([#7389](AztecProtocol/aztec-packages#7389)) ([d9cbf4c](AztecProtocol/aztec-packages@d9cbf4c)) * Counters ([#7342](AztecProtocol/aztec-packages#7342)) ([819f370](AztecProtocol/aztec-packages@819f370)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

just-mitch

Thank you for the cleanup @benesjan !

just-mitch · 2024-07-10T10:17:59Z

noir-projects/aztec-nr/aztec/src/note/utils.nr

@@ -9,14 +9,18 @@ use dep::protocol_types::{
    utils::arr_copy_slice
 };

+pub fn compute_inner_note_hash_from_preimage(storage_slot: Field, note_content_hash: Field) -> Field {


Maybe silo_note_content_hash_to_storage_slot?

just-mitch · 2024-07-10T10:22:06Z

noir-projects/noir-contracts/contracts/private_token_contract/src/main.nr

        );
+
+        // 5. Set the public teardown function to `complete_refund(...)`. Public teardown is the only time when a public


Yes, there is a check in noir-projects/noir-protocol-circuits/crates/private-kernel-lib/src/components/private_kernel_circuit_output_validator.nr that ensures you cannot overwrite the teardown function; attempts to do so will cause the kernel to fail.

just-mitch · 2024-07-10T10:26:35Z

noir-projects/noir-contracts/contracts/private_token_contract/src/main.nr

        user_point_x: Field,
        user_point_y: Field
    ) {
-        let fpc_point = EmbeddedCurvePoint { x: fpc_point_x, y: fpc_point_y, is_infinite: false };
+        // 1. We get the final note content hashes by calling the `complete_refund` on the note.
+        let fee_payer_point = EmbeddedCurvePoint { x: fee_payer_point_x, y: fee_payer_point_y, is_infinite: false };
        let user_point = EmbeddedCurvePoint { x: user_point_x, y: user_point_y, is_infinite: false };
        let tx_fee = context.transaction_fee();


The teardown phase is special in that the user pre-pays for the gas consumed. So the user specifies:

DA/L2 gas limit

teardown DA/L2 gas limit (which is a subset of the above)

Then the AVM starts teardown with the teardown limits set as start gas. So really the FPC needs to be checking in setup that the amount specified for teardown is sufficient to make sure it doesn't run OOG, but regardless context.transaction_fee() is always exclusive of what is actually done in teardown, as long as we don't run out of gas.

So yes, in effect, the FPC could overpay if the teardown limit is too high, but they ought to be charging the user for that overpayment.

benesjan commented Jul 4, 2024

View reviewed changes

noir-projects/noir-contracts/contracts/private_fpc_contract/src/main.nr Show resolved Hide resolved

benesjan commented Jul 4, 2024

View reviewed changes

noir-projects/noir-contracts/contracts/private_token_contract/src/types/token_note.nr Show resolved Hide resolved

benesjan commented Jul 4, 2024

View reviewed changes

yarn-project/end-to-end/src/e2e_fees/account_init.test.ts Show resolved Hide resolved

benesjan force-pushed the 07-04-docs_making_private_refunds_smooth-brain_friendly branch from c2c0ee4 to ac14883 Compare July 4, 2024 16:03

benesjan marked this pull request as ready for review July 4, 2024 16:20

benesjan requested a review from LHerskind July 4, 2024 16:32

benesjan force-pushed the 07-04-docs_making_private_refunds_smooth-brain_friendly branch 2 times, most recently from 52d3694 to 1413db5 Compare July 5, 2024 08:53

benesjan added 10 commits July 5, 2024 10:29

docs: making private refunds smooth-brain friendly

de88875

WIP

5b379b8

WIP

ab73854

WIP

0449314

randomness instead of nonce

25e560a

WIP

ce57c29

fix: naming inconsistencies

472d225

WIP

795cc7a

WIP

7ec707f

WIP

18c5d22

benesjan force-pushed the 07-04-docs_making_private_refunds_smooth-brain_friendly branch from 1413db5 to 18c5d22 Compare July 5, 2024 10:29

benesjan mentioned this pull request Jul 5, 2024

fix: privacy leak in private refund #7358

Merged

LHerskind approved these changes Jul 5, 2024

View reviewed changes

benesjan merged commit 533c937 into master Jul 5, 2024
91 checks passed

benesjan deleted the 07-04-docs_making_private_refunds_smooth-brain_friendly branch July 5, 2024 15:28

AztecBot mentioned this pull request Jul 5, 2024

chore(master): Release 0.46.0 #7345

Merged

benesjan mentioned this pull request Jul 8, 2024

refactor: replace usage of GrumpkinPoint with EmbeddedCurvePoint #7382

Merged

benesjan mentioned this pull request Jul 10, 2024

refactor: private refund cleanup #7403

Merged

just-mitch reviewed Jul 10, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

docs: making private refunds smooth-brain friendly #7343

docs: making private refunds smooth-brain friendly #7343

benesjan commented Jul 4, 2024 •

edited

Loading

benesjan commented Jul 4, 2024 •

edited

Loading

AztecBot commented Jul 4, 2024 •

edited

Loading

Proof generation

L2 block published to L1

L2 chain processing

Circuits stats

AVM Simulation

Public DB Access

Tree insertion stats

Miscellaneous

github-actions bot commented Jul 5, 2024 •

edited

Loading

LHerskind left a comment

LHerskind Jul 5, 2024

benesjan Jul 10, 2024

just-mitch Jul 10, 2024

benesjan Jul 10, 2024

LHerskind Jul 5, 2024

benesjan Jul 10, 2024 •

edited

Loading

LHerskind Jul 5, 2024

just-mitch Jul 10, 2024

LHerskind Jul 5, 2024

just-mitch Jul 10, 2024

benesjan commented Jul 5, 2024

just-mitch left a comment

just-mitch Jul 10, 2024

just-mitch Jul 10, 2024

just-mitch Jul 10, 2024

		);

		// 5. Set the public teardown function to `complete_refund(...)`. Public teardown is the only time when a public

docs: making private refunds smooth-brain friendly #7343

docs: making private refunds smooth-brain friendly #7343

Conversation

benesjan commented Jul 4, 2024 • edited Loading

benesjan commented Jul 4, 2024 • edited Loading

AztecBot commented Jul 4, 2024 • edited Loading

Benchmark results

Proof generation

L2 block published to L1

L2 chain processing

Circuits stats

AVM Simulation

Public DB Access

Tree insertion stats

Miscellaneous

github-actions bot commented Jul 5, 2024 • edited Loading

Changes to circuit sizes

🧾 Summary (100% most significant diffs)

LHerskind left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

benesjan Jul 10, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

benesjan commented Jul 5, 2024

just-mitch left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

benesjan commented Jul 4, 2024 •

edited

Loading

benesjan commented Jul 4, 2024 •

edited

Loading

AztecBot commented Jul 4, 2024 •

edited

Loading

github-actions bot commented Jul 5, 2024 •

edited

Loading

benesjan Jul 10, 2024 •

edited

Loading