Split public and private/unconstrained storage read oracles #7230
Assignees
Comments
This was referenced Jun 27, 2024
nventuro
added a commit
that referenced
this issue
Jun 28, 2024
Part of #7230. This splits the storage access oracles that transpile into opcodes, and the ones that are resolved as actual oracle calls by PXE. I took the liberty to introduce some slight improvements, such as removing unused `length` params, write return values, and making the default fns call serialize and deserialize, mirroring the actual usage they had throughout our codebase and cleaning up the callsites. The oracle improvements proposed in #7230 (taking arbitrary addresses and block number) will come in a separate PR, as those require further changes to PXE etc.
AztecBot
pushed a commit
to AztecProtocol/aztec-nr
that referenced
this issue
Jun 29, 2024
Part of AztecProtocol/aztec-packages#7230. This splits the storage access oracles that transpile into opcodes, and the ones that are resolved as actual oracle calls by PXE. I took the liberty to introduce some slight improvements, such as removing unused `length` params, write return values, and making the default fns call serialize and deserialize, mirroring the actual usage they had throughout our codebase and cleaning up the callsites. The oracle improvements proposed in #7230 (taking arbitrary addresses and block number) will come in a separate PR, as those require further changes to PXE etc.
AztecBot
pushed a commit
to AztecProtocol/aztec-nr
that referenced
this issue
Jun 29, 2024
… (#7243) Follow up to #7237, closes AztecProtocol/aztec-packages#7230. I only changed the oracles and not the PXE interface to keep this change as small as possible. I did change the node interface, but made it so you can still do it the old way by passing `'latest'`, which I had to do in a couple places. Finally, I added getters for `UnconstrainedContext`, mirroring the work in #7320, which I imagine are the ones we'll use in the vast majority of cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We currently have a single
storage_read(storage_slot)oracle, called in all three environments. In public however the oracle is not actually called, and is instead transpiled into multiplesloadopcodes. This is quite confusing.On top of that, #7169 requires for the private/unconstrained
storage_readoracle to also receive an address instead of using the one of the contract being executed, so this is a good opportunity to add this feature.The text was updated successfully, but these errors were encountered: