Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Keys_Viewing): Make AES available in noir #5866

Closed
Tracked by #5606
LHerskind opened this issue Apr 19, 2024 · 1 comment · Fixed by #6016
Closed
Tracked by #5606

feat(Keys_Viewing): Make AES available in noir #5866

LHerskind opened this issue Apr 19, 2024 · 1 comment · Fixed by #6016
Assignees

Comments

@LHerskind
Copy link
Contributor

LHerskind commented Apr 19, 2024

For the note encryption we need to have some encryption decryption available. As it looks atm, we will be using AES, so we need to have some AES implementation available.

BB already have an implementation so ideally we can simply expose that as a blackbox function, otherwise we need an implementation in pure noir.

We would very much want not do have the pure noir as it would be a pain to broadcast vs few calls to blackbox functions.

@Savio-Sou
Copy link
Member

FWIW there was a community implementation in pure Noir: https://github.com/TaceoLabs/noir-aes
But I believe Mike mentioned it not being (sufficiently) performant.

If we already have a good implementation in barretenberg we certainly should blackbox it 👍

Thunkar added a commit that referenced this issue May 7, 2024
Closes #5866

Adds AES128 as a blackbox function, exposing the existing functionality
from barretenberg.

Data is padded using PKCS#7

---------

Co-authored-by: Tom French <[email protected]>
@github-project-automation github-project-automation bot moved this from Todo to Done in A3 May 7, 2024
AztecBot pushed a commit to AztecProtocol/barretenberg that referenced this issue May 8, 2024
Closes AztecProtocol/aztec-packages#5866

Adds AES128 as a blackbox function, exposing the existing functionality
from barretenberg.

Data is padded using PKCS#7

---------

Co-authored-by: Tom French <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants