AVM: cleanup simulator

[dbanks12]

Journal

• Rename journal file to match class name. Rename all instances of journal.
• Rename flush function to be more meaningful (and JournalData type) (do we even need this function & type?)
• Make any members private that can be made so
• Add max-array checks in trace class (AVM: limit max state accesses / side-effects in simulator #4805)
• Consider whether CallPointer and EndLifetime belong in trace at this stage
• Remove transitional logic (eventually)
• What needs to be tracked in a trace array vs journal array?
• Split nullifier checks into non-existent and existent
• Add L2ToL1Message read requests to PublicExecutionResult and public kernel
• Rename Nullifiers type (bad name)
• Stop committing to public storage DB in executor.ts and make stateManager's publicStorage private

Contracts and tests

• Clean up regexes testing for duplicate nullifiers (chore(test-contracts): prepare e2e_token_contract+ error msgs for AVM migration #6307)
• Clean up regexes in yarn-project/end-to-end/src/e2e_block_building.test.ts
• Remove state variable impls for AvmContext (AVM: cleanup simulator #5818)
• Clean up regexes yarn-project/end-to-end/src/e2e_deploy_contract/contract_class_registration.test.ts
• Clean up regexes yarn-project/end-to-end/src/e2e_cross_chain_messaging.test.ts
• Clean up changes from chore: change some error messages for avm switch #6447.
• Clean up tests yarn-project/end-to-end/src/e2e_static_calls.test.ts
• See if we can clean up/simplify noir-projects/aztec-nr/aztec/src/initializer.nr
• simulator test should work with different address vs storageAddress

AvmContextInputs

• Decide if we'll want it long term or not (we don't)
• Remove 'selector' and create opcode?
• Remove 'is_static' and create opcode?
• Remove args_hash? Do this in Noir in the macros?

Transition-related

• Clean up noir macros
• Remove public_execution_context
• Clean up ACVM stuff in executor.ts and abstract_phase_manager
• Cleanup/simplify interaction of PublicExecution(Result) inside the simulator and in executor.ts and abstract_phase_manager
• Remove transitional_adaptors
• Remove AVM_MAGIC_SUFFIX and related (from transpiler as well) (not removing)
• Clean up ACIR public simulator tests in simulator/public
• Clean up (Public)ContextInterfaces

Misc

• AVM: fix instruction -> AvmContext -> decodeFromBytecode dependency cycle in simulator #4359
• re-group instructions into files that match YP categories (rename when necessary)
• rename avm_message_call_results file
• types in transpile_contract.rs should be renamed to match their corresponding names in nargo/src/artifacts/{program.rs,contract.rs} (or to just import the types themselves instead of recreating them - but they might not be exported)
• can transpiler ever actually encounter a Const with bit_size: 254, or can we remove that special case?
• Gas handling could use a simplification
• Update references to AvmContext in docs/docs/protocol-specs/public-vm/context.mdx
• Consider removing header from the environment: feat(avm): add Header to AvmExecutionEnvironment #5592

[dbanks12]

@fcarreiro pinging you so you're aware this ticket exists. We can probably knock many of these out in a single PR. Some of them I have procrastinated on for a while.

We might want to make this ticket more general to "simulator cleanup" or make another such ticket to track simulator cleanup tasks.