Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Get rid of ECCVM composer #5562

Merged
merged 16 commits into from
Apr 8, 2024
Merged

Conversation

codygunton
Copy link
Contributor

@codygunton codygunton commented Apr 3, 2024

Get rid of the ECCVM composer, following the model of #5202

@codygunton codygunton force-pushed the cg/nix_eccvm_composer_2 branch from 30fa31b to 9266334 Compare April 3, 2024 18:35
@codygunton codygunton self-assigned this Apr 3, 2024
@AztecBot
Copy link
Collaborator

AztecBot commented Apr 3, 2024

Benchmark results

No metrics with a significant change found.

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Values are compared against data from master at commit a974ec82 and shown if the difference exceeds 1%.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric 8 txs 32 txs 64 txs
l1_rollup_calldata_size_in_bytes 676 676 676
l1_rollup_calldata_gas 6,400 6,412 6,400
l1_rollup_execution_gas 585,733 585,745 585,733
l2_block_processing_time_in_ms 1,315 (-2%) 4,688 (-1%) 8,964 (-6%)
note_successful_decrypting_time_in_ms 227 (-14%) 528 (-7%) 1,038
note_trial_decrypting_time_in_ms 26.3 (-60%) 39.5 (-48%) 62.8 (-2%)
l2_block_building_time_in_ms 11,780 (-2%) 42,635 83,830
l2_block_rollup_simulation_time_in_ms 11,747 (-2%) 42,520 83,609
l2_block_public_tx_process_time_in_ms 6,065 (-3%) 23,899 47,866 (+1%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric 5 blocks 10 blocks
node_history_sync_time_in_ms 14,342 26,391 (-4%)
note_history_successful_decrypting_time_in_ms 1,188 (-10%) 2,393 (-2%)
note_history_trial_decrypting_time_in_ms 41.8 (-67%) 102 (-6%)
node_database_size_in_bytes 18,657,360 34,996,304
pxe_database_size_in_bytes 29,859 59,414

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit circuit_simulation_time_in_ms circuit_input_size_in_bytes circuit_output_size_in_bytes
private-kernel-init 180 44,377 26,164
private-kernel-ordering 161 50,830 39,026
base-parity 3,857 (-3%) 128 311
root-parity 1,139 (+14%) 1,244 311
base-rollup 14,177 110,464 861
root-rollup 49.6 4,359 725
private-kernel-inner 217 71,744 26,164
public-kernel-app-logic 119 47,695 40,661
public-kernel-tail 163 (+1%) 53,372 7,125
merge-rollup 10.4 (+10%) 2,568 861
public-kernel-teardown 117 (+1%) 47,695 40,661
public-kernel-setup 116 (+1%) 47,695 40,661

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric 1 leaves 16 leaves 64 leaves 128 leaves 512 leaves 1024 leaves 2048 leaves 4096 leaves 32 leaves
batch_insert_into_append_only_tree_16_depth_ms 10.0 16.0 (-1%) N/A N/A N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_16_depth_hash_count 16.8 31.6 N/A N/A N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_16_depth_hash_ms 0.585 0.494 (-1%) N/A N/A N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_32_depth_ms N/A N/A 46.0 72.0 (-1%) 230 444 (-1%) 866 (-1%) 1,722 N/A
batch_insert_into_append_only_tree_32_depth_hash_count N/A N/A 96.0 159 543 1,055 2,079 4,127 N/A
batch_insert_into_append_only_tree_32_depth_hash_ms N/A N/A 0.470 0.444 0.419 0.415 (-1%) 0.411 (-1%) 0.413 N/A
batch_insert_into_indexed_tree_20_depth_ms N/A N/A 54.0 106 (-1%) 333 (-1%) 656 (-1%) 1,301 (+1%) 2,600 N/A
batch_insert_into_indexed_tree_20_depth_hash_count N/A N/A 105 207 691 1,363 2,707 5,395 N/A
batch_insert_into_indexed_tree_20_depth_hash_ms N/A N/A 0.477 0.479 (-1%) 0.455 (-1%) 0.452 (-1%) 0.451 (+1%) 0.452 N/A
batch_insert_into_indexed_tree_40_depth_ms N/A N/A N/A N/A N/A N/A N/A N/A 60.8
batch_insert_into_indexed_tree_40_depth_hash_count N/A N/A N/A N/A N/A N/A N/A N/A 109
batch_insert_into_indexed_tree_40_depth_hash_ms N/A N/A N/A N/A N/A N/A N/A N/A 0.531

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric 0 registered classes 1 registered classes
tx_size_in_bytes 40,372 496,534

Transaction size based on fee payment method

Metric native fee payment method fpc_public fee payment method fpc_private fee payment method
tx_with_fee_size_in_bytes 905 1,161 1,377

Transaction processing duration by data writes.

Metric 0 new note hashes 1 new note hashes 2 new note hashes
tx_pxe_processing_time_ms 1,700 (+2%) 1,079 5,410
Metric 1 public data writes 2 public data writes 3 public data writes 4 public data writes 5 public data writes 8 public data writes
tx_sequencer_processing_time_ms 570 405 (+2%) 1,077 (+1%) 524 (+3%) 1,759 (+2%) 587 (+3%)

@codygunton codygunton force-pushed the cg/nix_eccvm_composer_2 branch from 54f8e15 to 556ed43 Compare April 4, 2024 16:33
@codygunton codygunton marked this pull request as ready for review April 5, 2024 01:06
@codygunton codygunton requested a review from ledwards2225 April 5, 2024 01:26
@@ -307,6 +307,21 @@ class ECCVMFlavor {
using Base = ProvingKey_<PrecomputedEntities<Polynomial>, WitnessEntities<Polynomial>, CommitmentKey>;
using Base::Base;

ProvingKey(const CircuitBuilder& builder)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Core change to get rid of compute_proving_key

public:
std::vector<FF> public_inputs;

VerificationKey(const size_t circuit_size, const size_t num_public_inputs)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Core change to get rid of compute_verification_key


public:
explicit ECCVMVerifier_(const std::shared_ptr<VerificationKey>& verifier_key = nullptr);
ECCVMVerifier_(const std::shared_ptr<VerificationKey>& key,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This constructor was not in use.


public:
explicit ECCVMVerifier_(const std::shared_ptr<VerificationKey>& verifier_key = nullptr);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This default value was not in use.

, pcs_verification_key(std::move(pcs_verification_key))
, transcript(std::move(transcript))
{}
ECCVMVerifier_(ECCVMVerifier_&& other) noexcept;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is all not needed.


bool verify_proof(const HonkProof& proof);

std::shared_ptr<VerificationKey> key;
std::map<std::string, Commitment> commitments;
std::map<std::string, FF> pcs_fr_elements;
std::shared_ptr<VerifierCommitmentKey> pcs_verification_key;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is in the verification key.

@@ -205,7 +203,7 @@ class Goblin {
MergeVerifier merge_verifier;
bool merge_verified = merge_verifier.verify_proof(proof.merge_proof);

auto eccvm_verifier = eccvm_composer->create_verifier(*eccvm_builder);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We didn't really need a constructor of a verifier from a builder so I didn't bother to implement (followed translator model). Ofc it's very easy to add one if/when needed.

Copy link
Contributor

@ledwards2225 ledwards2225 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ledwards2225 ledwards2225 enabled auto-merge (squash) April 8, 2024 18:51
@ledwards2225 ledwards2225 merged commit 43ed901 into master Apr 8, 2024
145 of 147 checks passed
@ledwards2225 ledwards2225 deleted the cg/nix_eccvm_composer_2 branch April 8, 2024 19:16
rahul-kothari pushed a commit that referenced this pull request Apr 9, 2024
🤖 I have created a release *beep* *boop*
---


<details><summary>aztec-package: 0.33.0</summary>

##
[0.33.0](aztec-package-v0.32.1...aztec-package-v0.33.0)
(2024-04-09)


### Features

* Jest fast transpile. no more ts-jest.
([#5530](#5530))
([1912802](1912802))
* **SimulateTx:** Simulate constrained transaction execution with return
values
([#5432](#5432))
([0249737](0249737))
</details>

<details><summary>barretenberg.js: 0.33.0</summary>

##
[0.33.0](barretenberg.js-v0.32.1...barretenberg.js-v0.33.0)
(2024-04-09)


### Miscellaneous

* **barretenberg.js:** Synchronize aztec-packages versions
</details>

<details><summary>aztec-cli: 0.33.0</summary>

##
[0.33.0](aztec-cli-v0.32.1...aztec-cli-v0.33.0)
(2024-04-09)


### ⚠ BREAKING CHANGES

* contract_abi-exports
([#5386](#5386))

### Features

* **avm:** Integrate AVM with initializers
([#5469](#5469))
([59799f2](59799f2))
* Contract_abi-exports
([#5386](#5386))
([745d522](745d522))
* Jest fast transpile. no more ts-jest.
([#5530](#5530))
([1912802](1912802))


### Bug Fixes

* Update CLI & terraforms with new contract addresses
([#5553](#5553))
([eb73d20](eb73d20))
</details>

<details><summary>aztec-packages: 0.33.0</summary>

##
[0.33.0](aztec-packages-v0.32.1...aztec-packages-v0.33.0)
(2024-04-09)


### ⚠ BREAKING CHANGES

* **acir:** Add predicate to call opcode
([#5616](#5616))
* contract_abi-exports
([#5386](#5386))
* **avm:** rollback FunctionAbi isTranspiled changes
([#5561](#5561))

### Features

* /foundry is canoncial build of foundry. e2e tests can start own anvil.
([#5522](#5522))
([510daa0](510daa0))
* `add` and `sub` methods of `EasyPrivateUint` throw when called in
public
([#5581](#5581))
([29f337d](29f337d))
* **acir:** Add predicate to call opcode
([#5616](#5616))
([e8cec0a](e8cec0a))
* **acvm_js:** Execute program
(noir-lang/noir#4694)
([8b30b95](8b30b95))
* Add return values to aztec fns
([#5389](#5389))
([7b88bac](7b88bac))
* Allow slices to brillig entry points
(noir-lang/noir#4713)
([8b30b95](8b30b95))
* Avm logup
([#5577](#5577))
([7e4e9b9](7e4e9b9))
* **avm:** Add index to pedersen opcode
([#5486](#5486))
([e1d7d11](e1d7d11))
* **avm:** Contract instance opcode
([#5487](#5487))
([ceacba6](ceacba6))
* **avm:** Gas usage for nested calls
([#5495](#5495))
([11699c8](11699c8))
* **avm:** Indirect memory for set opcode
([#5546](#5546))
([e0e7200](e0e7200)),
closes
[#5542](#5542)
* **avm:** Integrate AVM with initializers
([#5469](#5469))
([59799f2](59799f2))
* **avm:** Set gas allowance in public calls
([#5567](#5567))
([ee23415](ee23415))
* **avm:** Track gas from memory accesses explicitly
([#5563](#5563))
([18c9128](18c9128)),
closes
[#5514](#5514)
* Contract_abi-exports
([#5386](#5386))
([745d522](745d522))
* DataBus notion with calldata/return data
([#5504](#5504))
([95a1d8a](95a1d8a))
* DebugLog(...) in noir-protocol-circuits
([#5568](#5568))
([a07bb92](a07bb92))
* **docs:** Documenting noir codegen
(noir-lang/noir#4454)
([8b30b95](8b30b95))
* Improve nargo check cli with --override flag and feedback for existing
files (noir-lang/noir#4575)
([8b30b95](8b30b95))
* Improve optimisations on range constraints
(noir-lang/noir#4690)
([8b30b95](8b30b95))
* Improve SSA type-awareness in EQ and MUL instructions
(noir-lang/noir#4691)
([8b30b95](8b30b95))
* Improve the proving orchestration lifecycle
([#5535](#5535))
([4e4f843](4e4f843))
* Jest fast transpile. no more ts-jest.
([#5530](#5530))
([1912802](1912802))
* Logging deployed contract address to help debug e2e account test
([#5571](#5571))
([1907473](1907473))
* Only export values from accumulated data
([#5604](#5604))
([a974ec8](a974ec8))
* Optimise relations
([#5552](#5552))
([a581e80](a581e80))
* Optimize auxiliary relations slightly
([#5517](#5517))
([30be431](30be431))
* Public inputs refactor
([#5500](#5500))
([6b9a538](6b9a538))
* Restore hashing args via slice for performance
([#5539](#5539))
([eb3acdf](eb3acdf))
* **SimulateTx:** Simulate constrained transaction execution with return
values
([#5432](#5432))
([0249737](0249737))


### Bug Fixes

* **acvm:** Mark outputs of Opcode::Call solvable
(noir-lang/noir#4708)
([8b30b95](8b30b95))
* **avm:** Nullifier handling
([#5488](#5488))
([bc8211d](bc8211d))
* **ci:** Cache submodules in GA
([#5531](#5531))
([75f2cc6](75f2cc6))
* **ci:** Install fixed foundry version in CI
([#5582](#5582))
([46fdb37](46fdb37))
* Dependabot update
([#5547](#5547))
([f7e6cc8](f7e6cc8))
* E2e earthly status
([#5564](#5564))
([a5076ca](a5076ca))
* Field comparisons (noir-lang/noir#4704)
([8b30b95](8b30b95))
* Invalid fork terraform
([#5585](#5585))
([826353b](826353b))
* Last use analysis & make it an SSA pass
(noir-lang/noir#4686)
([8b30b95](8b30b95))
* Mainnet fork redeploys
([#5573](#5573))
([88e8b6d](88e8b6d))
* Remove EFS lifecycle rule
([#5587](#5587))
([eb66fc6](eb66fc6))
* **ssa:** Do not use get_value_max_num_bits when we want pure type
information (noir-lang/noir#4700)
([8b30b95](8b30b95))
* Taint fork file storage
([#5560](#5560))
([f144f3b](f144f3b))
* Unknown slice lengths coming from as_slice
(noir-lang/noir#4725)
([8b30b95](8b30b95))
* Update CLI & terraforms with new contract addresses
([#5553](#5553))
([eb73d20](eb73d20))


### Miscellaneous

* **avm:** Rollback FunctionAbi isTranspiled changes
([#5561](#5561))
([150932a](150932a))
* Check for references to private functions during path resolution
(noir-lang/noir#4622)
([8b30b95](8b30b95))
* **docs:** Add file to prove ownership for google search console
([#5554](#5554))
([dfa3998](dfa3998))
* **docs:** Fix indexed-merkle-tree docs images
([#4674](#4674))
([8fc29d5](8fc29d5))
* **docs:** Random updates
([#5281](#5281))
([b8c9273](b8c9273))
* ECCVM flavor depends on builder
([#5323](#5323))
([a594683](a594683))
* Fix clippy errors (noir-lang/noir#4684)
([8b30b95](8b30b95))
* Get rid of ECCVM composer
([#5562](#5562))
([43ed901](43ed901))
* Move e2e-avm-initializer test to e2e-avm-simulator
([#5570](#5570))
([d827705](d827705))
* Nuking accounts from e2e setup
([#5574](#5574))
([be6f843](be6f843)),
closes
[#5307](#5307)
* Nuking L2BlockContext
([#5569](#5569))
([1299190](1299190))
* Pad when needed and not sooner
([#5482](#5482))
([e928c33](e928c33)),
closes
[#5357](#5357)
* Remove conditional compilation around `acvm_js` package
(noir-lang/noir#4702)
([8b30b95](8b30b95))
* Remove debug log from watch.sh
([a9a349d](a9a349d))
* Remove last traces of nix
(noir-lang/noir#4679)
([8b30b95](8b30b95))
* Remove unused boolean return values from stores
([#5470](#5470))
([07794ee](07794ee))
* Remove unused env vars from `Cross.toml`
(noir-lang/noir#4717)
([8b30b95](8b30b95))
* Replace relative paths to noir-protocol-circuits
([51a1983](51a1983))
* Replace relative paths to noir-protocol-circuits
([a716270](a716270))
* Replace relative paths to noir-protocol-circuits
([6827014](6827014))
* Replace relative paths to noir-protocol-circuits
([356caf7](356caf7))
* Simplify how `acvm_backend.wasm` is embedded
(noir-lang/noir#4703)
([8b30b95](8b30b95))
* Simplify how blns is loaded into tests
(noir-lang/noir#4705)
([8b30b95](8b30b95))
* Update snapshot
([#5626](#5626))
([fb66426](fb66426))
* Use is_entry_point helper on RuntimeType
(noir-lang/noir#4678)
([8b30b95](8b30b95))


### Documentation

* Minor fixes in keys
([#5550](#5550))
([ea48ad3](ea48ad3))
* **spec:** Hashing and keys
([#5478](#5478))
([820ac8c](820ac8c))
* Update quickstart.md to use Docker daemon
([#5576](#5576))
([42b9827](42b9827))
</details>

<details><summary>barretenberg: 0.33.0</summary>

##
[0.33.0](barretenberg-v0.32.1...barretenberg-v0.33.0)
(2024-04-09)


### ⚠ BREAKING CHANGES

* **acir:** Add predicate to call opcode
([#5616](#5616))

### Features

* **acir:** Add predicate to call opcode
([#5616](#5616))
([e8cec0a](e8cec0a))
* Avm logup
([#5577](#5577))
([7e4e9b9](7e4e9b9))
* **avm:** Contract instance opcode
([#5487](#5487))
([ceacba6](ceacba6))
* **avm:** Indirect memory for set opcode
([#5546](#5546))
([e0e7200](e0e7200)),
closes
[#5542](#5542)
* DataBus notion with calldata/return data
([#5504](#5504))
([95a1d8a](95a1d8a))
* Optimise relations
([#5552](#5552))
([a581e80](a581e80))
* Optimize auxiliary relations slightly
([#5517](#5517))
([30be431](30be431))


### Miscellaneous

* ECCVM flavor depends on builder
([#5323](#5323))
([a594683](a594683))
* Get rid of ECCVM composer
([#5562](#5562))
([43ed901](43ed901))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
AztecBot added a commit to AztecProtocol/barretenberg that referenced this pull request Apr 10, 2024
🤖 I have created a release *beep* *boop*
---


<details><summary>aztec-package: 0.33.0</summary>

##
[0.33.0](AztecProtocol/aztec-packages@aztec-package-v0.32.1...aztec-package-v0.33.0)
(2024-04-09)


### Features

* Jest fast transpile. no more ts-jest.
([#5530](AztecProtocol/aztec-packages#5530))
([1912802](AztecProtocol/aztec-packages@1912802))
* **SimulateTx:** Simulate constrained transaction execution with return
values
([#5432](AztecProtocol/aztec-packages#5432))
([0249737](AztecProtocol/aztec-packages@0249737))
</details>

<details><summary>barretenberg.js: 0.33.0</summary>

##
[0.33.0](AztecProtocol/aztec-packages@barretenberg.js-v0.32.1...barretenberg.js-v0.33.0)
(2024-04-09)


### Miscellaneous

* **barretenberg.js:** Synchronize aztec-packages versions
</details>

<details><summary>aztec-cli: 0.33.0</summary>

##
[0.33.0](AztecProtocol/aztec-packages@aztec-cli-v0.32.1...aztec-cli-v0.33.0)
(2024-04-09)


### ⚠ BREAKING CHANGES

* contract_abi-exports
([#5386](AztecProtocol/aztec-packages#5386))

### Features

* **avm:** Integrate AVM with initializers
([#5469](AztecProtocol/aztec-packages#5469))
([59799f2](AztecProtocol/aztec-packages@59799f2))
* Contract_abi-exports
([#5386](AztecProtocol/aztec-packages#5386))
([745d522](AztecProtocol/aztec-packages@745d522))
* Jest fast transpile. no more ts-jest.
([#5530](AztecProtocol/aztec-packages#5530))
([1912802](AztecProtocol/aztec-packages@1912802))


### Bug Fixes

* Update CLI & terraforms with new contract addresses
([#5553](AztecProtocol/aztec-packages#5553))
([eb73d20](AztecProtocol/aztec-packages@eb73d20))
</details>

<details><summary>aztec-packages: 0.33.0</summary>

##
[0.33.0](AztecProtocol/aztec-packages@aztec-packages-v0.32.1...aztec-packages-v0.33.0)
(2024-04-09)


### ⚠ BREAKING CHANGES

* **acir:** Add predicate to call opcode
([#5616](AztecProtocol/aztec-packages#5616))
* contract_abi-exports
([#5386](AztecProtocol/aztec-packages#5386))
* **avm:** rollback FunctionAbi isTranspiled changes
([#5561](AztecProtocol/aztec-packages#5561))

### Features

* /foundry is canoncial build of foundry. e2e tests can start own anvil.
([#5522](AztecProtocol/aztec-packages#5522))
([510daa0](AztecProtocol/aztec-packages@510daa0))
* `add` and `sub` methods of `EasyPrivateUint` throw when called in
public
([#5581](AztecProtocol/aztec-packages#5581))
([29f337d](AztecProtocol/aztec-packages@29f337d))
* **acir:** Add predicate to call opcode
([#5616](AztecProtocol/aztec-packages#5616))
([e8cec0a](AztecProtocol/aztec-packages@e8cec0a))
* **acvm_js:** Execute program
(noir-lang/noir#4694)
([8b30b95](AztecProtocol/aztec-packages@8b30b95))
* Add return values to aztec fns
([#5389](AztecProtocol/aztec-packages#5389))
([7b88bac](AztecProtocol/aztec-packages@7b88bac))
* Allow slices to brillig entry points
(noir-lang/noir#4713)
([8b30b95](AztecProtocol/aztec-packages@8b30b95))
* Avm logup
([#5577](AztecProtocol/aztec-packages#5577))
([7e4e9b9](AztecProtocol/aztec-packages@7e4e9b9))
* **avm:** Add index to pedersen opcode
([#5486](AztecProtocol/aztec-packages#5486))
([e1d7d11](AztecProtocol/aztec-packages@e1d7d11))
* **avm:** Contract instance opcode
([#5487](AztecProtocol/aztec-packages#5487))
([ceacba6](AztecProtocol/aztec-packages@ceacba6))
* **avm:** Gas usage for nested calls
([#5495](AztecProtocol/aztec-packages#5495))
([11699c8](AztecProtocol/aztec-packages@11699c8))
* **avm:** Indirect memory for set opcode
([#5546](AztecProtocol/aztec-packages#5546))
([e0e7200](AztecProtocol/aztec-packages@e0e7200)),
closes
[#5542](AztecProtocol/aztec-packages#5542)
* **avm:** Integrate AVM with initializers
([#5469](AztecProtocol/aztec-packages#5469))
([59799f2](AztecProtocol/aztec-packages@59799f2))
* **avm:** Set gas allowance in public calls
([#5567](AztecProtocol/aztec-packages#5567))
([ee23415](AztecProtocol/aztec-packages@ee23415))
* **avm:** Track gas from memory accesses explicitly
([#5563](AztecProtocol/aztec-packages#5563))
([18c9128](AztecProtocol/aztec-packages@18c9128)),
closes
[#5514](AztecProtocol/aztec-packages#5514)
* Contract_abi-exports
([#5386](AztecProtocol/aztec-packages#5386))
([745d522](AztecProtocol/aztec-packages@745d522))
* DataBus notion with calldata/return data
([#5504](AztecProtocol/aztec-packages#5504))
([95a1d8a](AztecProtocol/aztec-packages@95a1d8a))
* DebugLog(...) in noir-protocol-circuits
([#5568](AztecProtocol/aztec-packages#5568))
([a07bb92](AztecProtocol/aztec-packages@a07bb92))
* **docs:** Documenting noir codegen
(noir-lang/noir#4454)
([8b30b95](AztecProtocol/aztec-packages@8b30b95))
* Improve nargo check cli with --override flag and feedback for existing
files (noir-lang/noir#4575)
([8b30b95](AztecProtocol/aztec-packages@8b30b95))
* Improve optimisations on range constraints
(noir-lang/noir#4690)
([8b30b95](AztecProtocol/aztec-packages@8b30b95))
* Improve SSA type-awareness in EQ and MUL instructions
(noir-lang/noir#4691)
([8b30b95](AztecProtocol/aztec-packages@8b30b95))
* Improve the proving orchestration lifecycle
([#5535](AztecProtocol/aztec-packages#5535))
([4e4f843](AztecProtocol/aztec-packages@4e4f843))
* Jest fast transpile. no more ts-jest.
([#5530](AztecProtocol/aztec-packages#5530))
([1912802](AztecProtocol/aztec-packages@1912802))
* Logging deployed contract address to help debug e2e account test
([#5571](AztecProtocol/aztec-packages#5571))
([1907473](AztecProtocol/aztec-packages@1907473))
* Only export values from accumulated data
([#5604](AztecProtocol/aztec-packages#5604))
([a974ec8](AztecProtocol/aztec-packages@a974ec8))
* Optimise relations
([#5552](AztecProtocol/aztec-packages#5552))
([a581e80](AztecProtocol/aztec-packages@a581e80))
* Optimize auxiliary relations slightly
([#5517](AztecProtocol/aztec-packages#5517))
([30be431](AztecProtocol/aztec-packages@30be431))
* Public inputs refactor
([#5500](AztecProtocol/aztec-packages#5500))
([6b9a538](AztecProtocol/aztec-packages@6b9a538))
* Restore hashing args via slice for performance
([#5539](AztecProtocol/aztec-packages#5539))
([eb3acdf](AztecProtocol/aztec-packages@eb3acdf))
* **SimulateTx:** Simulate constrained transaction execution with return
values
([#5432](AztecProtocol/aztec-packages#5432))
([0249737](AztecProtocol/aztec-packages@0249737))


### Bug Fixes

* **acvm:** Mark outputs of Opcode::Call solvable
(noir-lang/noir#4708)
([8b30b95](AztecProtocol/aztec-packages@8b30b95))
* **avm:** Nullifier handling
([#5488](AztecProtocol/aztec-packages#5488))
([bc8211d](AztecProtocol/aztec-packages@bc8211d))
* **ci:** Cache submodules in GA
([#5531](AztecProtocol/aztec-packages#5531))
([75f2cc6](AztecProtocol/aztec-packages@75f2cc6))
* **ci:** Install fixed foundry version in CI
([#5582](AztecProtocol/aztec-packages#5582))
([46fdb37](AztecProtocol/aztec-packages@46fdb37))
* Dependabot update
([#5547](AztecProtocol/aztec-packages#5547))
([f7e6cc8](AztecProtocol/aztec-packages@f7e6cc8))
* E2e earthly status
([#5564](AztecProtocol/aztec-packages#5564))
([a5076ca](AztecProtocol/aztec-packages@a5076ca))
* Field comparisons (noir-lang/noir#4704)
([8b30b95](AztecProtocol/aztec-packages@8b30b95))
* Invalid fork terraform
([#5585](AztecProtocol/aztec-packages#5585))
([826353b](AztecProtocol/aztec-packages@826353b))
* Last use analysis & make it an SSA pass
(noir-lang/noir#4686)
([8b30b95](AztecProtocol/aztec-packages@8b30b95))
* Mainnet fork redeploys
([#5573](AztecProtocol/aztec-packages#5573))
([88e8b6d](AztecProtocol/aztec-packages@88e8b6d))
* Remove EFS lifecycle rule
([#5587](AztecProtocol/aztec-packages#5587))
([eb66fc6](AztecProtocol/aztec-packages@eb66fc6))
* **ssa:** Do not use get_value_max_num_bits when we want pure type
information (noir-lang/noir#4700)
([8b30b95](AztecProtocol/aztec-packages@8b30b95))
* Taint fork file storage
([#5560](AztecProtocol/aztec-packages#5560))
([f144f3b](AztecProtocol/aztec-packages@f144f3b))
* Unknown slice lengths coming from as_slice
(noir-lang/noir#4725)
([8b30b95](AztecProtocol/aztec-packages@8b30b95))
* Update CLI & terraforms with new contract addresses
([#5553](AztecProtocol/aztec-packages#5553))
([eb73d20](AztecProtocol/aztec-packages@eb73d20))


### Miscellaneous

* **avm:** Rollback FunctionAbi isTranspiled changes
([#5561](AztecProtocol/aztec-packages#5561))
([150932a](AztecProtocol/aztec-packages@150932a))
* Check for references to private functions during path resolution
(noir-lang/noir#4622)
([8b30b95](AztecProtocol/aztec-packages@8b30b95))
* **docs:** Add file to prove ownership for google search console
([#5554](AztecProtocol/aztec-packages#5554))
([dfa3998](AztecProtocol/aztec-packages@dfa3998))
* **docs:** Fix indexed-merkle-tree docs images
([#4674](AztecProtocol/aztec-packages#4674))
([8fc29d5](AztecProtocol/aztec-packages@8fc29d5))
* **docs:** Random updates
([#5281](AztecProtocol/aztec-packages#5281))
([b8c9273](AztecProtocol/aztec-packages@b8c9273))
* ECCVM flavor depends on builder
([#5323](AztecProtocol/aztec-packages#5323))
([a594683](AztecProtocol/aztec-packages@a594683))
* Fix clippy errors (noir-lang/noir#4684)
([8b30b95](AztecProtocol/aztec-packages@8b30b95))
* Get rid of ECCVM composer
([#5562](AztecProtocol/aztec-packages#5562))
([43ed901](AztecProtocol/aztec-packages@43ed901))
* Move e2e-avm-initializer test to e2e-avm-simulator
([#5570](AztecProtocol/aztec-packages#5570))
([d827705](AztecProtocol/aztec-packages@d827705))
* Nuking accounts from e2e setup
([#5574](AztecProtocol/aztec-packages#5574))
([be6f843](AztecProtocol/aztec-packages@be6f843)),
closes
[#5307](AztecProtocol/aztec-packages#5307)
* Nuking L2BlockContext
([#5569](AztecProtocol/aztec-packages#5569))
([1299190](AztecProtocol/aztec-packages@1299190))
* Pad when needed and not sooner
([#5482](AztecProtocol/aztec-packages#5482))
([e928c33](AztecProtocol/aztec-packages@e928c33)),
closes
[#5357](AztecProtocol/aztec-packages#5357)
* Remove conditional compilation around `acvm_js` package
(noir-lang/noir#4702)
([8b30b95](AztecProtocol/aztec-packages@8b30b95))
* Remove debug log from watch.sh
([a9a349d](AztecProtocol/aztec-packages@a9a349d))
* Remove last traces of nix
(noir-lang/noir#4679)
([8b30b95](AztecProtocol/aztec-packages@8b30b95))
* Remove unused boolean return values from stores
([#5470](AztecProtocol/aztec-packages#5470))
([07794ee](AztecProtocol/aztec-packages@07794ee))
* Remove unused env vars from `Cross.toml`
(noir-lang/noir#4717)
([8b30b95](AztecProtocol/aztec-packages@8b30b95))
* Replace relative paths to noir-protocol-circuits
([51a1983](AztecProtocol/aztec-packages@51a1983))
* Replace relative paths to noir-protocol-circuits
([a716270](AztecProtocol/aztec-packages@a716270))
* Replace relative paths to noir-protocol-circuits
([6827014](AztecProtocol/aztec-packages@6827014))
* Replace relative paths to noir-protocol-circuits
([356caf7](AztecProtocol/aztec-packages@356caf7))
* Simplify how `acvm_backend.wasm` is embedded
(noir-lang/noir#4703)
([8b30b95](AztecProtocol/aztec-packages@8b30b95))
* Simplify how blns is loaded into tests
(noir-lang/noir#4705)
([8b30b95](AztecProtocol/aztec-packages@8b30b95))
* Update snapshot
([#5626](AztecProtocol/aztec-packages#5626))
([fb66426](AztecProtocol/aztec-packages@fb66426))
* Use is_entry_point helper on RuntimeType
(noir-lang/noir#4678)
([8b30b95](AztecProtocol/aztec-packages@8b30b95))


### Documentation

* Minor fixes in keys
([#5550](AztecProtocol/aztec-packages#5550))
([ea48ad3](AztecProtocol/aztec-packages@ea48ad3))
* **spec:** Hashing and keys
([#5478](AztecProtocol/aztec-packages#5478))
([820ac8c](AztecProtocol/aztec-packages@820ac8c))
* Update quickstart.md to use Docker daemon
([#5576](AztecProtocol/aztec-packages#5576))
([42b9827](AztecProtocol/aztec-packages@42b9827))
</details>

<details><summary>barretenberg: 0.33.0</summary>

##
[0.33.0](AztecProtocol/aztec-packages@barretenberg-v0.32.1...barretenberg-v0.33.0)
(2024-04-09)


### ⚠ BREAKING CHANGES

* **acir:** Add predicate to call opcode
([#5616](AztecProtocol/aztec-packages#5616))

### Features

* **acir:** Add predicate to call opcode
([#5616](AztecProtocol/aztec-packages#5616))
([e8cec0a](AztecProtocol/aztec-packages@e8cec0a))
* Avm logup
([#5577](AztecProtocol/aztec-packages#5577))
([7e4e9b9](AztecProtocol/aztec-packages@7e4e9b9))
* **avm:** Contract instance opcode
([#5487](AztecProtocol/aztec-packages#5487))
([ceacba6](AztecProtocol/aztec-packages@ceacba6))
* **avm:** Indirect memory for set opcode
([#5546](AztecProtocol/aztec-packages#5546))
([e0e7200](AztecProtocol/aztec-packages@e0e7200)),
closes
[#5542](AztecProtocol/aztec-packages#5542)
* DataBus notion with calldata/return data
([#5504](AztecProtocol/aztec-packages#5504))
([95a1d8a](AztecProtocol/aztec-packages@95a1d8a))
* Optimise relations
([#5552](AztecProtocol/aztec-packages#5552))
([a581e80](AztecProtocol/aztec-packages@a581e80))
* Optimize auxiliary relations slightly
([#5517](AztecProtocol/aztec-packages#5517))
([30be431](AztecProtocol/aztec-packages@30be431))


### Miscellaneous

* ECCVM flavor depends on builder
([#5323](AztecProtocol/aztec-packages#5323))
([a594683](AztecProtocol/aztec-packages@a594683))
* Get rid of ECCVM composer
([#5562](AztecProtocol/aztec-packages#5562))
([43ed901](AztecProtocol/aztec-packages@43ed901))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants