Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(Misc): Remove l1 block number from L2Block #5274

Closed
Tracked by #5070
benesjan opened this issue Mar 18, 2024 · 0 comments · Fixed by #5275, #5285 or #5296
Closed
Tracked by #5070

refactor(Misc): Remove l1 block number from L2Block #5274

benesjan opened this issue Mar 18, 2024 · 0 comments · Fixed by #5275, #5285 or #5296
Assignees
@benesjan

Comments

@benesjan
Copy link
Contributor

We have l1 block number in an L2 block and the value does not get serialized with the block and it's only used in archiver to know up to which L1 block the archiver synced. This is a terrible antipattern as it's cluttering the code and you can simply store the value in the archive store individually.
@benesjan benesjan self-assigned this Mar 18, 2024
@github-project-automation github-project-automation bot moved this to Todo in A3 Mar 18, 2024
@benesjan benesjan mentioned this issue Mar 18, 2024
Merged
@LHerskind LHerskind mentioned this issue Mar 18, 2024
Open
@LHerskind LHerskind changed the title Remove l1 block number from L2Block refactor(Misc): Remove l1 block number from L2Block Mar 18, 2024
benesjan added a commit that referenced this issue Mar 18, 2024
@benesjan
refactor: nuking L1 block number from L2 block (#5275)
6e69a6b 
Fixes #5274
@benesjan benesjan mentioned this issue Mar 18, 2024
Merged
benesjan added a commit that referenced this issue Mar 19, 2024
@benesjan
refactor: removing L1 block number from L2 block (#5285)
57596d7 
Fixes #5274
@github-project-automation github-project-automation bot moved this from Todo to Done in A3 Mar 19, 2024
@AztecBot AztecBot mentioned this issue Mar 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benesjan benesjan

Labels
None yet
Projects
A3
Archived in project
Milestone
No milestone
1 participant
@benesjan