Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Extended IPA tests and fuzzing #5140

Merged
merged 26 commits into from
Mar 15, 2024
Merged

feat: Extended IPA tests and fuzzing #5140

merged 26 commits into from
Mar 15, 2024

Conversation

Rumata888
Copy link
Contributor

@Rumata888 Rumata888 commented Mar 11, 2024

This PR extends IPA testing with testing for specific cases such as:

  1. Opening the polynomial at zero
  2. Opening a polynomial = 0
  3. Opening with challenges that are zero (should fail)
  4. Making the polynomial zero after one round (after one fold)

To this end it adds a mock transcript to provide artificial challenges. It also adds a fuzzer for IPA and fixes a bug in group arithmetic found during testing

@Rumata888 Rumata888 changed the title feat:Extended IPA tests and fuzzing feat: Extended IPA tests and fuzzing Mar 11, 2024
@AztecBot
Copy link
Collaborator

AztecBot commented Mar 11, 2024

Benchmark results

Metrics with a significant change:

  • note_successful_decrypting_time_in_ms (8): 228 (+69%)
Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Values are compared against data from master at commit 25ce33bf and shown if the difference exceeds 1%.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric 8 txs 32 txs 64 txs
l1_rollup_calldata_size_in_bytes 5,668 18,820 36,356
l1_rollup_calldata_gas 66,292 239,116 469,736
l1_rollup_execution_gas 659,615 941,700 1,318,143
l2_block_processing_time_in_ms 1,273 (-1%) 4,814 (-5%) 8,962 (-6%)
note_successful_decrypting_time_in_ms ⚠️ 228 (+69%) 563 (-2%) 972 (-1%)
note_trial_decrypting_time_in_ms 30.0 (-25%) 83.1 (-9%) 104 (-3%)
l2_block_building_time_in_ms 18,525 (+1%) 71,791 (+4%) 141,245 (+2%)
l2_block_rollup_simulation_time_in_ms 8,226 28,478 (-2%) 55,258 (-3%)
l2_block_public_tx_process_time_in_ms 10,278 (+2%) 43,256 (+8%) 85,891 (+7%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric 5 blocks 10 blocks
node_history_sync_time_in_ms 14,652 (+5%) 28,040 (+4%)
note_history_successful_decrypting_time_in_ms 1,271 (-1%) 2,464 (-1%)
note_history_trial_decrypting_time_in_ms 105 (-1%) 148 (-23%)
node_database_size_in_bytes 19,062,864 35,659,856
pxe_database_size_in_bytes 29,859 59,414

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit circuit_simulation_time_in_ms circuit_input_size_in_bytes circuit_output_size_in_bytes
private-kernel-init 282 44,370 28,244
private-kernel-ordering 215 (-1%) 52,868 14,326
base-parity 1,823 (-3%) 128 311
base-rollup 717 (-1%) 165,787 925
root-parity 1,538 (+1%) 1,244 311
root-rollup 68.6 4,487 789
private-kernel-inner 642 (-1%) 73,773 28,244
public-kernel-app-logic 458 (+3%) 35,262 28,215
public-kernel-tail 175 (+1%) 40,926 28,215
merge-rollup 8.27 2,696 925

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric 1 leaves 16 leaves 64 leaves 128 leaves 512 leaves 1024 leaves 2048 leaves 4096 leaves 32 leaves
batch_insert_into_append_only_tree_16_depth_ms 9.89 (-1%) 15.9 (-1%) N/A N/A N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_16_depth_hash_count 16.8 31.6 N/A N/A N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_16_depth_hash_ms 0.577 (-1%) 0.491 (-1%) N/A N/A N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_32_depth_ms N/A N/A 45.4 (-1%) 71.2 (-1%) 230 442 844 (-2%) 1,674 (-3%) N/A
batch_insert_into_append_only_tree_32_depth_hash_count N/A N/A 96.0 159 543 1,055 2,079 4,127 N/A
batch_insert_into_append_only_tree_32_depth_hash_ms N/A N/A 0.466 (-1%) 0.440 (-1%) 0.419 0.414 0.401 (-2%) 0.401 (-3%) N/A
batch_insert_into_indexed_tree_20_depth_ms N/A N/A 53.7 105 (-1%) 338 659 (-2%) 1,271 (-3%) 2,534 (-2%) N/A
batch_insert_into_indexed_tree_20_depth_hash_count N/A N/A 104 207 691 1,363 2,707 5,395 N/A
batch_insert_into_indexed_tree_20_depth_hash_ms N/A N/A 0.477 (-1%) 0.476 (-1%) 0.457 0.454 (-2%) 0.442 (-2%) 0.440 (-2%) N/A
batch_insert_into_indexed_tree_40_depth_ms N/A N/A N/A N/A N/A N/A N/A N/A 60.7 (-2%)
batch_insert_into_indexed_tree_40_depth_hash_count N/A N/A N/A N/A N/A N/A N/A N/A 109
batch_insert_into_indexed_tree_40_depth_hash_ms N/A N/A N/A N/A N/A N/A N/A N/A 0.532 (-2%)

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric 0 registered classes
tx_size_in_bytes 22,014

Transaction processing duration by data writes.

Metric 0 new note hashes 1 new note hashes
tx_pxe_processing_time_ms 3,299 (-1%) 1,772 (-1%)
Metric 0 public data writes 1 public data writes
tx_sequencer_processing_time_ms 13.2 (+1%) 1,274 (+2%)

@@ -31,6 +31,10 @@ inline void* protected_aligned_alloc(size_t alignment, size_t size)
{
size += (size % alignment);
void* t = nullptr;
// pad size to alignment
if (size % alignment != 0) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got tired of ASAN screaming at me every time I run MSM under it

@Rumata888 Rumata888 marked this pull request as ready for review March 12, 2024 16:21
@maramihali maramihali self-requested a review March 12, 2024 16:32
@maramihali maramihali added the crypto cryptography label Mar 12, 2024
}

// A regression test to make sure the -1 case is covered
TEST(AffineElement, BatchByMinusOne)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are these tests only for Grumpkin?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added an issue

@@ -901,6 +901,28 @@ std::vector<affine_element<Fq, Fr, T>> element<Fq, Fr, T>::batch_mul_with_endomo
/*finite_field_additions_per_iteration=*/7,
/*finite_field_multiplications_per_iteration=*/6);
};

// Since the core algorithm has no edgecase detection, it can't handle -1. (Because constructing -1 is r + -1 as
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make this comment more explicit please?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

// Vector of group elements received from the prover / sent to the verifier
std::vector<bb::curve::Grumpkin::AffineElement> group_elements;
// Vector of field elements received from the prover / sent to the verifier. uint256_t is used to ignore field type
std::vector<uint256_t> field_elements;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

won't conversions get confused if you ignore field types? why not templating if you want different fields?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wdym by "confused"? Both base and scalar field elements can be easily converted

size_t current_group_index = 0;

/**
* @brief Reset the transcript (requires to submit the challenges)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when i read reset i think of the transcript being cleared not instantiated with sth new so maybe a different name could suit

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

* @details After the transcipt received elements from the prover, this method allows to reset counters so that the
* verifier can receive those elements
*/
void reset_for_verifier()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doesn't reset already do these?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nvm, saw the usage, i think it makes sense, maybe would name reset_indices or sth?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

*
* @tparam Transcript Transcript type. Useful for testing
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where exactly?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Transcript Transcript?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One is an automatic name of the parameter, the other is "Transcript type"

@@ -246,7 +264,11 @@ template <typename Curve> class IPA {

// Step 6.d
// Receive the challenge from the verifier
const Fr round_challenge = transcript->get_challenge<Fr>("IPA:round_challenge_" + index);
const Fr round_challenge = transcript->template get_challenge<Fr>("IPA:round_challenge_" + index);

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it seemed everywhere else we use ASSERTs. I know they only trigger in debug mode, but that should be fine for now, right? Or is there any specific reason why we want to go with throw_or_abort

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also we don't document anywhere why these cannot be zero right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My understanding is ASSERTs should be used to detect cases of programmers' mistakes. And in this case you'd want to abort in production,too

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added docs

namespace bb {

// We actually only use 4, because fuzzing is very slow
constexpr size_t COMMITMENT_TEST_NUM_POINTS = 32;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's such a small crs btw :o

const auto* offset = data + 1;
const auto num_challenges = log_size + 1;
// How much data do we need?
// Challenges: sizeof(uint256_t) * num_challenges + 1 for montgomery switch
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wdym by montgomery switch?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When we do field(uint256_t(buffer)), underneath the value converts to montgomery form, after it is reduced several times. This means that the internal data of the field element is a map of the buffer, and so a single bit change of the buffer will lead to huge changes in internal representation. To be able to switch it off, I use flags from input to convert the field element back from montgomery form, so the internal form directly corresponds with what's in the buffer

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thannks for explaining!

@@ -44,6 +48,142 @@ TEST_F(IPATest, CommitOnManyZeroCoeffPolyWorks)
EXPECT_EQ(expected.normalize(), commitment.normalize());
}

TEST_F(IPATest, OpenZeroPolynomial)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add brief comments explaining the why behind each test

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@Rumata888 Rumata888 requested a review from maramihali March 15, 2024 15:10
Copy link
Contributor

@maramihali maramihali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the updates.

@Rumata888 Rumata888 merged commit 0ae5ace into master Mar 15, 2024
97 checks passed
@Rumata888 Rumata888 deleted the is/ipa_tests_new branch March 15, 2024 16:28
sirasistant pushed a commit that referenced this pull request Mar 18, 2024
🤖 I have created a release *beep* *boop*
---


<details><summary>aztec-package: 0.29.0</summary>

##
[0.29.0](aztec-package-v0.28.1...aztec-package-v0.29.0)
(2024-03-18)


### Features

* Initial Earthly CI
([#5069](#5069))
([8e75fe5](8e75fe5))
</details>

<details><summary>barretenberg.js: 0.29.0</summary>

##
[0.29.0](barretenberg.js-v0.28.1...barretenberg.js-v0.29.0)
(2024-03-18)


### Features

* Initial Earthly CI
([#5069](#5069))
([8e75fe5](8e75fe5))
</details>

<details><summary>aztec-cli: 0.29.0</summary>

##
[0.29.0](aztec-cli-v0.28.1...aztec-cli-v0.29.0)
(2024-03-18)


### Features

* Use deployer in address computation
([#5201](#5201))
([258ff4a](258ff4a))


### Miscellaneous

* Delete ContractData
([#5258](#5258))
([e516f9b](e516f9b))
* Delete ExtendedContractData struct
([#5248](#5248))
([8ae0c13](8ae0c13))
* Removing redundant receipts check
([#5271](#5271))
([5ab07fb](5ab07fb))
</details>

<details><summary>aztec-packages: 0.29.0</summary>

##
[0.29.0](aztec-packages-v0.28.1...aztec-packages-v0.29.0)
(2024-03-18)


### ⚠ BREAKING CHANGES

* Acir call opcode
([#4773](#4773))

### Features

* Acir call opcode
([#4773](#4773))
([0b15db2](0b15db2))
* Add as_slice builtin function, add execution test
(noir-lang/noir#4523)
([86e1a86](86e1a86))
* Add more impls on Option (noir-lang/noir#4549)
([86e1a86](86e1a86))
* Add RelWithAssert build
([#4997](#4997))
([4f337c7](4f337c7))
* Allow usage of noir `#[test]` syntax in stdlib
(noir-lang/noir#4553)
([86e1a86](86e1a86))
* **AuthWit:** Simplify create authwit syntax
([#5132](#5132))
([d0a5b19](d0a5b19))
* **avm:** Brillig CONST of size &gt; u128
([#5217](#5217))
([2e63479](2e63479))
* **avm:** Mov opcode with direct memory
([#5204](#5204))
([08f9038](08f9038)),
closes
[#5159](#5159)
* Brillig IR refactor
([#5233](#5233))
([9a73348](9a73348))
* Check initializer msg.sender matches deployer from address preimage
([#5222](#5222))
([438d16f](438d16f))
* Extended IPA tests and fuzzing
([#5140](#5140))
([0ae5ace](0ae5ace))
* Initial Earthly CI
([#5069](#5069))
([8e75fe5](8e75fe5))
* New Outbox Contract
[#4768](#4768)
([#5090](#5090))
([6421a3d](6421a3d))
* Remove curly braces with fmt
(noir-lang/noir#4529)
([86e1a86](86e1a86))
* Remove curly braces with fmt
(noir-lang/noir#4529)
([d8b8456](d8b8456))
* Remove unnecessary `mulmod`s from verifier contract
([#5269](#5269))
([20d9c0c](20d9c0c))
* Signed integer division and modulus in brillig gen
([#5279](#5279))
([82f8cf5](82f8cf5))
* Use deployer in address computation
([#5201](#5201))
([258ff4a](258ff4a))


### Bug Fixes

* **avm-transpiler:** RETURN is direct
([#5277](#5277))
([f90b2cf](f90b2cf))
* **bb:** Mac build
([#5253](#5253))
([ae021c0](ae021c0))
* CVC5 api update
([#5203](#5203))
([9cc32cb](9cc32cb))
* Evaluate operators in globals in types
(noir-lang/noir#4537)
([86e1a86](86e1a86))
* Evaluate operators in globals in types
(noir-lang/noir#4537)
([d8b8456](d8b8456))
* Make `nargo` the default binary for cargo run
(noir-lang/noir#4554)
([86e1a86](86e1a86))
* Make `nargo` the default binary for cargo run
(noir-lang/noir#4554)
([d8b8456](d8b8456))
* Revert "fix: noir mirror merge strat"
([#5250](#5250))
([7e8e8e5](7e8e8e5))
* Validation requests
([#5236](#5236))
([25ce33b](25ce33b))


### Miscellaneous

* Add avm team to codeowners for public context
([#5288](#5288))
([e146076](e146076))
* Add more `Hash` impls to stdlib
(noir-lang/noir#4470)
([86e1a86](86e1a86))
* Add more `Hash` impls to stdlib
(noir-lang/noir#4470)
([d8b8456](d8b8456))
* Add quick explanatory comment to outbox suggested by
[@benesjan](https://github.com/benesjan)
([#5247](#5247))
([56e8451](56e8451))
* **avm-simulator:** Update e2e test
([#5283](#5283))
([e9beeca](e9beeca))
* **avm-transpiler:** Return u8 in comparison ops
([#5280](#5280))
([1a5eb69](1a5eb69))
* **avm-transpiler:** Transpiler cleanup
([#5218](#5218))
([199e918](199e918))
* Delete ContractDao
([#5256](#5256))
([544e278](544e278))
* Delete ContractData
([#5258](#5258))
([e516f9b](e516f9b))
* Delete ExtendedContractData struct
([#5248](#5248))
([8ae0c13](8ae0c13))
* Delete isInternal and isConstructor fields from FunctionData
([#5232](#5232))
([dea3f87](dea3f87))
* Delete unused contract tree ts code
([#5229](#5229))
([b48dd23](b48dd23))
* Delete unused hash functions
([#5231](#5231))
([fed70a1](fed70a1))
* Fix docker test workflows
(noir-lang/noir#4566)
([86e1a86](86e1a86))
* Fixing some broken links (noir-lang/noir#4556)
([86e1a86](86e1a86))
* Making docs build before cutting versions
(noir-lang/noir#4568)
([86e1a86](86e1a86))
* Old inbox purge
([#5206](#5206))
([a26d968](a26d968))
* Removing redundant receipts check
([#5271](#5271))
([5ab07fb](5ab07fb))
* Separate tests for execution failures from compilation failures
(noir-lang/noir#4559)
([86e1a86](86e1a86))
* Separate tests for execution failures from compilation failures
(noir-lang/noir#4559)
([d8b8456](d8b8456))
* Template Zeromorph by PCS
([#5215](#5215))
([03feab2](03feab2))
* Use inotifywait to run generate in yarn-project
([#5168](#5168))
([137c13e](137c13e))


### Documentation

* **yp:** Remove contract tree and deploy data from circuits and state
([#5260](#5260))
([acffa7b](acffa7b))
</details>

<details><summary>barretenberg: 0.29.0</summary>

##
[0.29.0](barretenberg-v0.28.1...barretenberg-v0.29.0)
(2024-03-18)


### ⚠ BREAKING CHANGES

* Acir call opcode
([#4773](#4773))

### Features

* Acir call opcode
([#4773](#4773))
([0b15db2](0b15db2))
* Add RelWithAssert build
([#4997](#4997))
([4f337c7](4f337c7))
* **avm:** Mov opcode with direct memory
([#5204](#5204))
([08f9038](08f9038)),
closes
[#5159](#5159)
* Extended IPA tests and fuzzing
([#5140](#5140))
([0ae5ace](0ae5ace))
* Initial Earthly CI
([#5069](#5069))
([8e75fe5](8e75fe5))
* Remove unnecessary `mulmod`s from verifier contract
([#5269](#5269))
([20d9c0c](20d9c0c))
* Signed integer division and modulus in brillig gen
([#5279](#5279))
([82f8cf5](82f8cf5))


### Bug Fixes

* **bb:** Mac build
([#5253](#5253))
([ae021c0](ae021c0))
* CVC5 api update
([#5203](#5203))
([9cc32cb](9cc32cb))


### Miscellaneous

* Template Zeromorph by PCS
([#5215](#5215))
([03feab2](03feab2))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
AztecBot added a commit to AztecProtocol/barretenberg that referenced this pull request Mar 19, 2024
🤖 I have created a release *beep* *boop*
---


<details><summary>aztec-package: 0.29.0</summary>

##
[0.29.0](AztecProtocol/aztec-packages@aztec-package-v0.28.1...aztec-package-v0.29.0)
(2024-03-18)


### Features

* Initial Earthly CI
([#5069](AztecProtocol/aztec-packages#5069))
([8e75fe5](AztecProtocol/aztec-packages@8e75fe5))
</details>

<details><summary>barretenberg.js: 0.29.0</summary>

##
[0.29.0](AztecProtocol/aztec-packages@barretenberg.js-v0.28.1...barretenberg.js-v0.29.0)
(2024-03-18)


### Features

* Initial Earthly CI
([#5069](AztecProtocol/aztec-packages#5069))
([8e75fe5](AztecProtocol/aztec-packages@8e75fe5))
</details>

<details><summary>aztec-cli: 0.29.0</summary>

##
[0.29.0](AztecProtocol/aztec-packages@aztec-cli-v0.28.1...aztec-cli-v0.29.0)
(2024-03-18)


### Features

* Use deployer in address computation
([#5201](AztecProtocol/aztec-packages#5201))
([258ff4a](AztecProtocol/aztec-packages@258ff4a))


### Miscellaneous

* Delete ContractData
([#5258](AztecProtocol/aztec-packages#5258))
([e516f9b](AztecProtocol/aztec-packages@e516f9b))
* Delete ExtendedContractData struct
([#5248](AztecProtocol/aztec-packages#5248))
([8ae0c13](AztecProtocol/aztec-packages@8ae0c13))
* Removing redundant receipts check
([#5271](AztecProtocol/aztec-packages#5271))
([5ab07fb](AztecProtocol/aztec-packages@5ab07fb))
</details>

<details><summary>aztec-packages: 0.29.0</summary>

##
[0.29.0](AztecProtocol/aztec-packages@aztec-packages-v0.28.1...aztec-packages-v0.29.0)
(2024-03-18)


### ⚠ BREAKING CHANGES

* Acir call opcode
([#4773](AztecProtocol/aztec-packages#4773))

### Features

* Acir call opcode
([#4773](AztecProtocol/aztec-packages#4773))
([0b15db2](AztecProtocol/aztec-packages@0b15db2))
* Add as_slice builtin function, add execution test
(noir-lang/noir#4523)
([86e1a86](AztecProtocol/aztec-packages@86e1a86))
* Add more impls on Option (noir-lang/noir#4549)
([86e1a86](AztecProtocol/aztec-packages@86e1a86))
* Add RelWithAssert build
([#4997](AztecProtocol/aztec-packages#4997))
([4f337c7](AztecProtocol/aztec-packages@4f337c7))
* Allow usage of noir `#[test]` syntax in stdlib
(noir-lang/noir#4553)
([86e1a86](AztecProtocol/aztec-packages@86e1a86))
* **AuthWit:** Simplify create authwit syntax
([#5132](AztecProtocol/aztec-packages#5132))
([d0a5b19](AztecProtocol/aztec-packages@d0a5b19))
* **avm:** Brillig CONST of size &gt; u128
([#5217](AztecProtocol/aztec-packages#5217))
([2e63479](AztecProtocol/aztec-packages@2e63479))
* **avm:** Mov opcode with direct memory
([#5204](AztecProtocol/aztec-packages#5204))
([08f9038](AztecProtocol/aztec-packages@08f9038)),
closes
[#5159](AztecProtocol/aztec-packages#5159)
* Brillig IR refactor
([#5233](AztecProtocol/aztec-packages#5233))
([9a73348](AztecProtocol/aztec-packages@9a73348))
* Check initializer msg.sender matches deployer from address preimage
([#5222](AztecProtocol/aztec-packages#5222))
([438d16f](AztecProtocol/aztec-packages@438d16f))
* Extended IPA tests and fuzzing
([#5140](AztecProtocol/aztec-packages#5140))
([0ae5ace](AztecProtocol/aztec-packages@0ae5ace))
* Initial Earthly CI
([#5069](AztecProtocol/aztec-packages#5069))
([8e75fe5](AztecProtocol/aztec-packages@8e75fe5))
* New Outbox Contract
[#4768](AztecProtocol/aztec-packages#4768)
([#5090](AztecProtocol/aztec-packages#5090))
([6421a3d](AztecProtocol/aztec-packages@6421a3d))
* Remove curly braces with fmt
(noir-lang/noir#4529)
([86e1a86](AztecProtocol/aztec-packages@86e1a86))
* Remove curly braces with fmt
(noir-lang/noir#4529)
([d8b8456](AztecProtocol/aztec-packages@d8b8456))
* Remove unnecessary `mulmod`s from verifier contract
([#5269](AztecProtocol/aztec-packages#5269))
([20d9c0c](AztecProtocol/aztec-packages@20d9c0c))
* Signed integer division and modulus in brillig gen
([#5279](AztecProtocol/aztec-packages#5279))
([82f8cf5](AztecProtocol/aztec-packages@82f8cf5))
* Use deployer in address computation
([#5201](AztecProtocol/aztec-packages#5201))
([258ff4a](AztecProtocol/aztec-packages@258ff4a))


### Bug Fixes

* **avm-transpiler:** RETURN is direct
([#5277](AztecProtocol/aztec-packages#5277))
([f90b2cf](AztecProtocol/aztec-packages@f90b2cf))
* **bb:** Mac build
([#5253](AztecProtocol/aztec-packages#5253))
([ae021c0](AztecProtocol/aztec-packages@ae021c0))
* CVC5 api update
([#5203](AztecProtocol/aztec-packages#5203))
([9cc32cb](AztecProtocol/aztec-packages@9cc32cb))
* Evaluate operators in globals in types
(noir-lang/noir#4537)
([86e1a86](AztecProtocol/aztec-packages@86e1a86))
* Evaluate operators in globals in types
(noir-lang/noir#4537)
([d8b8456](AztecProtocol/aztec-packages@d8b8456))
* Make `nargo` the default binary for cargo run
(noir-lang/noir#4554)
([86e1a86](AztecProtocol/aztec-packages@86e1a86))
* Make `nargo` the default binary for cargo run
(noir-lang/noir#4554)
([d8b8456](AztecProtocol/aztec-packages@d8b8456))
* Revert "fix: noir mirror merge strat"
([#5250](AztecProtocol/aztec-packages#5250))
([7e8e8e5](AztecProtocol/aztec-packages@7e8e8e5))
* Validation requests
([#5236](AztecProtocol/aztec-packages#5236))
([25ce33b](AztecProtocol/aztec-packages@25ce33b))


### Miscellaneous

* Add avm team to codeowners for public context
([#5288](AztecProtocol/aztec-packages#5288))
([e146076](AztecProtocol/aztec-packages@e146076))
* Add more `Hash` impls to stdlib
(noir-lang/noir#4470)
([86e1a86](AztecProtocol/aztec-packages@86e1a86))
* Add more `Hash` impls to stdlib
(noir-lang/noir#4470)
([d8b8456](AztecProtocol/aztec-packages@d8b8456))
* Add quick explanatory comment to outbox suggested by
[@benesjan](https://github.com/benesjan)
([#5247](AztecProtocol/aztec-packages#5247))
([56e8451](AztecProtocol/aztec-packages@56e8451))
* **avm-simulator:** Update e2e test
([#5283](AztecProtocol/aztec-packages#5283))
([e9beeca](AztecProtocol/aztec-packages@e9beeca))
* **avm-transpiler:** Return u8 in comparison ops
([#5280](AztecProtocol/aztec-packages#5280))
([1a5eb69](AztecProtocol/aztec-packages@1a5eb69))
* **avm-transpiler:** Transpiler cleanup
([#5218](AztecProtocol/aztec-packages#5218))
([199e918](AztecProtocol/aztec-packages@199e918))
* Delete ContractDao
([#5256](AztecProtocol/aztec-packages#5256))
([544e278](AztecProtocol/aztec-packages@544e278))
* Delete ContractData
([#5258](AztecProtocol/aztec-packages#5258))
([e516f9b](AztecProtocol/aztec-packages@e516f9b))
* Delete ExtendedContractData struct
([#5248](AztecProtocol/aztec-packages#5248))
([8ae0c13](AztecProtocol/aztec-packages@8ae0c13))
* Delete isInternal and isConstructor fields from FunctionData
([#5232](AztecProtocol/aztec-packages#5232))
([dea3f87](AztecProtocol/aztec-packages@dea3f87))
* Delete unused contract tree ts code
([#5229](AztecProtocol/aztec-packages#5229))
([b48dd23](AztecProtocol/aztec-packages@b48dd23))
* Delete unused hash functions
([#5231](AztecProtocol/aztec-packages#5231))
([fed70a1](AztecProtocol/aztec-packages@fed70a1))
* Fix docker test workflows
(noir-lang/noir#4566)
([86e1a86](AztecProtocol/aztec-packages@86e1a86))
* Fixing some broken links (noir-lang/noir#4556)
([86e1a86](AztecProtocol/aztec-packages@86e1a86))
* Making docs build before cutting versions
(noir-lang/noir#4568)
([86e1a86](AztecProtocol/aztec-packages@86e1a86))
* Old inbox purge
([#5206](AztecProtocol/aztec-packages#5206))
([a26d968](AztecProtocol/aztec-packages@a26d968))
* Removing redundant receipts check
([#5271](AztecProtocol/aztec-packages#5271))
([5ab07fb](AztecProtocol/aztec-packages@5ab07fb))
* Separate tests for execution failures from compilation failures
(noir-lang/noir#4559)
([86e1a86](AztecProtocol/aztec-packages@86e1a86))
* Separate tests for execution failures from compilation failures
(noir-lang/noir#4559)
([d8b8456](AztecProtocol/aztec-packages@d8b8456))
* Template Zeromorph by PCS
([#5215](AztecProtocol/aztec-packages#5215))
([03feab2](AztecProtocol/aztec-packages@03feab2))
* Use inotifywait to run generate in yarn-project
([#5168](AztecProtocol/aztec-packages#5168))
([137c13e](AztecProtocol/aztec-packages@137c13e))


### Documentation

* **yp:** Remove contract tree and deploy data from circuits and state
([#5260](AztecProtocol/aztec-packages#5260))
([acffa7b](AztecProtocol/aztec-packages@acffa7b))
</details>

<details><summary>barretenberg: 0.29.0</summary>

##
[0.29.0](AztecProtocol/aztec-packages@barretenberg-v0.28.1...barretenberg-v0.29.0)
(2024-03-18)


### ⚠ BREAKING CHANGES

* Acir call opcode
([#4773](AztecProtocol/aztec-packages#4773))

### Features

* Acir call opcode
([#4773](AztecProtocol/aztec-packages#4773))
([0b15db2](AztecProtocol/aztec-packages@0b15db2))
* Add RelWithAssert build
([#4997](AztecProtocol/aztec-packages#4997))
([4f337c7](AztecProtocol/aztec-packages@4f337c7))
* **avm:** Mov opcode with direct memory
([#5204](AztecProtocol/aztec-packages#5204))
([08f9038](AztecProtocol/aztec-packages@08f9038)),
closes
[#5159](AztecProtocol/aztec-packages#5159)
* Extended IPA tests and fuzzing
([#5140](AztecProtocol/aztec-packages#5140))
([0ae5ace](AztecProtocol/aztec-packages@0ae5ace))
* Initial Earthly CI
([#5069](AztecProtocol/aztec-packages#5069))
([8e75fe5](AztecProtocol/aztec-packages@8e75fe5))
* Remove unnecessary `mulmod`s from verifier contract
([#5269](AztecProtocol/aztec-packages#5269))
([20d9c0c](AztecProtocol/aztec-packages@20d9c0c))
* Signed integer division and modulus in brillig gen
([#5279](AztecProtocol/aztec-packages#5279))
([82f8cf5](AztecProtocol/aztec-packages@82f8cf5))


### Bug Fixes

* **bb:** Mac build
([#5253](AztecProtocol/aztec-packages#5253))
([ae021c0](AztecProtocol/aztec-packages@ae021c0))
* CVC5 api update
([#5203](AztecProtocol/aztec-packages#5203))
([9cc32cb](AztecProtocol/aztec-packages@9cc32cb))


### Miscellaneous

* Template Zeromorph by PCS
([#5215](AztecProtocol/aztec-packages#5215))
([03feab2](AztecProtocol/aztec-packages@03feab2))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
crypto cryptography
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants