issues

AztecProtocol · Mar 15, 2024 · 70f06db · 70f06db
1 parent 2022aa0
commit 70f06db
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 0 deletions.
diff --git a/barretenberg/cpp/src/barretenberg/ecc/groups/affine_element.hpp b/barretenberg/cpp/src/barretenberg/ecc/groups/affine_element.hpp
@@ -162,6 +162,7 @@ template <typename Fq_, typename Fr_, typename Params> class alignas(64) affine_
     Fq y;
 
     // for serialization: update with new fields
+    // TODO(https://github.com/AztecProtocol/barretenberg/issues/908) point at inifinty isn't handled
     MSGPACK_FIELDS(x, y);
 };
 } // namespace bb::group_elements

diff --git a/barretenberg/cpp/src/barretenberg/ecc/groups/affine_element.test.cpp b/barretenberg/cpp/src/barretenberg/ecc/groups/affine_element.test.cpp
@@ -115,6 +115,7 @@ template <typename G1> class TestAffineElement : public testing::Test {
      */
     static void test_msgpack_roundtrip()
     {
+        // TODO(https://github.com/AztecProtocol/barretenberg/issues/908) point at inifinty isn't handled
         auto [actual, expected] = msgpack_roundtrip(affine_element{ 1, 1 });
         EXPECT_EQ(actual, expected);
     }
@@ -206,6 +207,7 @@ TYPED_TEST(TestAffineElement, MulWithEndomorphismMatchesMulWithoutEndomorphism)
     }
 }
 
+// TODO(https://github.com/AztecProtocol/barretenberg/issues/909): These tests are not typed for no reason
 // Multiplication of a point at infinity by a scalar should be a point at infinity
 TEST(AffineElement, InfinityMulByScalarIsInfinity)
 {

diff --git a/barretenberg/cpp/src/barretenberg/ecc/groups/element.hpp b/barretenberg/cpp/src/barretenberg/ecc/groups/element.hpp
@@ -128,6 +128,7 @@ template <class Fq, class Fr, class Params> class alignas(32) element {
     //     return { x, y, Fq::one() };
     // }
     // for serialization: update with new fields
+    // TODO(https://github.com/AztecProtocol/barretenberg/issues/908) point at inifinty isn't handled
     MSGPACK_FIELDS(x, y, z);
 
     static void conditional_negate_affine(const affine_element<Fq, Fr, Params>& in,