Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding hash index in noir for private call stack item #499

Closed
rahul-kothari opened this issue May 8, 2023 · 5 comments · Fixed by #1394
Closed

Adding hash index in noir for private call stack item #499

rahul-kothari opened this issue May 8, 2023 · 5 comments · Fixed by #1394
Assignees
@sirasistant

Comments

@rahul-kothari
Copy link
Contributor

In C++, for the private kernel's call stack item, we hash the object using a GeneratorIndex aka hash index

We do that check here in the private kernel circuit.

On the client side, we hash the call stack item in private_call_stack_item.nr but we don't use a hash index!

Because of this nested calls to the private kernel is failing (now that we have error handling). I have commented out the validate_this_private_call_stack() check in the private kernel circuit for now because of this.
@github-project-automation github-project-automation bot moved this to Todo in A3 May 8, 2023
@rahul-kothari
Copy link
Contributor Author

rahul-kothari commented May 8, 2023 •
edited
Loading

From @sirasistant :
It isn't available yet - involves modifying the BB functions to be able to accept constants such as the hash index

https://aztecprotocol.slack.com/archives/C04QF64EDNV/p1683559405947599?thread_ts=1683559369.179149&cid=C04QF64EDNV

@rahul-kothari rahul-kothari mentioned this issue May 8, 2023
Merged
6 tasks
@spalladino
Copy link
Collaborator

Same applies to public call stack item in Noir being added in #546.

This was referenced May 23, 2023
Closed
Merged
@sirasistant
Copy link
Collaborator

I'm working on this now that we have support for hash_index

@sirasistant sirasistant mentioned this issue Jun 30, 2023
Merged
6 tasks
This was referenced Jul 26, 2023
Closed
Merged
@iAmMichaelConnor
Copy link
Contributor

@dbanks12 @suyash67 maybe something your team could pick up? :)

spalladino added a commit that referenced this issue Jul 31, 2023
@spalladino
fix(contracts): Calculate hash of private call stack items in Noir (#…
5bf5674 
…1209)

Fix hashing of private call stack items to be consistent across Noir and
cpp.

Note that this does not solve #499 in the kernel circuit (cc @jeanmon)
since uncommenting the call stack hash validation breaks most of the
kernel tests since they modify call stack items without updating the
corresponding hashes. I tried fixing them but after a few hours of
repeated failures decided to cut my losses and submit what I got working
on the noir and ts side.
@dbanks12
Copy link
Collaborator

@dbanks12 @suyash67 maybe something your team could pick up? :)

@suyash67 can you pick this up this week?

@suyash67 suyash67 mentioned this issue Aug 3, 2023
Merged
4 tasks
@github-project-automation github-project-automation bot moved this from Todo to Done in A3 Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sirasistant sirasistant

Labels
None yet
Projects
A3
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Reinstate call stack validation in PKC AztecProtocol/aztec-packages
5 participants
@spalladino @sirasistant @rahul-kothari @iAmMichaelConnor @dbanks12