Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ALU <--> Main inter-table relation for intermediate registers #4613

Closed
Tracked by #4303
jeanmon opened this issue Feb 15, 2024 · 0 comments · Fixed by #4945 or #4986
Closed
Tracked by #4303

ALU <--> Main inter-table relation for intermediate registers #4613

jeanmon opened this issue Feb 15, 2024 · 0 comments · Fixed by #4945 or #4986
Assignees
@jeanmon
Labels
C-avm Component: AVM related tickets (aka public VM)

Comments

@jeanmon
Copy link
Contributor

jeanmon commented Feb 15, 2024 •
edited
Loading

This check consists in enforcing that the intermediate registers are correctly copied back from the ALU trace to the main trace.

As part of this ticket, we should be able to remove the condition in the main trace enforcing that the values of the intermediate registers is zero when the memory error tag is raised. Instead, we can tolerate in this inter-table relation to not copy the intermediate registers to the ALU whenever the memory error tag is raised. In this way, no relation is enforced on the intermediate registers pertaining the operation.

Adapt the witness generation accordingly.
Note however that the values of intermediate registers will need to be consistent with memory trace.
@jeanmon jeanmon mentioned this issue Feb 15, 2024
Closed
@github-project-automation github-project-automation bot moved this to Todo in A3 Feb 15, 2024
@jeanmon jeanmon added the C-avm Component: AVM related tickets (aka public VM) label Feb 15, 2024
@jeanmon jeanmon self-assigned this Feb 15, 2024
@jeanmon jeanmon changed the title ALU - Main inter-table relation for intermediate registers ALU <--> Main inter-table relation for intermediate registers Feb 15, 2024
@jeanmon jeanmon moved this from Todo to In Progress in A3 Feb 22, 2024
@jeanmon jeanmon mentioned this issue Mar 5, 2024
Merged
@jeanmon jeanmon moved this from In Progress to In Review in A3 Mar 5, 2024
IlyasRidhuan pushed a commit that referenced this issue Mar 6, 2024
@jeanmon
feat(avm): ALU <--> MAIN inter table relation on intermediate registe…
8708131 
…rs copy (#4945)

Resolves #4613
@github-project-automation github-project-automation bot moved this from In Review to Done in A3 Mar 6, 2024
@AztecBot AztecBot mentioned this issue Mar 6, 2024
Merged
PhilWindle pushed a commit that referenced this issue Mar 6, 2024
@AztecBot
chore(master): Release 0.26.4 (#4986)
6522738 
🤖 I have created a release *beep* *boop*
---


<details><summary>aztec-package: 0.26.4</summary>

##
[0.26.4](aztec-package-v0.26.3...aztec-package-v0.26.4)
(2024-03-06)


### Miscellaneous

* **aztec-package:** Synchronize aztec-packages versions
</details>

<details><summary>barretenberg.js: 0.26.4</summary>

##
[0.26.4](barretenberg.js-v0.26.3...barretenberg.js-v0.26.4)
(2024-03-06)


### Miscellaneous

* **barretenberg.js:** Synchronize aztec-packages versions
</details>

<details><summary>aztec-cli: 0.26.4</summary>

##
[0.26.4](aztec-cli-v0.26.3...aztec-cli-v0.26.4)
(2024-03-06)


### Miscellaneous

* **aztec-cli:** Synchronize aztec-packages versions
</details>

<details><summary>aztec-packages: 0.26.4</summary>

##
[0.26.4](aztec-packages-v0.26.3...aztec-packages-v0.26.4)
(2024-03-06)


### Features

* **avm:** ALU &lt;--&gt; MAIN inter table relation on intermediate
registers copy
([#4945](#4945))
([8708131](8708131)),
closes
[#4613](#4613)
* Circuit checker class
([#4931](#4931))
([4eba266](4eba266))
* Compute out hash in circuits
[#4561](#4561)
([#4873](#4873))
([06a9116](06a9116))


### Bug Fixes

* **ci:** Noir mirror base commit
([#4969](#4969))
([546c666](546c666))
* Fix release
([#4994](#4994))
([19a8728](19a8728))


### Miscellaneous

* Use public constructors where possible
([#4937](#4937))
([225aad6](225aad6))
</details>

<details><summary>barretenberg: 0.26.4</summary>

##
[0.26.4](barretenberg-v0.26.3...barretenberg-v0.26.4)
(2024-03-06)


### Features

* **avm:** ALU &lt;--&gt; MAIN inter table relation on intermediate
registers copy
([#4945](#4945))
([8708131](8708131)),
closes
[#4613](#4613)
* Circuit checker class
([#4931](#4931))
([4eba266](4eba266))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
@AztecBot AztecBot mentioned this issue Mar 6, 2024
Merged
AztecBot added a commit to AztecProtocol/barretenberg that referenced this issue Mar 7, 2024
@AztecBot
chore(master): Release 0.26.4 (#4986)
50b3de0 
🤖 I have created a release *beep* *boop*
---


<details><summary>aztec-package: 0.26.4</summary>

##
[0.26.4](AztecProtocol/aztec-packages@aztec-package-v0.26.3...aztec-package-v0.26.4)
(2024-03-06)


### Miscellaneous

* **aztec-package:** Synchronize aztec-packages versions
</details>

<details><summary>barretenberg.js: 0.26.4</summary>

##
[0.26.4](AztecProtocol/aztec-packages@barretenberg.js-v0.26.3...barretenberg.js-v0.26.4)
(2024-03-06)


### Miscellaneous

* **barretenberg.js:** Synchronize aztec-packages versions
</details>

<details><summary>aztec-cli: 0.26.4</summary>

##
[0.26.4](AztecProtocol/aztec-packages@aztec-cli-v0.26.3...aztec-cli-v0.26.4)
(2024-03-06)


### Miscellaneous

* **aztec-cli:** Synchronize aztec-packages versions
</details>

<details><summary>aztec-packages: 0.26.4</summary>

##
[0.26.4](AztecProtocol/aztec-packages@aztec-packages-v0.26.3...aztec-packages-v0.26.4)
(2024-03-06)


### Features

* **avm:** ALU &lt;--&gt; MAIN inter table relation on intermediate
registers copy
([#4945](AztecProtocol/aztec-packages#4945))
([8708131](AztecProtocol/aztec-packages@8708131)),
closes
[#4613](AztecProtocol/aztec-packages#4613)
* Circuit checker class
([#4931](AztecProtocol/aztec-packages#4931))
([4eba266](AztecProtocol/aztec-packages@4eba266))
* Compute out hash in circuits
[#4561](AztecProtocol/aztec-packages#4561)
([#4873](AztecProtocol/aztec-packages#4873))
([06a9116](AztecProtocol/aztec-packages@06a9116))


### Bug Fixes

* **ci:** Noir mirror base commit
([#4969](AztecProtocol/aztec-packages#4969))
([546c666](AztecProtocol/aztec-packages@546c666))
* Fix release
([#4994](AztecProtocol/aztec-packages#4994))
([19a8728](AztecProtocol/aztec-packages@19a8728))


### Miscellaneous

* Use public constructors where possible
([#4937](AztecProtocol/aztec-packages#4937))
([225aad6](AztecProtocol/aztec-packages@225aad6))
</details>

<details><summary>barretenberg: 0.26.4</summary>

##
[0.26.4](AztecProtocol/aztec-packages@barretenberg-v0.26.3...barretenberg-v0.26.4)
(2024-03-06)


### Features

* **avm:** ALU &lt;--&gt; MAIN inter table relation on intermediate
registers copy
([#4945](AztecProtocol/aztec-packages#4945))
([8708131](AztecProtocol/aztec-packages@8708131)),
closes
[#4613](AztecProtocol/aztec-packages#4613)
* Circuit checker class
([#4931](AztecProtocol/aztec-packages#4931))
([4eba266](AztecProtocol/aztec-packages@4eba266))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeanmon jeanmon

Labels
C-avm Component: AVM related tickets (aka public VM)
Projects
A3
Archived in project
Milestone
No milestone
1 participant
@jeanmon