-
Notifications
You must be signed in to change notification settings - Fork 268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor: Improve clarity of note syntax #4199
Comments
#4207 reduces the entry-points for the note/nullifier slightly. |
Discussions with @sirasistant and others lead to updating the |
See #4344 for more changes related to the lifecycle naming. |
…ntent_hash (#4342) Part of #4199. Discussions with @sirasistant and others lead to updating the `compute_note_hash` function name to `compute_note_content_hash` to avoid confusion with the actual note hash.
#4383 updated the I'm not sure how much more we can change around the note syntax, unless we try removing the header entirely from the note, and have something like a |
For above mentioned reasons. I will close this issue, and create #4419 where this can be discussed. |
…ntent_hash (AztecProtocol#4342) Part of AztecProtocol#4199. Discussions with @sirasistant and others lead to updating the `compute_note_hash` function name to `compute_note_content_hash` to avoid confusion with the actual note hash.
…ztecProtocol#4344) Part of AztecProtocol#4199 Replaces the `compute_note_hash_for_read_or_nullify` with two functions: - `compute_note_hash_for_insertion` - `compute_note_hash_for_consumption` The practical difference is small, but should make it a bit easier to follow the flow
The life-cycle of notes is currently fairly hard to follow. This is partly due to its creation before traits was available, and partly from the fact that parts of the nullifier computation depends on what the nullifier is to be used for.
E.g., when computing a nullifier to emit, that is different than when you wish to prove that some nullifier is in the state.
The difference is an effect of the insertion relying on the kernel to apply transformations before actually being inserted into state, and for reads it needs to apply those transformations itself.
It means that there currently are execution flows that "go in circles" which can be quite strange to follow.
The text was updated successfully, but these errors were encountered: