Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Base rollup calldata parity #413

Closed
LHerskind opened this issue Apr 28, 2023 · 1 comment
Closed

Base rollup calldata parity #413

LHerskind opened this issue Apr 28, 2023 · 1 comment
Assignees
Labels
S-blocked Status: Blocked

Comments

@LHerskind
Copy link
Contributor

The native base rollup implementation differs in the computaiton of calldata hash from #412. Should be updated to use same ordering and have parity.

The calldata hash between CPP and (SOL/TS) will not hit parity until BB is fixed to make WASM and CPP use same generators for hash computations.

@LHerskind LHerskind added this to A3 Apr 28, 2023
@LHerskind LHerskind converted this from a draft issue Apr 28, 2023
@LHerskind LHerskind moved this from Todo to Blocked in A3 Apr 28, 2023
@LHerskind LHerskind self-assigned this May 9, 2023
ludamad pushed a commit that referenced this issue Jul 14, 2023
@LHerskind LHerskind added S-blocked Status: Blocked and removed S-blocked Status: Blocked labels Oct 11, 2023
@LHerskind
Copy link
Contributor Author

I think this was handled way back and should be checked by:

  • the integration_l1_publisher.test.ts checking that solidity and ts land on same values
  • the e2e tests use cpp to build the contents and then the solidity to progress state

@github-project-automation github-project-automation bot moved this from Blocked to Done in A3 Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-blocked Status: Blocked
Projects
Archived in project
Development

No branches or pull requests

1 participant