feat: Goblin acir composer

[ledwards2225]

A bit of background: At the end of 2023, we had a small subset of the acir_tests passing for GUH+Goblin. Early work in 2024 got all of the tests passing for GUH. (At this stage we were basically running all acir_tests for UltraPlonk and GoblinUltraHonk). I turned the Goblin component off because tests were failing in an unpredictable way. (I now think this is a deterministic issue with the Translator that was showing up more prominently due to running the Translator hundreds of times via the acir_tests suite). This work maintains testing of all the noir programs in the acir_test suite for GUH, but adds back in a full Goblin workflow for a single arbitrary test. This is done through two workflows: a "goblin accumulate" workflow (for constructing/verifying GUH proofs) and a "full goblin" flow (for additionally constructing and verifying ECCVM/Translator proofs). (Note: this latter flow will eventually also involve merge logic but that's still not incorporated in this work).

To make things cleaner, I've introduced a GoblinAcirComposer to handle all Goblin/Honk logic, analogous to the AcirComposer for UltraPlonk.

Note: there is still no mechanism for creating goblin ops directly from acir opcodes. (Eventually this will just happen via a blackbox call to some recursive verification / folding operation for Honk/Goblin). The OpQueue being processed by the ECCVM/Translator is just a random set of ops "appended" to the circuit in question.

[AztecBot]

Benchmark results

Metrics with a significant change:

• batch_insert_into_indexed_tree_20_depth_ms (512): 369 (-23%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Values are compared against data from master at commit 38d262ed and shown if the difference exceeds 1%.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	8 txs	32 txs	128 txs
l1_rollup_calldata_size_in_bytes	45,412	179,524	716,068
l1_rollup_calldata_gas	221,692	866,932	3,448,444
l1_rollup_execution_gas	314,111	984,604	3,668,033
l2_block_processing_time_in_ms	1,596 (+2%)	5,255 (-1%)	20,882
note_successful_decrypting_time_in_ms	289 (+2%)	839	3,201 (+1%)
note_trial_decrypting_time_in_ms	98.4 (+5%)	70.0	141 (-7%)
l2_block_building_time_in_ms	16,115	63,877	255,805
l2_block_rollup_simulation_time_in_ms	11,721	46,501	186,826
l2_block_public_tx_process_time_in_ms	4,361	17,290	68,702

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric	5 blocks	10 blocks
node_history_sync_time_in_ms	15,811 (-3%)	30,465 (+1%)
note_history_successful_decrypting_time_in_ms	1,965	3,876 (+1%)
note_history_trial_decrypting_time_in_ms	134 (-8%)	236 (+2%)
node_database_size_in_bytes	3,512,380	3,547,421
pxe_database_size_in_bytes	29,923	59,478

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit	circuit_simulation_time_in_ms	circuit_input_size_in_bytes	circuit_output_size_in_bytes
private-kernel-init	212	44,681	25,561
private-kernel-ordering	165	43,753	14,809
base-rollup	1,197	128,338	881
root-rollup	79.4	4,088	677
private-kernel-inner	291	71,208	25,561
public-kernel-private-input	205	31,863	25,561
public-kernel-non-first-iteration	203	31,905	25,561
merge-rollup	7.58	2,608	881

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	2 leaves	8 leaves	16 leaves	32 leaves	128 leaves	64 leaves	512 leaves	1024 leaves	2048 leaves	8192 leaves
batch_insert_into_append_only_tree_16_depth_ms	12.0 (-2%)	17.4 (-1%)	13.5 (-1%)	19.8 (+1%)	25.6 (+5%)	67.1	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.9	17.5	23.0	31.6	47.0	143	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.614 (-2%)	0.611 (-2%)	0.548 (-1%)	0.552 (+1%)	0.486 (+1%)	0.445	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	N/A	N/A	N/A	82.5 (-2%)	52.0	249 (-15%)	478	915	3,578
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	N/A	N/A	N/A	159	96.0	543	1,055	2,079	8,223
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	N/A	N/A	N/A	0.475 (+1%)	0.500	0.439 (-12%)	0.435	0.431	0.428
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	N/A	N/A	N/A	118 (-9%)	62.3	⚠️ 369 (-23%)	760 (-1%)	1,443 (+1%)	5,664 (+1%)
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	N/A	N/A	N/A	197	104	691	1,363	2,707	10,771
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	N/A	N/A	N/A	0.507 (-5%)	0.505	0.478 (-10%)	0.480 (-1%)	0.476	0.475 (+1%)
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	N/A	67.4	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	N/A	94.1	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	N/A	0.597	N/A	N/A	N/A	N/A	N/A	N/A	N/A

Miscellaneous

Transaction sizes based on how many contracts are deployed in the tx.

Metric	0 deployed contracts	1 deployed contracts
tx_size_in_bytes	15,455	32,223

Transaction processing duration by data writes.

Metric	0 new commitments	1 new commitments
tx_pxe_processing_time_ms	374	1,083

Metric	1 public data writes
tx_sequencer_processing_time_ms	534

[ledwards2225]

This code is related to the c binds and is autogenerated

[ledwards2225]

Code in this file is autogenerated based on c binds

[codygunton]

Looks like a very straightforward addition following existing patterns ✓

[codygunton]

You love to see it.