Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[contract-deploy] Listen to instance deployed events in nodes #4072

Closed
Tracked by #4052
spalladino opened this issue Jan 17, 2024 · 0 comments · Fixed by #4436
Closed
Tracked by #4052

[contract-deploy] Listen to instance deployed events in nodes #4072

spalladino opened this issue Jan 17, 2024 · 0 comments · Fixed by #4436

Comments

@spalladino
Copy link
Collaborator

spalladino commented Jan 17, 2024 •
edited
Loading

Similar to #4070, nodes should listen to events emitted by the contract instance deployer contract, and store the instances information in their local db. Again, nodes should be able to collect this information from the DAL, which we can test by checking that a node that did not push a deployment tx has information on the instance once the tx is mined and pushed to L1.

With this, a node should have all required information to run a public function. Test that it's possible to call a public function on a deployed contract, even on the same tx in which it was deployed.
@spalladino spalladino mentioned this issue Jan 17, 2024
Closed
@github-project-automation github-project-automation bot moved this to Todo in A3 Jan 17, 2024
@spalladino spalladino mentioned this issue Feb 5, 2024
Merged
@github-project-automation github-project-automation bot moved this from Todo to Done in A3 Feb 7, 2024
TomAFrench pushed a commit that referenced this issue Feb 7, 2024
@spalladino @TomAFrench
feat: Canonical instance deployer contract (#4436)
53af19c 
Implementation for the initial contract instance deployer contract.
Tracks instance deployed events in nodes and stores them locally.

Skips validations for class id and eth address for now.

Fixes #4071
Fixes #4072
michaelelliot pushed a commit to Swoir/noir_rs that referenced this issue Feb 28, 2024
@spalladino
feat: Canonical instance deployer contract (AztecProtocol#4436)
951a0d0 
Implementation for the initial contract instance deployer contract.
Tracks instance deployed events in nodes and stores them locally.

Skips validations for class id and eth address for now.

Fixes AztecProtocol#4071
Fixes AztecProtocol#4072
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
A3
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Canonical instance deployer contract AztecProtocol/aztec-packages
1 participant
@spalladino