Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Public kernel circuit should calculate the hash of the SignedTxRequest and emit the value as the first nullifier #377

Closed
PhilWindle opened this issue Apr 25, 2023 · 0 comments · Fixed by #541
Closed

Public kernel circuit should calculate the hash of the SignedTxRequest and emit the value as the first nullifier #377

PhilWindle opened this issue Apr 25, 2023 · 0 comments · Fixed by #541
Assignees
@benesjan
Milestone
🦜 Mimic Public Fu...

Comments

@PhilWindle
Copy link
Collaborator

PhilWindle commented Apr 25, 2023 •
edited
Loading

The circuit will need to validate that the set of nullifiers is not already full and error if it is.
@PhilWindle PhilWindle added this to A3 Apr 25, 2023
@PhilWindle PhilWindle converted this from a draft issue Apr 25, 2023
@spalladino spalladino mentioned this issue Apr 25, 2023
Closed
@PhilWindle PhilWindle changed the title Update Tx object to calculate the tx hash from the signedTxRequest Public kernel circuit should calculate the hash of the SignedTxRequest and emit the value as the first nullifier May 7, 2023
@benesjan benesjan self-assigned this May 15, 2023
@benesjan benesjan moved this from Todo to In Progress in A3 May 15, 2023
@benesjan benesjan mentioned this issue May 15, 2023
Merged
6 tasks
@benesjan benesjan moved this from In Progress to In Review in A3 May 16, 2023
@github-project-automation github-project-automation bot moved this from In Review to Done in A3 May 16, 2023
ludamad pushed a commit that referenced this issue Jul 14, 2023
@zac-williamson @codygunton
Zw/recursion constraint reduction (#377)
1fdcaf8 
* removed blake3s hash from ultraplonk recursive prover
* UltraComposer will now not create duplicate non-native field multiplication constraints
* Propagate new stuff to Honk and splitting_tmp.
* Clean up and add comments.
---------

Co-authored-by: codygunton <[email protected]>
@iAmMichaelConnor iAmMichaelConnor removed this from A3 Jul 26, 2023
codygunton added a commit that referenced this issue Jan 23, 2024
@zac-williamson @codygunton
Zw/recursion constraint reduction (#377)
acc6b95 
* removed blake3s hash from ultraplonk recursive prover
* UltraComposer will now not create duplicate non-native field multiplication constraints
* Propagate new stuff to Honk and splitting_tmp.
* Clean up and add comments.
---------

Co-authored-by: codygunton <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benesjan benesjan

Labels
None yet
Projects
None yet
Milestone
🦜 Mimic Public Function Call
Development

Successfully merging a pull request may close this issue.

Tx hash as first nullifier AztecProtocol/aztec-packages
3 participants
@spalladino @benesjan @PhilWindle