Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update components to take tx hash from first tx nullifer (settled txs) #374

Closed
PhilWindle opened this issue Apr 25, 2023 · 3 comments
Closed

Comments

@PhilWindle
Copy link
Collaborator

No description provided.

@PhilWindle PhilWindle added this to A3 Apr 25, 2023
@PhilWindle PhilWindle converted this from a draft issue Apr 25, 2023
@PhilWindle PhilWindle removed this from A3 May 7, 2023
ludamad added a commit that referenced this issue Jul 14, 2023
* Regenerate pedersen lookup tables if they're empty

* re-init generator tables if they're empty.

* feat(nullifier_tree): make empty nullifier tree leaves hash be 0 (#360)

* feat(nullifier_tree): make empty nullifier tree leaves be 0

* fix: add append zero behaviour and test

* fix: explicit type name

* clean: update class semantics

---------

Co-authored-by: cheethas <[email protected]>
Co-authored-by: cheethas <[email protected]>

* More generators for aztec3.

* update js vk (because we now use UP for merkle hashing)

* Helpers for ECDSA in A3 (#364)

* Add `stdlib_keccak` in cmake.

Correct an assertion in `to_byte_array` in bigfield.

* Add `random_element` to affine element.

* negate y conditionally.

* feat(nullifier_tree): make empty nullifier tree leaves hash be 0 (#360)

* feat(nullifier_tree): make empty nullifier tree leaves be 0

* fix: add append zero behaviour and test

* fix: explicit type name

* clean: update class semantics

---------

Co-authored-by: cheethas <[email protected]>
Co-authored-by: cheethas <[email protected]>

* Change pedersen hash c_bind to use `pedersen_hash::lookup`.

* feat: add msgpack-c submodule

* Give up on msgpack c_master

* Working hacky msgpack test

* Interim work

* Interim work

* Getting rid of memory hacks

* fix: memory leaks

* Start of demoing cbinds

* Align with other methods

* chore: Remove need to return from msgpack method

* Iterate example

* fix: Hack around generator issues

* feat: iterate on msgpack in bb

* fix: fork msgpack for greater checks

* Refactor

* cleanup

* Update turbo_circuit_constructor.cpp

* chore: continued cleanup

* chore: continued cleanup

* chore: continued cleanup

* Refactor

* Refactor

* fix: ci

* feat(wasm): hacks to make work in a fno-exceptions wasm environment

* feat(wasm): bump msgpack-c

* feat(msgpack): first 'complex' object bound

* More wasm fixes. Was breaking throw() declaration

* Fix field serialization

* refactoring

* Update CMakeLists.txt

* Remove // TODO redundant with msgpack

* Refactor to use macro

* Refactor to use macro

* fix printing bug

* fix: fieldd msgpack endianness fix

* fix: remove shared ptr reference

* doc

* Add static checking for MSGPACK usage

* Revert log.hpp change

* Update struct_map_impl.hpp

* Revert

* remote_build fix

* Keep trying to init submodules

* Keep trying to init submodules

* Bump

* Add missing init_submodules

* Msgpack test fix

* Msgpack test fix

* Msgpack test fix

* Msgpack test fix

* Update polynomial_store.test.cpp

* Merge master

* Update msgpack error

* Better abort distinguishing

* fix: join split VK hash

* Serialization updates

* Fix circuits build

* Try to make circuits test work again

* Try to make circuits test work again

* Try to make circuits test work again

* fix: initialization warning

* fix: prefer default constructor for field, related cleanup

* Grand rename

* chore: remove unused funcs

* Revert fields constructor change for now

* chore: Revert .circleci changes

* chore: Revert foundation removal

* Revert .gitmodules

* Update affine_element.hpp

* Update element.hpp

* Revert header optimizations

* Revert init line

* Update polynomial_store.test.cpp

* Revert header optimization

* Update raw_pointer.hpp

* Update raw_pointer.hpp

* Update func_traits.hpp documentation

* Document msgpack methods in field_impl.hpp

* Update msgpack.hpp

* Update cbind.hpp

* Update msgpack.hpp

* Update msgpack.hpp

* Update schema_impl.hpp

* Update g1.hpp

---------

Co-authored-by: Suyash Bagad <[email protected]>
Co-authored-by: Maddiaa <[email protected]>
Co-authored-by: cheethas <[email protected]>
Co-authored-by: cheethas <[email protected]>
Co-authored-by: Suyash Bagad <[email protected]>
@github-project-automation github-project-automation bot moved this to Todo in A3 Aug 7, 2023
@iAmMichaelConnor
Copy link
Contributor

Complete?

@PhilWindle
Copy link
Collaborator Author

Yes

@PhilWindle
Copy link
Collaborator Author

Closed

@github-project-automation github-project-automation bot moved this from Todo to Done in A3 Aug 7, 2023
codygunton pushed a commit that referenced this issue Jan 23, 2024
* Regenerate pedersen lookup tables if they're empty

* re-init generator tables if they're empty.

* feat(nullifier_tree): make empty nullifier tree leaves hash be 0 (#360)

* feat(nullifier_tree): make empty nullifier tree leaves be 0

* fix: add append zero behaviour and test

* fix: explicit type name

* clean: update class semantics

---------

Co-authored-by: cheethas <[email protected]>
Co-authored-by: cheethas <[email protected]>

* More generators for aztec3.

* update js vk (because we now use UP for merkle hashing)

* Helpers for ECDSA in A3 (#364)

* Add `stdlib_keccak` in cmake.

Correct an assertion in `to_byte_array` in bigfield.

* Add `random_element` to affine element.

* negate y conditionally.

* feat(nullifier_tree): make empty nullifier tree leaves hash be 0 (#360)

* feat(nullifier_tree): make empty nullifier tree leaves be 0

* fix: add append zero behaviour and test

* fix: explicit type name

* clean: update class semantics

---------

Co-authored-by: cheethas <[email protected]>
Co-authored-by: cheethas <[email protected]>

* Change pedersen hash c_bind to use `pedersen_hash::lookup`.

* feat: add msgpack-c submodule

* Give up on msgpack c_master

* Working hacky msgpack test

* Interim work

* Interim work

* Getting rid of memory hacks

* fix: memory leaks

* Start of demoing cbinds

* Align with other methods

* chore: Remove need to return from msgpack method

* Iterate example

* fix: Hack around generator issues

* feat: iterate on msgpack in bb

* fix: fork msgpack for greater checks

* Refactor

* cleanup

* Update turbo_circuit_constructor.cpp

* chore: continued cleanup

* chore: continued cleanup

* chore: continued cleanup

* Refactor

* Refactor

* fix: ci

* feat(wasm): hacks to make work in a fno-exceptions wasm environment

* feat(wasm): bump msgpack-c

* feat(msgpack): first 'complex' object bound

* More wasm fixes. Was breaking throw() declaration

* Fix field serialization

* refactoring

* Update CMakeLists.txt

* Remove // TODO redundant with msgpack

* Refactor to use macro

* Refactor to use macro

* fix printing bug

* fix: fieldd msgpack endianness fix

* fix: remove shared ptr reference

* doc

* Add static checking for MSGPACK usage

* Revert log.hpp change

* Update struct_map_impl.hpp

* Revert

* remote_build fix

* Keep trying to init submodules

* Keep trying to init submodules

* Bump

* Add missing init_submodules

* Msgpack test fix

* Msgpack test fix

* Msgpack test fix

* Msgpack test fix

* Update polynomial_store.test.cpp

* Merge master

* Update msgpack error

* Better abort distinguishing

* fix: join split VK hash

* Serialization updates

* Fix circuits build

* Try to make circuits test work again

* Try to make circuits test work again

* Try to make circuits test work again

* fix: initialization warning

* fix: prefer default constructor for field, related cleanup

* Grand rename

* chore: remove unused funcs

* Revert fields constructor change for now

* chore: Revert .circleci changes

* chore: Revert foundation removal

* Revert .gitmodules

* Update affine_element.hpp

* Update element.hpp

* Revert header optimizations

* Revert init line

* Update polynomial_store.test.cpp

* Revert header optimization

* Update raw_pointer.hpp

* Update raw_pointer.hpp

* Update func_traits.hpp documentation

* Document msgpack methods in field_impl.hpp

* Update msgpack.hpp

* Update cbind.hpp

* Update msgpack.hpp

* Update msgpack.hpp

* Update schema_impl.hpp

* Update g1.hpp

---------

Co-authored-by: Suyash Bagad <[email protected]>
Co-authored-by: Maddiaa <[email protected]>
Co-authored-by: cheethas <[email protected]>
Co-authored-by: cheethas <[email protected]>
Co-authored-by: Suyash Bagad <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

3 participants